[{"id":2878,"web_url":"https://patchwork.libcamera.org/comment/2878/","msgid":"<20191013151842.GJ23166@bigcity.dyn.berto.se>","date":"2019-10-13T15:18:42","subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: pipeline: rkisp1:\n\tAvoid copy assignment of V4L2 control map","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-12 21:43:54 +0300, Laurent Pinchart wrote:\n> Use the std::map::emplace() method to avoid unnecessary creation of an\n> empty V4L2ControlInfoMap folled by a copy assignment.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 029d5868d11f..32b023730009 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -777,7 +777,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n> \t};\n> \n> \tstd::map entityControls;\n> -\tentityControls[0] = data->sensor_->controls();\n> +\tentityControls.emplace(0, data->sensor_->controls());\n> \n> \tdata->ipa_->configure(streamConfig, entityControls);\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C785961562\n\tfor ;\n\tSun, 13 Oct 2019 17:18:43 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id 7so14165981ljw.7\n\tfor ;\n\tSun, 13 Oct 2019 08:18:43 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tl3sm3459517lfc.31.2019.10.13.08.18.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Oct 2019 08:18:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=7x3r4zBart2cD+pdft9siaBz/+DOoYLJsC0rNviiv8s=;\n\tb=yJ115pcVths9mu1gGy9Kd0M7T9coAtCDikQpiffL3j05szRttGkdbiP+GFsmU5V/ss\n\t7zqAgjY/NAQx5UbkkvyZcog+KLGIvAdfqJDGAEgmllaRbAJ9/70uJyTZ42MwBQvl4V0J\n\tHzYNzJ+xCej/Sr/D9fMOs6qM4K0tATcmT84AoAfwehKVGhEgbEOCulix75MM4SmrOviz\n\tIqz/ZRQFhXZYLvRQg6swIuTlLPzaeA6bav/qQTR19JqxXfAY/hjR3ugrjB1pmLYGghMc\n\to4gUU/hWSadcJIYjgzDekuat4BdmpniHt1NNETwEa1GWsWIEuQtbbT8VbWsmkbHOwmWT\n\tnI7A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=7x3r4zBart2cD+pdft9siaBz/+DOoYLJsC0rNviiv8s=;\n\tb=HSCQJzrsN2lHi9wmp3WVciGeepQbn2AZqBi4rdvwAk/HSK72L03ecwqWsBbqhiSiFp\n\txuB6KcOcspea/uygegcJSWwUKLfNeMqdoqtWywhCKJenxsKIjBFYhb2qSN8SQSEtsxU0\n\tsWwAXVd98n2M37EEjAJiRPf8XDZcfpMBebB93hsnECenGaylTPuvPJJBpRuZl6p+jm2U\n\tRcQqYm5H4B064H9xFgvsOzgYJ1x83+tCeiYZpJRtzcB8/mlhVtb/NynE33HHaOyIGv18\n\tmOvFkPov5tY//GSOK+Y73tP/JY0G2TzLDwyEIr68yT8VIbBbwuDVWQGLF/GARyN25m9t\n\tuBhA==","X-Gm-Message-State":"APjAAAXp9S98a0xe4oT/zhpqeiPxaU3nuZcIv0D8IcMUqa6sdRS1lwlM\n\tt1uhZtSLCHVslFiXcbuAy/i/4IxF3K8=","X-Google-Smtp-Source":"APXvYqzjArJ9a3jiZf7J/3CFuEXdun1F9rn+iM/7opxqyciKIJ0+NCufsKiEBSEpDkgzA5cSxzroDA==","X-Received":"by 2002:a2e:88d0:: with SMTP id\n\ta16mr15806965ljk.39.1570979923270; \n\tSun, 13 Oct 2019 08:18:43 -0700 (PDT)","Date":"Sun, 13 Oct 2019 17:18:42 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013151842.GJ23166@bigcity.dyn.berto.se>","References":"<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>\n\t<20191012184407.31684-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191012184407.31684-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: pipeline: rkisp1:\n\tAvoid copy assignment of V4L2 control map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 15:18:43 -0000"}}]