[{"id":31738,"web_url":"https://patchwork.libcamera.org/comment/31738/","msgid":"<20241014193227.GD13238@pendragon.ideasonboard.com>","date":"2024-10-14T19:32:27","subject":"Re: [PATCH 1/2] libcamera: android: include token only in\n\tcros_mojo_token.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey, Han-Lin,\n\nThank you for the patch.\n\nOn Mon, Oct 14, 2024 at 01:18:56PM +0000, Harvey Yang wrote:\n> To avoid unnecessary dependency, especially on libchrome base, include\n> only `cros-camera/camera_mojo_channel_manager_token.h` in\n> `cros_mojo_token.h`.\n> \n> Signed-off-by: Harvey Yang \n> Co-developed-by: Han-Lin Chen \n> Signed-off-by: Han-Lin Chen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/cros_mojo_token.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/cros_mojo_token.h b/src/android/cros_mojo_token.h\n> index d0baa80fc..fc57205a8 100644\n> --- a/src/android/cros_mojo_token.h\n> +++ b/src/android/cros_mojo_token.h\n> @@ -7,6 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> +#include \n> \n> inline cros::CameraMojoChannelManagerToken *gCrosMojoToken = nullptr;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F1E8C32F4\n\tfor ;\n\tMon, 14 Oct 2024 19:32:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AFC865381;\n\tMon, 14 Oct 2024 21:32:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E29EC6537C\n\tfor ;\n\tMon, 14 Oct 2024 21:32:33 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [23.233.251.139])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E5358BE;\n\tMon, 14 Oct 2024 21:30:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zwch4wH1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728934252;\n\tbh=zyPvQAmSsipkRXmVQSi5lPnpfaVUy0szJWouS8VOtSc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zwch4wH1yecZFsb3aLlcB6SrwfXDt0ZdWcPLIHgyxuHUrfv8oI62HoY12TWxoH9jZ\n\tj2aGhsQoXytOmMpyszQlQoAm2pAHANtjKl92OtG561UjMNQnK0Jv3tr1ry3nK1lrfD\n\tqR7WxoCdq+1gfHROF881K4IO0mHmU1qRNt5wF/HE=","Date":"Mon, 14 Oct 2024 22:32:27 +0300","From":"Laurent Pinchart ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHan-Lin Chen ","Subject":"Re: [PATCH 1/2] libcamera: android: include token only in\n\tcros_mojo_token.h","Message-ID":"<20241014193227.GD13238@pendragon.ideasonboard.com>","References":"<20241014140038.1133270-1-chenghaoyang@chromium.org>\n\t<20241014140038.1133270-2-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241014140038.1133270-2-chenghaoyang@chromium.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]