[{"id":31744,"web_url":"https://patchwork.libcamera.org/comment/31744/","msgid":"<20241015102202.GD5682@pendragon.ideasonboard.com>","date":"2024-10-15T10:22:02","subject":"Re: [PATCH 1/2] libcamera: add OS_CHROMEOS when the android_platform\n\tis cros","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey, Han-Lin,\n\nThank you for the patch.\n\nOn Mon, Oct 14, 2024 at 08:13:54AM +0000, Harvey Yang wrote:\n> From: Han-Lin Chen \n> \n> Add OS_CHROMEOS when the android_platform is cros.\n> \n> Signed-off-by: Han-Lin Chen \n> Co-developed-by: Harvey Yang \n> Signed-off-by: Harvey Yang \n> ---\n> meson.build | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 63e45465d..e28fa8599 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -184,6 +184,10 @@ if cc.has_argument('-Wno-c99-designator')\n> ]\n> endif\n> \n> +if get_option('android_platform') == 'cros'\n> + common_arguments += ['-DOS_CHROMEOS']\n> +endif\n\nThis duplicates a logic that defines the same macro in\nsrc/android/cros/meson.build.\n\n> +\n> c_arguments += common_arguments\n> cpp_arguments += common_arguments\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81EA5C326C\n\tfor ;\n\tTue, 15 Oct 2024 10:22:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 188DB65388;\n\tTue, 15 Oct 2024 12:22:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D1CE6537E\n\tfor ;\n\tTue, 15 Oct 2024 12:22:06 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [185.143.39.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 899839CE;\n\tTue, 15 Oct 2024 12:20:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UdrmHbod\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728987624;\n\tbh=V1VzSYvGI2TU3+p5z0+EyDyob0Qq6VTP24w2EoakuHE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UdrmHbodglIlbCaRGcKZV1jEvS/i1BBkhh+uR4NyqiXcjcb3zAJ45qGC9FQhB+xOS\n\tb3Ro+w65teEfW1L4QRPzUlKUll9NiUgSKce8V9lXIFiqdbZ6loNtpAZN3rGMo9m0Ny\n\tsMCh0LQoABJn/imXSQQbGfRzeO5nIPOPfGC3/4ik=","Date":"Tue, 15 Oct 2024 13:22:02 +0300","From":"Laurent Pinchart ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHan-Lin Chen ","Subject":"Re: [PATCH 1/2] libcamera: add OS_CHROMEOS when the android_platform\n\tis cros","Message-ID":"<20241015102202.GD5682@pendragon.ideasonboard.com>","References":"<20241014081738.772258-1-chenghaoyang@chromium.org>\n\t<20241014081738.772258-2-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241014081738.772258-2-chenghaoyang@chromium.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]