[{"id":2864,"web_url":"https://patchwork.libcamera.org/comment/2864/","msgid":"<20191011142329.GG23166@bigcity.dyn.berto.se>","date":"2019-10-11T14:23:29","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Avoid unnecessary copy","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-10-11 17:04:08 +0300, Laurent Pinchart wrote:\n> Use const references in a for loop to avoid an unnecessary copy.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 4f5fdb146212..02419e254f2d 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -98,7 +98,7 @@ void IPARkISP1::configure(const std::map &streamConfig,\n> \n> void IPARkISP1::mapBuffers(const std::vector &buffers)\n> {\n> -\tfor (IPABuffer buffer : buffers) {\n> +\tfor (const IPABuffer &buffer : buffers) {\n\nd00h,\n\nReviewed-by: Niklas Söderlund \n\n> \t\tbufferInfo_[buffer.id] = buffer.memory;\n> \t\tbufferInfo_[buffer.id].planes()[0].mem();\n> \t}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79C2161565\n\tfor ;\n\tFri, 11 Oct 2019 16:23:31 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id r22so7191161lfm.1\n\tfor ;\n\tFri, 11 Oct 2019 07:23:31 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tq24sm2226389lfa.94.2019.10.11.07.23.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 11 Oct 2019 07:23:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=tB2toagjfr0UHNQUz72oV0VuD1szCqeqioYCYIKzliQ=;\n\tb=W8WR3tVE6pTYMDoW0sKspjVPFPoeBPmwYUHz5nZHfM81MrxGR1xdKI1PToWRGUdIoa\n\t8fVf1A0fQDayQ4zMDHodMzxVnPAxnkZUuk2DmaFSkUhBFh4oVTmO08r2pTGsnYzg6WAV\n\tLBCSyRS0H/8+rpvwBrH/7+2NPrAzaVy/28U2jnglTpLYcuGyUSAc5kbqxXEa0Ew4g9TA\n\tSH7apF2ykXJy9hI1kXuYRuKX3DkzOZYAqZTyxh3mhsf3gFqlrS17UDWAHRyYP7dqiU+6\n\tieUyC/ykVkj33nyFm7w3gYLxxk+q417uU2YOfN6X+RcaU97Ld1pWF/JeXOuPkw51hkbR\n\t4ekQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=tB2toagjfr0UHNQUz72oV0VuD1szCqeqioYCYIKzliQ=;\n\tb=ShGPJugMh4cgVOhlkTBsSDUHf6oV0XV3MFqNbNiguGg2PbxurqlwrkZAH4lAwf6yZn\n\tubDaMsE8uERYTlDfPnydl0o0vJcTJpP7T7htSiL0qDIhJd8Tu14kKZMNv+y7f3K8Y2eL\n\tSTrPJ41Ptu3mvg6WS9mZNBtQiF+2A3/giTkD7hWpaNcThM0aArMjUklVXJ6bLw174oYa\n\tGALnW40IcdRWwack6iDPYcr1vXEStPVkH5CmweR+razInjdqx1b2i4lVemt4JiqBe6+9\n\tI+VT9RNt9WvVTvU5RlQIhaMvGUnyUxehidu8/MoX81FawVLU9LEjTk0X2krhggXhLDSB\n\tMdYQ==","X-Gm-Message-State":"APjAAAVLlSnsVShq0khvXxKYhS/Xjvzo4bu2D9NOaJHptn44JLwX9hbw\n\t6mtE8VwTuGvTxZ0lQJg9nS0crw==","X-Google-Smtp-Source":"APXvYqz4bSHGLqHn8XT8Xe49q8JD8B/zKFWKRUPPcvuwJ2vOsuyijCrrkUSbxzuThjMtX9ay51dmmA==","X-Received":"by 2002:ac2:533c:: with SMTP id f28mr9235516lfh.0.1570803810694; \n\tFri, 11 Oct 2019 07:23:30 -0700 (PDT)","Date":"Fri, 11 Oct 2019 16:23:29 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191011142329.GG23166@bigcity.dyn.berto.se>","References":"<20191011140408.11712-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191011140408.11712-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Avoid unnecessary copy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 11 Oct 2019 14:23:31 -0000"}}]