{"id":2159,"url":"https://patchwork.libcamera.org/api/patches/2159/?format=json","web_url":"https://patchwork.libcamera.org/patch/2159/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191011140408.11712-1-laurent.pinchart@ideasonboard.com>","date":"2019-10-11T14:04:08","name":"[libcamera-devel] ipa: rkisp1: Avoid unnecessary copy","commit_ref":"8647991cd8310463d1f5d08698f277e2278e77d9","pull_url":null,"state":"accepted","archived":false,"hash":"f39934c64e6b3769cb8c189bccccbd7aaf202482","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2159/mbox/","series":[{"id":529,"url":"https://patchwork.libcamera.org/api/series/529/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=529","date":"2019-10-11T14:04:08","name":"[libcamera-devel] ipa: rkisp1: Avoid unnecessary copy","version":1,"mbox":"https://patchwork.libcamera.org/series/529/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2159/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2159/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1022561565\n\tfor ;\n\tFri, 11 Oct 2019 16:04:17 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D4DE33A;\n\tFri, 11 Oct 2019 16:04:16 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570802656;\n\tbh=DQfBFShICo4Ez8AsoYLde6SYNkEUiE9xMyCif3EICXw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=RAnYODdQnraTfoXQzMqsbE1wxhpChua0xQ2o881jh5W1eopk7uTvMDrv97w99z7Vv\n\tT2sw+nsOAPSXbTpeTBpF/CfPf+adTLUSoFMlR36WKvRh0b7UE9i6/sgMVSJcoit8fz\n\tAOzztTNV2E/iEvEZJqL7/ivb5uPMp6DYd7KF7vmw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Oct 2019 17:04:08 +0300","Message-Id":"<20191011140408.11712-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: rkisp1: Avoid unnecessary copy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 11 Oct 2019 14:04:17 -0000"},"content":"Use const references in a for loop to avoid an unnecessary copy.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 4f5fdb146212..02419e254f2d 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -98,7 +98,7 @@ void IPARkISP1::configure(const std::map &streamConfig,\n \n void IPARkISP1::mapBuffers(const std::vector &buffers)\n {\n-\tfor (IPABuffer buffer : buffers) {\n+\tfor (const IPABuffer &buffer : buffers) {\n \t\tbufferInfo_[buffer.id] = buffer.memory;\n \t\tbufferInfo_[buffer.id].planes()[0].mem();\n \t}\n","prefixes":["libcamera-devel"]}