[{"id":31734,"web_url":"https://patchwork.libcamera.org/comment/31734/","msgid":"<172890567412.532453.7313039338398861117@ping.linuxembedded.co.uk>","date":"2024-10-14T11:34:34","subject":"Re: [PATCH 3/3] libcamera: rkisp1: Maintain alphabetical order of\n\tforward declarations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-10-11 10:22:22)\n> Alphabetical order of Forward declarations should be maintained hence,\n> 'class V4L2Subdevice' should come after 'class SensorConfiguration'.\n> Fix it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> index 8461071f..45be8476 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> @@ -26,8 +26,8 @@ namespace libcamera {\n> \n> class CameraSensor;\n> class MediaDevice;\n> -class V4L2Subdevice;\n> class SensorConfiguration;\n> +class V4L2Subdevice;\n> struct StreamConfiguration;\n> struct V4L2SubdeviceFormat;\n> \n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8FB9C326C\n\tfor ;\n\tMon, 14 Oct 2024 11:34:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27C6B6537D;\n\tMon, 14 Oct 2024 13:34:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66DB965371\n\tfor ;\n\tMon, 14 Oct 2024 13:34:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BA308BE;\n\tMon, 14 Oct 2024 13:32:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vat265XK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728905575;\n\tbh=0BlB5x29u4kFUrjfZ5Lrfjx3JS/P0o22ZV87cp7f8Us=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vat265XK2tYTGFxVr52fCtxQDhGWPr4yxJEbMmNJN0xx+VlCReOmOxUUfkWKtWra5\n\tsEb7h0b88oR1Foedf9t5L6/DU5TDnSyQjLMioqVZGv9rBzlwbJKN6h1CpEK/FHzADD\n\t3IbiefBWTM/zIy6EpPkxI0rZxd4M0bYUkd74hLKU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241011092222.537322-4-umang.jain@ideasonboard.com>","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-4-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 3/3] libcamera: rkisp1: Maintain alphabetical order of\n\tforward declarations","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tStefan Klug ,\n\tUmang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 14 Oct 2024 12:34:34 +0100","Message-ID":"<172890567412.532453.7313039338398861117@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31754,"web_url":"https://patchwork.libcamera.org/comment/31754/","msgid":"","date":"2024-10-15T18:21:03","subject":"Re: [PATCH 3/3] libcamera: rkisp1: Maintain alphabetical order of\n\tforward declarations","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Umang,\n\nOn Fri, Oct 11, 2024 at 02:52:22PM +0530, Umang Jain wrote:\n> Alphabetical order of Forward declarations should be maintained hence,\n> 'class V4L2Subdevice' should come after 'class SensorConfiguration'.\n> Fix it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> index 8461071f..45be8476 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> @@ -26,8 +26,8 @@ namespace libcamera {\n> \n> class CameraSensor;\n> class MediaDevice;\n> -class V4L2Subdevice;\n> class SensorConfiguration;\n> +class V4L2Subdevice;\n> struct StreamConfiguration;\n> struct V4L2SubdeviceFormat;\n> \n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDC69C0F2A\n\tfor ;\n\tTue, 15 Oct 2024 18:21:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EF7A65381;\n\tTue, 15 Oct 2024 20:21:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DB4460537\n\tfor ;\n\tTue, 15 Oct 2024 20:21:06 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 746D79CE;\n\tTue, 15 Oct 2024 20:19:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m86Npgtv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729016364;\n\tbh=jTFginGny9CXK0e7qCHcaLBZmLqU98HAhgdRQUX5chg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=m86Npgtv9jKPnHNUgP8gVw3OTK9c0nxw6vjeN1Kv+oTpNMDx5jW9C+orz3VXrQmdj\n\tZ3a9YweFmhuuetVdD9hQXf2CdFo9KOUbSpfBhxEm+3zyEJDlrxMd/gM0FJpiioZsb9\n\t1CbCBjumX4peyU0r8ZnhUiOe/GIdEmv9bHfEwvIU=","Date":"Tue, 15 Oct 2024 20:21:03 +0200","From":"Stefan Klug ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tKieran Bingham , \n\tLaurent Pinchart ","Subject":"Re: [PATCH 3/3] libcamera: rkisp1: Maintain alphabetical order of\n\tforward declarations","Message-ID":"","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-4-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241011092222.537322-4-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]