[{"id":31732,"web_url":"https://patchwork.libcamera.org/comment/31732/","msgid":"<172890565063.532453.10973256116423557455@ping.linuxembedded.co.uk>","date":"2024-10-14T11:34:10","subject":"Re: [PATCH 2/3] libcamera: rkisp1: Rectify SensorConfiguration check","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-10-11 10:22:21)\n> The 'found' flag was mistakenly understood that a compatible sensor\n> format has been found when a sensor configuration is passed in. However,\n> 'found' related to the stream configuration's pixelformat, whether it is\n> supported by the RkISP1Path video node or not. It does not relate to the\n> sensor format, hence the check:\n> \n> if (sensorConfig && !found)\n> \n> doesn't make sense.\n> \n> Rectify the above check with:\n> \n> if (sensorConfig && !rawFormat.isValid())\n> \n> to ensure a sensor format compatible with sensor configuration has been\n> set to rawFormat.\n> \n> Fixes: 047d647452c4 (\"libcamera: rkisp1: Integrate SensorConfiguration support\")\n> Signed-off-by: Umang Jain \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 4a3b779c..236d05af 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -304,7 +304,7 @@ RkISP1Path::validate(const CameraSensor *sensor,\n> }\n> }\n> \n> - if (sensorConfig && !found)\n> + if (sensorConfig && !rawFormat.isValid())\n> return CameraConfiguration::Invalid;\n> \n> bool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding ==\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9722DC326C\n\tfor ;\n\tMon, 14 Oct 2024 11:34:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53FA665374;\n\tMon, 14 Oct 2024 13:34:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50DE863525\n\tfor ;\n\tMon, 14 Oct 2024 13:34:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 824598BE;\n\tMon, 14 Oct 2024 13:32:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vwutEPQw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728905552;\n\tbh=11qtuOQ/CQG8u6qL0hTz/sPZ4eIXXH3hyPZzJre9g9c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vwutEPQw3HSp+2nvup3jkOx2EevzYJP+sIoAiOESeylbINWFRSTX6Bz0ZTBYlsKDz\n\tbyWwo3ar1mMTDYajdr9OrbGKPLNFddCyi+/an5erFIdz+y64cHkgsg51TZcIlGjwUx\n\t/oxtLOLVfaUxbl8gXPMl/LfZvMpiJnhiMxPdwX0c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241011092222.537322-3-umang.jain@ideasonboard.com>","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-3-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 2/3] libcamera: rkisp1: Rectify SensorConfiguration check","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tStefan Klug ,\n\tUmang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 14 Oct 2024 12:34:10 +0100","Message-ID":"<172890565063.532453.10973256116423557455@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31753,"web_url":"https://patchwork.libcamera.org/comment/31753/","msgid":"<4hxo2jnnixjtssotbqgggkzkety44nhchwvrz7cmo3tnnjcu2b@bbk5jym7wv54>","date":"2024-10-15T18:20:24","subject":"Re: [PATCH 2/3] libcamera: rkisp1: Rectify SensorConfiguration check","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Oct 11, 2024 at 02:52:21PM +0530, Umang Jain wrote:\n> The 'found' flag was mistakenly understood that a compatible sensor\n> format has been found when a sensor configuration is passed in. However,\n> 'found' related to the stream configuration's pixelformat, whether it is\n> supported by the RkISP1Path video node or not. It does not relate to the\n> sensor format, hence the check:\n> \n> \tif (sensorConfig && !found)\n> \n> doesn't make sense.\n> \n> Rectify the above check with:\n> \n> \tif (sensorConfig && !rawFormat.isValid())\n> \n> to ensure a sensor format compatible with sensor configuration has been\n> set to rawFormat.\n> \n> Fixes: 047d647452c4 (\"libcamera: rkisp1: Integrate SensorConfiguration support\")\n> Signed-off-by: Umang Jain \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 4a3b779c..236d05af 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -304,7 +304,7 @@ RkISP1Path::validate(const CameraSensor *sensor,\n> \t\t}\n> \t}\n> \n> -\tif (sensorConfig && !found)\n> +\tif (sensorConfig && !rawFormat.isValid())\n> \t\treturn CameraConfiguration::Invalid;\n> \n> \tbool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding ==\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67AFAC0F2A\n\tfor ;\n\tTue, 15 Oct 2024 18:20:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AC336537E;\n\tTue, 15 Oct 2024 20:20:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 124B460537\n\tfor ;\n\tTue, 15 Oct 2024 20:20:27 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6195E9CE;\n\tTue, 15 Oct 2024 20:18:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ShxU57x9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729016325;\n\tbh=iZnOHE02qOGT8MAQ2f6qytio35N8yLEkny3l9NsCBCY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ShxU57x9fXJUptL4UQSAMagpxwietOOBsq6ryO5C9XqHL5Iv8pM4nrJ8YtTEmLIBD\n\t/ILLLBmo39fRqgDSYb0YEBnwkuDlQYtaDcp0oN1zKYAdbJpB04RS2AivHW7xxj81c3\n\tFhvDweFLc4VhAVhNNW85oFmfM+wvw0CGHDllND5w=","Date":"Tue, 15 Oct 2024 20:20:24 +0200","From":"Stefan Klug ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tKieran Bingham , \n\tLaurent Pinchart ","Subject":"Re: [PATCH 2/3] libcamera: rkisp1: Rectify SensorConfiguration check","Message-ID":"<4hxo2jnnixjtssotbqgggkzkety44nhchwvrz7cmo3tnnjcu2b@bbk5jym7wv54>","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241011092222.537322-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]