[{"id":31731,"web_url":"https://patchwork.libcamera.org/comment/31731/","msgid":"<172890555798.532453.1169552706645109601@ping.linuxembedded.co.uk>","date":"2024-10-14T11:32:37","subject":"Re: [PATCH 1/3] libcamera: rkisp1: Use const reference for sensor\n\tconfiguration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-10-11 10:22:20)\n> User-provided sensor configuration is never meant to be altered,\n> hence pass SensorConfiguration by `const` reference in\n> RkISP1Path::validate().\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 1999094e..4a3b779c 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -253,7 +253,7 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor, const Size &size,\n> \n> CameraConfiguration::Status\n> RkISP1Path::validate(const CameraSensor *sensor,\n> - std::optional &sensorConfig,\n> + const std::optional &sensorConfig,\n> StreamConfiguration *cfg)\n> {\n> const std::vector &mbusCodes = sensor->mbusCodes();\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> index ce9a5666..8461071f 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> @@ -45,7 +45,7 @@ public:\n> const Size &resolution,\n> StreamRole role);\n> CameraConfiguration::Status validate(const CameraSensor *sensor,\n> - std::optional &sensorConfig,\n> + const std::optional &sensorConfig,\n> StreamConfiguration *cfg);\n> \n> int configure(const StreamConfiguration &config,\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC088C32F4\n\tfor ;\n\tMon, 14 Oct 2024 11:32:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00CF665374;\n\tMon, 14 Oct 2024 13:32:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF28763525\n\tfor ;\n\tMon, 14 Oct 2024 13:32:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 707278BE;\n\tMon, 14 Oct 2024 13:31:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tCp8rdwv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728905460;\n\tbh=fN1DgM+gzsGwWrUP6NVzEQKuDjLOdwgb4hRxLZF09V4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tCp8rdwvGKvWURpV/oyRXMdO6UeBto4wdjSu/NIkpGc9HKKEiuelalXb7TKRtLDuG\n\t9X+b4829JYaY7EWcM9SjG3/Tjh1xTqLwR5NpZq5g3/JaE1HI/zC5k12Y+sXjh5Dgkz\n\tGGODmXg9RpxhlpCyJ/00npkyMe0qEI+CFfcMnb8c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241011092222.537322-2-umang.jain@ideasonboard.com>","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-2-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 1/3] libcamera: rkisp1: Use const reference for sensor\n\tconfiguration","From":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tStefan Klug ,\n\tUmang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 14 Oct 2024 12:32:37 +0100","Message-ID":"<172890555798.532453.1169552706645109601@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31752,"web_url":"https://patchwork.libcamera.org/comment/31752/","msgid":"","date":"2024-10-15T18:19:17","subject":"Re: [PATCH 1/3] libcamera: rkisp1: Use const reference for sensor\n\tconfiguration","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"On Fri, Oct 11, 2024 at 02:52:20PM +0530, Umang Jain wrote:\n> User-provided sensor configuration is never meant to be altered,\n> hence pass SensorConfiguration by `const` reference in\n> RkISP1Path::validate().\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index 1999094e..4a3b779c 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -253,7 +253,7 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor, const Size &size,\n> \n> CameraConfiguration::Status\n> RkISP1Path::validate(const CameraSensor *sensor,\n> -\t\t std::optional &sensorConfig,\n> +\t\t const std::optional &sensorConfig,\n> \t\t StreamConfiguration *cfg)\n> {\n> \tconst std::vector &mbusCodes = sensor->mbusCodes();\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> index ce9a5666..8461071f 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n> @@ -45,7 +45,7 @@ public:\n> \t\t\t\t\t\t const Size &resolution,\n> \t\t\t\t\t\t StreamRole role);\n> \tCameraConfiguration::Status validate(const CameraSensor *sensor,\n> -\t\t\t\t\t std::optional &sensorConfig,\n> +\t\t\t\t\t const std::optional &sensorConfig,\n> \t\t\t\t\t StreamConfiguration *cfg);\n> \n> \tint configure(const StreamConfiguration &config,\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CD3DC326C\n\tfor ;\n\tTue, 15 Oct 2024 18:19:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3F3E6537E;\n\tTue, 15 Oct 2024 20:19:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1038860537\n\tfor ;\n\tTue, 15 Oct 2024 20:19:21 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D75D09CE;\n\tTue, 15 Oct 2024 20:17:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dBPsciEo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729016258;\n\tbh=VFXUeoDnWQzUeo1aL2eNDdT+dZv8tBHETfNoNHEhNLA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dBPsciEoJaBFBGkJRQOhUN84ziKe1dQ7pfz4DetcwFbPCoohIG4orT13fM1Wdj3ge\n\t/C17eUUyd751DNbgeALZf6GEOTGupspANMBnTmPYoF4JGj93Khyl9ns88kKs/nqXX6\n\tS1emRNF7SfMDU/Jv/EFxMbUzLqK2CeHQd3nSk6eM=","Date":"Tue, 15 Oct 2024 20:19:17 +0200","From":"Stefan Klug ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tKieran Bingham , \n\tLaurent Pinchart ","Subject":"Re: [PATCH 1/3] libcamera: rkisp1: Use const reference for sensor\n\tconfiguration","Message-ID":"","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>\n\t<20241011092222.537322-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241011092222.537322-2-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]