[{"id":31709,"web_url":"https://patchwork.libcamera.org/comment/31709/","msgid":"<20241010204402.GL32107@pendragon.ideasonboard.com>","date":"2024-10-10T20:44:02","subject":"Re: [PATCH 2/3] apps: cam: Print control vendor information when\n\tlisting controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Oct 10, 2024 at 05:47:18PM +0900, Paul Elder wrote:\n> Now that the vendor of the control can be queried, print it in\n> --list-controls.\n> \n> Example output:\n> $ cam -c 1 --list-controls\n> Using camera platform/vimc.0 Sensor B as cam0\n> Control: libcamera::Brightness: [-1.000000..1.000000]\n> Control: libcamera::Contrast: [0.000000..2.000000]\n> Control: libcamera::Saturation: [0.000000..2.000000]\n\nI wonder if we should rename libcamera to core at some point.\n\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/cam/camera_session.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index edc49b875450..6e9890ccfda1 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -160,10 +160,13 @@ void CameraSession::listControls() const\n> {\n> \tfor (const auto &[id, info] : camera_->controls()) {\n> \t\tif (info.values().empty()) {\n> -\t\t\tstd::cout << \"Control: \" << id->name() << \": \"\n> +\t\t\tstd::cout << \"Control: \"\n> +\t\t\t\t << id->vendor() << \"::\" << id->name() << \": \"\n> \t\t\t\t << info.toString() << std::endl;\n> \t\t} else {\n> -\t\t\tstd::cout << \"Control: \" << id->name() << \":\" << std::endl;\n> +\t\t\tstd::cout << \"Control: \"\n> +\t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n> +\t\t\t\t << std::endl;\n> \t\t\tfor (const auto &value : info.values()) {\n> \t\t\t\tint32_t val = value.get();\n> \t\t\t\tconst auto &it = id->enumerators().find(val);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57377C3260\n\tfor ;\n\tThu, 10 Oct 2024 20:44:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8A3A6536C;\n\tThu, 10 Oct 2024 22:44:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 718326353A\n\tfor ;\n\tThu, 10 Oct 2024 22:44:06 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.230.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2C914D4;\n\tThu, 10 Oct 2024 22:42:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SMsLOcs9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728592948;\n\tbh=K8khTo8uAvdnHFz+i0sqJi8Rn4veycYj0LIC7lDHb10=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SMsLOcs9tIdosRo3lzA3pOcGo1wmZyRKN4FzE0p27f0SVbZ3hhmZSlFcDZPBa0EyX\n\tgeqU39ld/GgfUvp9yuXss6Mb1u4bKWcczN8orXaMp4ytoQMYA599Jxm7E5X/QjGqKv\n\tfDnK+h0oUHgZ9xZH8+Rn6JQAKgYOeh1Xb59RFU6w=","Date":"Thu, 10 Oct 2024 23:44:02 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/3] apps: cam: Print control vendor information when\n\tlisting controls","Message-ID":"<20241010204402.GL32107@pendragon.ideasonboard.com>","References":"<20241010084719.712485-1-paul.elder@ideasonboard.com>\n\t<20241010084719.712485-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241010084719.712485-3-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]