[{"id":31694,"web_url":"https://patchwork.libcamera.org/comment/31694/","msgid":"<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","date":"2024-10-10T08:51:19","subject":"Re: [PATCH] Fix copyright year","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting libcamerabmw+ml@lsmod.de (2024-10-10 08:54:13)\n> From: \"Bernhard M. Wiedemann\" \n> \n> without this patch, openSUSE's debugsource package would vary over time,\n> breaking reproducible builds.\n> Also a copyright of 2025 is factually wrong,\n> because nobody did anything copyright-worthy in that year.\n\nAgreed, I'm still working on my time machine, but it's not ready yet.\n\nBut I think that must be an issue on your side, or am I mistaken. Is\nthere a reference to 2025 within the libcamera code base?\n\n> If updating the year manually is too hard (it is optional anyway),\n> using the mtime of input file(s) could work as well.\n> \n> The diff was:\n> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> - * Copyright (C) 2024, Google Inc.\n> + * Copyright (C) 2025, Google Inc.\n\nThis file is autogenerated right? So this 2025 isn't an issue in our\ncommited code - but a build server with the wrong date at Suse?\n\n> \n> Signed-off-by: Bernhard M. Wiedemann \n> ---\n> utils/codegen/gen-tp-header.py | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\n> index 83606c32..0a3fa644 100755\n> --- a/utils/codegen/gen-tp-header.py\n> +++ b/utils/codegen/gen-tp-header.py\n> @@ -6,7 +6,6 @@\n> #\n> # Generate header file to contain lttng tracepoints\n> \n> -import datetime\n> import jinja2\n> import pathlib\n> import os\n> @@ -20,7 +19,7 @@ def main(argv):\n> output = argv[2]\n> template = argv[3]\n> \n> - year = datetime.datetime.now().year\n> + year = 2024\n\nI would rather not hardcode this, as that then becomes the same as we\nmay as well just remove it if it's worthless (except, I don't know what\nthe legal issues are for removing a copyright statement so ... I'm not\ngoing there).\n\nIf we set it from an mtime which is a good idea, it would probably be\nbest to do so from the top level meson.build, as that's one file that\ncan be guaranteed to be the same 'year' as the release. (because I\nmodify that file to make the release).\n\nOtherwise, you'd have to parse all of the input files and take the\nlatest mtime. That could be a good option too. In fact that might be\neasier as you have a list of those files, while you don't have a\nreference to the meson.build...\n\n\n\n\n> path = pathlib.Path(output).absolute().relative_to(argv[1])\n> \n> source = ''\n> -- \n> 2.46.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 260E1C32EA\n\tfor ;\n\tThu, 10 Oct 2024 08:51:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33B2263536;\n\tThu, 10 Oct 2024 10:51:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1953F63536\n\tfor ;\n\tThu, 10 Oct 2024 10:51:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 034D94D4;\n\tThu, 10 Oct 2024 10:49:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HJbZ9hWk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728550184;\n\tbh=Ec7bu1+Iqi3qOV0p/lmSDH4EOEFB3PPqdZh671Q3qWU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=HJbZ9hWkdSw55hpN0wCUaR4x8fmIz2VWoSvCepxksDPKX/IBtBvytSmQy3gjREDq7\n\tF6bqOd88H6mWtIRiFgy1XzoI3Q0o6Szz9By0N6pymvxbFcXy7sJamAgxvD9DTScdoX\n\tYZWhIAxa89APaZIT4to/+aerN3HFwUSEybqMnkEk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241010075413.91344-1-libcamerabmw+ml@lsmod.de>","References":"<20241010075413.91344-1-libcamerabmw+ml@lsmod.de>","Subject":"Re: [PATCH] Fix copyright year","From":"Kieran Bingham ","Cc":"Bernhard M. Wiedemann ","To":"libcamera-devel@lists.libcamera.org, libcamerabmw+ml@lsmod.de","Date":"Thu, 10 Oct 2024 09:51:19 +0100","Message-ID":"<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31696,"web_url":"https://patchwork.libcamera.org/comment/31696/","msgid":"<7efad940-4234-40e1-93a1-05c368443756@lsmod.de>","date":"2024-10-10T09:28:29","subject":"Re: [PATCH] Fix copyright year","submitter":{"id":209,"url":"https://patchwork.libcamera.org/api/people/209/","name":"Bernhard M. Wiedemann","email":"libcamerabmw+ml@lsmod.de"},"content":"On 10/10/2024 10.51, Kieran Bingham wrote:\n> Quoting libcamerabmw+ml@lsmod.de (2024-10-10 08:54:13)\n>> From: \"Bernhard M. Wiedemann\" \n>> The diff was:\n>> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n>> @@ -1,6 +1,6 @@\n>> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> /*\n>> - * Copyright (C) 2024, Google Inc.\n>> + * Copyright (C) 2025, Google Inc.\n> \n> This file is autogenerated right? So this 2025 isn't an issue in our\n> commited code - but a build server with the wrong date at Suse?\n\nIt is my test script for reproducible-builds using qemu's -rtc base= \noption to simulate a clock that all computers will soon have anyway.\n\n> If we set it from an mtime which is a good idea, it would probably be\n> best to do so from the top level meson.build, as that's one file that\n> can be guaranteed to be the same 'year' as the release. (because I\n> modify that file to make the release).\n> \n> Otherwise, you'd have to parse all of the input files and take the\n> latest mtime. That could be a good option too. In fact that might be\n> easier as you have a list of those files, while you don't have a\n> reference to the meson.build...\n\nChecking mtimes has the disadvantage that applying any downstream patch \nin our distribution would update it and thereby re-introduce this variation.\nA constant year is really the simplest and most reliable solution.\n\nCiao\nBernhard M.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E14B1C32EA\n\tfor ;\n\tThu, 10 Oct 2024 09:28:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 019E565369;\n\tThu, 10 Oct 2024 11:28:35 +0200 (CEST)","from mail.bmwiedemann.de (mail.bmwiedemann.de [188.40.142.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D15F63536\n\tfor ;\n\tThu, 10 Oct 2024 11:28:32 +0200 (CEST)","from mail.bmwiedemann.de (localhost [127.0.0.1])\n\tby mail.bmwiedemann.de (Postfix) with ESMTP id 9E0B83400;\n\tThu, 10 Oct 2024 09:28:29 +0000 (UTC)","from [10.8.5.20] (unknown [10.8.5.20])\n\t(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mail.bmwiedemann.de (Postfix) with ESMTPS;\n\tThu, 10 Oct 2024 09:28:29 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=lsmod.de header.i=@lsmod.de header.b=\"gcRAx7qm\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=lsmod.de; s=202205;\n\tt=1728552512; bh=wpFocnhj5HN5a2x2fupKv3m8TZ6l1gvsfylQ1etoQ0k=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=gcRAx7qmMath+C4diussQVzphFQqZ5Ae/NQzD+45riMpNE0Oy9/MtxvcATPg4r+zV\n\tVTRzHWsMivkiOCZXlnNCieQUbE/BGmfJYgLCjdJmO9YsQTf299xVjdD+prxcyB2wvM\n\tbrmdIel9XMHUS3OpBpk3let4g2qXsqA84T7PRxoUlDlc9miVddbGAEvjn0c/+rZslM\n\tWhMmzyqlUBpJV3sDWHFiKrdzjpl58BdavSlEvNvCoG4LnRTqC09NEtQCDT3q9UFFHv\n\tVBYUZoUudfRaXL0zgA66nycw0RNFPa6Q/eZSL/cpK8gNqr0WuZ1APJ/EX/pCV5/Hd8\n\tr499v/jqvjJNw==","X-Spam-Checker-Version":"SpamAssassin 3.4.5 (2021-03-20) on vm4c.zq1.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00\n\tautolearn=ham autolearn_force=no version=3.4.5","Message-ID":"<7efad940-4234-40e1-93a1-05c368443756@lsmod.de>","Date":"Thu, 10 Oct 2024 11:28:29 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] Fix copyright year","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20241010075413.91344-1-libcamerabmw+ml@lsmod.de>\n\t<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"\"Bernhard M. Wiedemann\" ","In-Reply-To":"<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31735,"web_url":"https://patchwork.libcamera.org/comment/31735/","msgid":"<4f064f54-b5b7-40e1-aba7-26b82ffeb3e0@cherry.de>","date":"2024-10-14T12:33:13","subject":"Re: [PATCH] Fix copyright year","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Kieran,\n\nOn 10/10/24 10:51 AM, Kieran Bingham wrote:\n> Quoting libcamerabmw+ml@lsmod.de (2024-10-10 08:54:13)\n>> From: \"Bernhard M. Wiedemann\" \n>>\n>> without this patch, openSUSE's debugsource package would vary over time,\n>> breaking reproducible builds.\n>> Also a copyright of 2025 is factually wrong,\n>> because nobody did anything copyright-worthy in that year.\n> \n> Agreed, I'm still working on my time machine, but it's not ready yet.\n> \n> But I think that must be an issue on your side, or am I mistaken. Is\n> there a reference to 2025 within the libcamera code base?\n> \n>> If updating the year manually is too hard (it is optional anyway),\n>> using the mtime of input file(s) could work as well.\n>>\n>> The diff was:\n>> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n>> @@ -1,6 +1,6 @@\n>> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> /*\n>> - * Copyright (C) 2024, Google Inc.\n>> + * Copyright (C) 2025, Google Inc.\n> \n> This file is autogenerated right? So this 2025 isn't an issue in our\n> commited code - but a build server with the wrong date at Suse?\n> \n>>\n>> Signed-off-by: Bernhard M. Wiedemann \n>> ---\n>> utils/codegen/gen-tp-header.py | 3 +--\n>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>\n>> diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\n>> index 83606c32..0a3fa644 100755\n>> --- a/utils/codegen/gen-tp-header.py\n>> +++ b/utils/codegen/gen-tp-header.py\n>> @@ -6,7 +6,6 @@\n>> #\n>> # Generate header file to contain lttng tracepoints\n>> \n>> -import datetime\n>> import jinja2\n>> import pathlib\n>> import os\n>> @@ -20,7 +19,7 @@ def main(argv):\n>> output = argv[2]\n>> template = argv[3]\n>> \n>> - year = datetime.datetime.now().year\n>> + year = 2024\n> \n> I would rather not hardcode this, as that then becomes the same as we\n> may as well just remove it if it's worthless (except, I don't know what\n> the legal issues are for removing a copyright statement so ... I'm not\n> going there).\n> \n> If we set it from an mtime which is a good idea, it would probably be\n> best to do so from the top level meson.build, as that's one file that\n> can be guaranteed to be the same 'year' as the release. (because I\n> modify that file to make the release).\n> \n> Otherwise, you'd have to parse all of the input files and take the\n> latest mtime. That could be a good option too. In fact that might be\n> easier as you have a list of those files, while you don't have a\n> reference to the meson.build...\n> \n\nI think it's best practice to default to the content of \nSOURCE_DATE_EPOCH environment variable if it exists, otherwise use of \nnow() would be fine I guess. I believe U-Boot, Buildroot and Yocto do \nmake use of that setting?\n\nc.f. https://reproducible-builds.org/docs/source-date-epoch/\n\nCheers,\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCA35C32F4\n\tfor ;\n\tMon, 14 Oct 2024 12:33:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBD2C65374;\n\tMon, 14 Oct 2024 14:33:17 +0200 (CEST)","from EUR05-DB8-obe.outbound.protection.outlook.com\n\t(mail-db8eur05on20607.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2614::607])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CD9F63525\n\tfor ;\n\tMon, 14 Oct 2024 14:33:16 +0200 (CEST)","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)\n\tby AS1PR04MB9432.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.22;\n\tMon, 14 Oct 2024 12:33:14 +0000","from AS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a]) by\n\tAS8PR04MB8897.eurprd04.prod.outlook.com\n\t([fe80::35f6:bc7d:633:369a%7]) with mapi id 15.20.8048.020;\n\tMon, 14 Oct 2024 12:33:14 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"CJ29WJQT\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=nAG0JiE3pWcQo6hH/THzm4yyiyjszO7mfIddNst0GvrMoRO3n3r+4Htit73WqPRC2khxCRPckJfC4v7enwVZpF/r10aqIBrWjn/dDlAgdMCZYXzqYv1CR3Aw8nAlzrYT+2Ctk/QHWi6Ou5gWhLntuGsPDaJohHrLadGNBhuFx41CfjT4fn4OQJqcjn0bnhk5j8ZwmhTaUcM3jyXTV2JiP2F0JRzYjQY2phHXGGiELfAILNuB5XUa5umITF9cn1T22PdCdyp1OY5aSISxxO/c/vzhladrxHSb4psfoqVdv4DHaYuv3dimqblctr9v1U+tgjZp9jLHOD2OQ/keZfmHxw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=wXUKrgPvQwbuocRf41/DV3WblUc7P7LP/TGmhiW2XbE=;\n\tb=y8NGzn/XBbBh+TfMXrtmNb5BCQy3OMVx65GPfhq4tGpq14ZEx/vMS1xHzpvX7sg5WDVwJdGGyPoo/f/ZYSVDFD2Z9FlsQnB+MJp72krzeSERZi7shFde2+f5/6ayCCDxZ9i22NJwRrruxccXQPbZMzAmXh1/ClZZx7ljdJMfvxwaLofGuLmqxTvRWUhdD9lnRdWnmMRNBQ5cTW4iwRj7PnYPbPY3jXhS6F2z7ikT1OEEOEUa5c7H/gAsvyVlVOGaINOB4+zai4WzbeFkjijxgIxJBRBwfsyHv00G4nG5QNpVi8fE/zlQMYu1onVejO2YlAG/I2z0BKpJDxsed+q4lg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=wXUKrgPvQwbuocRf41/DV3WblUc7P7LP/TGmhiW2XbE=;\n\tb=CJ29WJQTXg27qGnXRaA8cDsO4uKxz+HZA5FctDQZcBgQvSYsfmaJv23o6dPQ7ul8v05ou3ZkG7g646EdtsgN+yW6aW3tN3IBbGsUGL7R/u/qqbjiy1QeuUMpVVzmmTxX3Dd0T3tzAkE0F7zwQeNhK0pqh6Fy0Ls3HDcwgOZaGgY=","Message-ID":"<4f064f54-b5b7-40e1-aba7-26b82ffeb3e0@cherry.de>","Date":"Mon, 14 Oct 2024 14:33:13 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] Fix copyright year","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org, libcamerabmw+ml@lsmod.de","Cc":"\"Bernhard M. Wiedemann\" ","References":"<20241010075413.91344-1-libcamerabmw+ml@lsmod.de>\n\t<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Quentin Schulz ","In-Reply-To":"<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"WA1P291CA0024.POLP291.PROD.OUTLOOK.COM\n\t(2603:10a6:1d0:19::18) To AS8PR04MB8897.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:42c::20)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB8897:EE_|AS1PR04MB9432:EE_","X-MS-Office365-Filtering-Correlation-Id":"68ff7ee6-79e7-42f0-d684-08dcec4c5f7e","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|376014|366016;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?zPbF8AWT2nX2rU5mmylsoO6H/fAS?=\n\t=?utf-8?q?xpEa5PG3qbpstXEJFY63zZ+pUjFOOOhnYdJMp278Jkdn/d2/r6O7YbMU?=\n\t=?utf-8?q?Lm5A8ftsJqlxqvN7GPfd1bDUF/sU41cOKGjCeLG6xh7AlXvucDLJjSb4?=\n\t=?utf-8?q?BWNv+i+dXNhY0GFd1uXgXTIolAXNiWS87cAUqAhKDsP0tndcixg0vde6?=\n\t=?utf-8?q?/K6kCa1uxxFmzR43RdCcSHyp5WiaTiNXT5FUe9EFzrbNcW3EKGD+g4zx?=\n\t=?utf-8?q?1iE70bz+cgrwi+haqtmy3wjSYs6+CNT5kNlG2HLG85vNwZgxjIfG6WP/?=\n\t=?utf-8?q?Y2rQQI21GDxZNNHzJlemkbIvTuxXvxHht0uJK9Ylz7Lzk6meTBxxupIR?=\n\t=?utf-8?q?zPsX2adQqtIji3R1M9PvpLWRqUDMQnX7GxxlD9DSiPIYTlpOWjZjseVG?=\n\t=?utf-8?q?n7Lq8wQOS0bDI7KqK5xHblwvdOJPPGMxMSVseSt5MRRdGSNVYrK3wZhe?=\n\t=?utf-8?q?CU9GkY9ZBk62uDaiZ92XUMcSMPViriPnY+YRTh8YKtffYejP+Z+Ed3ku?=\n\t=?utf-8?q?ugLbrXsu+Y9kt+nSu8vKTFg/7Oeby+1X4KeBQME00f7BGHCbg+nG4hfo?=\n\t=?utf-8?q?9cc1zOOXThayfV6vfNT5WUCCULm8UqRsmx48zyuX6ZVOw5Qa6BOCqQV9?=\n\t=?utf-8?q?gZFmfhHvhuOb3lM252kjAIOB5LJSUJ34tZaEEZNGMwNHitffHFBkPpKn?=\n\t=?utf-8?q?GSgP2BrJ7uIm8WDJ+BY5WKr+/Hfrs+5/geLW+hmvxePol2/RrvlTMR84?=\n\t=?utf-8?q?RXfE5Pa9zoOUeYVTLRvmL7kXLH3nqAm+gu300LRzNuFXrpQ/KpMsfZUJ?=\n\t=?utf-8?q?YVfszRDv9vueDBdaflHyJzXgOG7TlE9K/qQkpBpSy9A7MR44eEyoR8/H?=\n\t=?utf-8?q?uxXodGa+71z7btgc1zR0yQ5pOxN+M4/tm0PbghZE7kRbqMXEEHA30o0u?=\n\t=?utf-8?q?UUkTYboTyiqfc19/orC7JOz/6shZdm1YlsXZ1PVhF9/FIbV01VxBLIKl?=\n\t=?utf-8?q?C9SEJTi+kjav6QJY9H4795+ctofwwoibGtj8Mx9423HWbEBOodwkFUIs?=\n\t=?utf-8?q?zEHD0v/n3eZ0HUx2fMEUtihar3SLPFpbzoOp0K7eUIoLdlNSmhOmmpgK?=\n\t=?utf-8?q?D8cINhZCFtRXQU6b5BVwtQAhYw7mZ+jwdIc2oZqtD0QMovknL4nReCfr?=\n\t=?utf-8?q?4bDXTZF1mBN9O2f6oZApnaFQyQAaZfmtgyXY8dL9FwGvBiVLdoDhQ7Q8?=\n\t=?utf-8?q?UGrGD/ZKl0bp9YXg0YvpjYT0f+hE/5Gqdb/RXaVEal/oMd66R36COFc?=\n\t=?utf-8?q?=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AS8PR04MB8897.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?k/vKKiSqnvmNvS8E9uPqvVv8h?=\n\t=?utf-8?q?zr+olKwSsnfX7r1YouIAL2AcP9YfMQLYAhWyAZSFLQP8Ra8cjyUq6D5m?=\n\t=?utf-8?q?EN5K4w56IQGA87XCNtFQFF+qA8BBgkQEe4pdo1maWSGXvDDNJzDQcqBg?=\n\t=?utf-8?q?GKGRjVBrFegp31f145hmjGrpskvPn29YE0KfdKwVcvGMYdPSObBm7A7h?=\n\t=?utf-8?q?X1qK6vS52AY2bsHClvfpJupqgwuiGqPuZxTOdboExdD5nY1xNkZbHkC1?=\n\t=?utf-8?q?Jp0Nv4D4yCvlKiSfxaoKThk0C+TC9CjxujZd0wKjc+ytR3Uj+WPR4cDV?=\n\t=?utf-8?q?XPOYkijNVGE93zglZGreHGrS8rHyrnyz7uAJJGWIkPEElhGKFm8GRZTr?=\n\t=?utf-8?q?TZJXyARlWjVa51KMrnuDe+JSLSUe0EvVRdywany654k3ZxixiBd9ID+5?=\n\t=?utf-8?q?/b27RsfPBPFGk5VieX067eJv6TYWEgV5UR1ccEwuHWszOlWxQYuDK7Hb?=\n\t=?utf-8?q?iAzIi7+MNYMd3cjYgqkxmORiwbm2+kdpSELOZ4frX43VyDJ8tgVfmPjO?=\n\t=?utf-8?q?L4vEaq8bBGkJUNcCfWcQ6rFTjCQT6kYaTzHrjLmzxp/uO6Ur47aDShem?=\n\t=?utf-8?q?q+kDexy3V2lb4lJLKR89FRHFhxGQH9zMKwpcyW3+kM7UWX0zdMBaMFSL?=\n\t=?utf-8?q?DIyWFjSw1PPJBrUQMY2+LSLpzd85xE9vYJUnJooe+Y5z0YJxK6cmgode?=\n\t=?utf-8?q?jdkwxEDBO5dIGj1pfz4ZOmvCWR8i7GYs3HfuxZfCTV5d6ADDwiGfg3vV?=\n\t=?utf-8?q?aCAquvktYsmOWSJBFNJZzPPAaNQ2UeLaBy9Xe0z8+O0uy9gczJpViQQl?=\n\t=?utf-8?q?g6SCpla18tOLOKPEjCNZgc+0T1uGgrd8qFBH0DUQZW/mZQ4A9XSU1LDO?=\n\t=?utf-8?q?G1maJH4whpK2uXGRbhaBD1I3WmVQmEm/uUPmKEAuylroebnlRNI7ODdH?=\n\t=?utf-8?q?QRrSpt6JYpjSoiMHe2TA872ltiHivSKkQZCwkNeZUL2skMk1PK9xIe+b?=\n\t=?utf-8?q?Kp5TA8P+CRyJ3hSxSZtGgol7Fh6wztkyYi9HJNqPvZJygjbVIwu8e3xn?=\n\t=?utf-8?q?Sqti8DpGb2fH4j+Caz4hizWKZdI+SWmhCDwR61H/5VrWk88+BKcjsNSg?=\n\t=?utf-8?q?TjzBdowhWkGzIs1R7iOxVvKZ2mP/MCnTVO0AeVB7goJMdP7pDbKOB4JH?=\n\t=?utf-8?q?GVnAuUwr76+B7j3HzG/aUs4hTGIwJhkm3SImJro7PySAff0nNRkxrWpn?=\n\t=?utf-8?q?AzdCRWbPVHVqiqF44RRl0a5isT4Bo3Cva1ad+K/2kmW4Mp80W9496NBx?=\n\t=?utf-8?q?3No8oiKXNNavSzvlDIghQx8aoHQqEsFUOfgnEFWS69ed3tWxpmGP8gkd?=\n\t=?utf-8?q?DqQMl2g+FQTsj2olSnvqexjwA2dfCVFhjc3gs/ISp4cxsKZuSTa0hH8E?=\n\t=?utf-8?q?PWqPLLBEg1voC8kTAG6dgJP7BURKwCm4pgASOMvWTE2aDIEgQ4m1GZVl?=\n\t=?utf-8?q?eThkzGJUhMcS3TSl4lg3HAyhspHNsBVLkvxsWHcJ7kOEbVVtIFcgjJ5y?=\n\t=?utf-8?q?doV9D2HnRnV3CUVutrttL4X6HHGD6Qt34vZjTh/GRPpqbZb72j0zbLZ/?=\n\t=?utf-8?q?+MNAxQ3fPOGoRArd19pjvWqIHUzRRaN4Y6AOOm0Y5wnpcb8bDXad8XUZ?=\n\t=?utf-8?q?J24u8wW?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"68ff7ee6-79e7-42f0-d684-08dcec4c5f7e","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB8897.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Oct 2024 12:33:14.5127\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"pojNWY/nHPTyQYBT+57vnbVJP2cjnj36xjD/p/vw+rg0fpKyzn3/xQz/XjHEid8ZrYrtFGuKSPE5c9tTnxuwk+iGq+wSeQvPl6O9vz/+epI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS1PR04MB9432","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31736,"web_url":"https://patchwork.libcamera.org/comment/31736/","msgid":"<20241014181640.GA5522@pendragon.ideasonboard.com>","date":"2024-10-14T18:16:40","subject":"Re: [PATCH] Fix copyright year","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 14, 2024 at 02:33:13PM +0200, Quentin Schulz wrote:\n> Hi Kieran,\n> \n> On 10/10/24 10:51 AM, Kieran Bingham wrote:\n> > Quoting libcamerabmw+ml@lsmod.de (2024-10-10 08:54:13)\n> >> From: \"Bernhard M. Wiedemann\" \n> >>\n> >> without this patch, openSUSE's debugsource package would vary over time,\n> >> breaking reproducible builds.\n> >> Also a copyright of 2025 is factually wrong,\n> >> because nobody did anything copyright-worthy in that year.\n> > \n> > Agreed, I'm still working on my time machine, but it's not ready yet.\n> > \n> > But I think that must be an issue on your side, or am I mistaken. Is\n> > there a reference to 2025 within the libcamera code base?\n> > \n> >> If updating the year manually is too hard (it is optional anyway),\n> >> using the mtime of input file(s) could work as well.\n> >>\n> >> The diff was:\n> >> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n> >> @@ -1,6 +1,6 @@\n> >> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> >> /*\n> >> - * Copyright (C) 2024, Google Inc.\n> >> + * Copyright (C) 2025, Google Inc.\n> > \n> > This file is autogenerated right? So this 2025 isn't an issue in our\n> > commited code - but a build server with the wrong date at Suse?\n> > \n> >>\n> >> Signed-off-by: Bernhard M. Wiedemann \n> >> ---\n> >> utils/codegen/gen-tp-header.py | 3 +--\n> >> 1 file changed, 1 insertion(+), 2 deletions(-)\n> >>\n> >> diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\n> >> index 83606c32..0a3fa644 100755\n> >> --- a/utils/codegen/gen-tp-header.py\n> >> +++ b/utils/codegen/gen-tp-header.py\n> >> @@ -6,7 +6,6 @@\n> >> #\n> >> # Generate header file to contain lttng tracepoints\n> >> \n> >> -import datetime\n> >> import jinja2\n> >> import pathlib\n> >> import os\n> >> @@ -20,7 +19,7 @@ def main(argv):\n> >> output = argv[2]\n> >> template = argv[3]\n> >> \n> >> - year = datetime.datetime.now().year\n> >> + year = 2024\n> > \n> > I would rather not hardcode this, as that then becomes the same as we\n> > may as well just remove it if it's worthless (except, I don't know what\n> > the legal issues are for removing a copyright statement so ... I'm not\n> > going there).\n> > \n> > If we set it from an mtime which is a good idea, it would probably be\n> > best to do so from the top level meson.build, as that's one file that\n> > can be guaranteed to be the same 'year' as the release. (because I\n> > modify that file to make the release).\n> > \n> > Otherwise, you'd have to parse all of the input files and take the\n> > latest mtime. That could be a good option too. In fact that might be\n> > easier as you have a list of those files, while you don't have a\n> > reference to the meson.build...\n> \n> I think it's best practice to default to the content of \n> SOURCE_DATE_EPOCH environment variable if it exists, otherwise use of \n> now() would be fine I guess. I believe U-Boot, Buildroot and Yocto do \n> make use of that setting?\n> \n> c.f. https://reproducible-builds.org/docs/source-date-epoch/\n\nAnother (and simpler) option would be to set the copyright year in\ntracepoints.h.in. That file contains the only copyrightable contents,\nthe rest is generated from .tp files that I don't believe meet the bar\nfor copyright protection.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FEC0C326C\n\tfor ;\n\tMon, 14 Oct 2024 18:16:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58B596537E;\n\tMon, 14 Oct 2024 20:16:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EB9463525\n\tfor ;\n\tMon, 14 Oct 2024 20:16:49 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [23.233.251.139])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF5E696C;\n\tMon, 14 Oct 2024 20:15:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mFaLkn9A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728929707;\n\tbh=wDRIKnUM5L0y+UP1Hw/+a9loaJc4/iT+TBKvbsEzPDk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mFaLkn9AuwhT3W/HzlkmOQ2NRHyy3wzwW9eKj4hthhJieoVdeiqY+LaEW1eaMrckd\n\tuGIvKcoUYnFsAasswy4rmO2HYAbWrbAtTf49TJCSjvuYKZyoPUw2coGOGetIt5IZsY\n\tZv78WJnGhX5S7MCaRs36sdhJ7GFeVNGZsUyqEXAQ=","Date":"Mon, 14 Oct 2024 21:16:40 +0300","From":"Laurent Pinchart ","To":"Quentin Schulz ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org, libcamerabmw+ml@lsmod.de,\n\t\"Bernhard M. Wiedemann\" ","Subject":"Re: [PATCH] Fix copyright year","Message-ID":"<20241014181640.GA5522@pendragon.ideasonboard.com>","References":"<20241010075413.91344-1-libcamerabmw+ml@lsmod.de>\n\t<172855027933.3353069.16439552723196302813@ping.linuxembedded.co.uk>\n\t<4f064f54-b5b7-40e1-aba7-26b82ffeb3e0@cherry.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<4f064f54-b5b7-40e1-aba7-26b82ffeb3e0@cherry.de>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]