[{"id":31680,"web_url":"https://patchwork.libcamera.org/comment/31680/","msgid":"<172851535750.532453.12226395429339106285@ping.linuxembedded.co.uk>","date":"2024-10-09T23:09:17","subject":"Re: [RFC 2/4] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2024-10-09 21:01:08)\n> patternSize_ is a private variable and its meaning is already documented\n> in the patternSize() getter documentation.\n> \n> Move the list of valid sizes to the patternSize() getter documentation\n> and drop the patternSize_ documentation.\n> \n> While at it also add 1x1 as valid size for use with future support\n> of single plane non Bayer input data.\n> \n> Signed-off-by: Hans de Goede \n\nThis seems reasonable already.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n> 1 file changed, 2 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index a9a3e77a..5e4246a9 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -58,6 +58,8 @@ namespace libcamera {\n> * also indicates if processLine2() should be called or not.\n> * This may only be called after a successful configure() call.\n> *\n> + * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n> + *\n> * \\return The pattern size\n> */\n> \n> @@ -112,13 +114,6 @@ namespace libcamera {\n> * \\brief Statistics window, set by setWindow(), used every line\n> */\n> \n> -/**\n> - * \\var Size SwStatsCpu::patternSize_\n> - * \\brief The size of the bayer pattern\n> - *\n> - * Valid sizes are: 2x2, 4x2 or 4x4.\n> - */\n> -\n> /**\n> * \\var unsigned int SwStatsCpu::xShift_\n> * \\brief The offset of x, applied to window_.x for bayer variants\n> -- \n> 2.46.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E3B1C32E0\n\tfor ;\n\tWed, 9 Oct 2024 23:09:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FC3163538;\n\tThu, 10 Oct 2024 01:09:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 042AB618C5\n\tfor ;\n\tThu, 10 Oct 2024 01:09:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F2C49CA;\n\tThu, 10 Oct 2024 01:07:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U3C/VTBU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728515263;\n\tbh=/lfu99dY4CUJV+NiME5oJvynDynKADBCSnDaXPEqS+8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=U3C/VTBU8HwRPixx4l5vbzZQniU/li4oOdtFMNMhP2n3tMz03XzecQhoOHvby8ZpR\n\tYXmf+Y4KCS3u1DKUttcDZ239XU5S+owj3XSpE2JYM22PSzFb5pld80xm6fSoiqGTZ0\n\tQohDc29HCQLdLeJACnSPympLqUu4IR5AgPxP3YPk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241009200110.275544-3-hdegoede@redhat.com>","References":"<20241009200110.275544-1-hdegoede@redhat.com>\n\t<20241009200110.275544-3-hdegoede@redhat.com>","Subject":"Re: [RFC 2/4] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","From":"Kieran Bingham ","Cc":"Milan Zamazal , Maxime Ripard , \n\tHans de Goede ","To":"Hans de Goede , libcamera-devel@lists.libcamera.org","Date":"Thu, 10 Oct 2024 00:09:17 +0100","Message-ID":"<172851535750.532453.12226395429339106285@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31751,"web_url":"https://patchwork.libcamera.org/comment/31751/","msgid":"<87ikttbcob.fsf@redhat.com>","date":"2024-10-15T15:36:52","subject":"Re: [RFC 2/4] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hans de Goede writes:\n\n> patternSize_ is a private variable and its meaning is already documented\n> in the patternSize() getter documentation.\n>\n> Move the list of valid sizes to the patternSize() getter documentation\n> and drop the patternSize_ documentation.\n>\n> While at it also add 1x1 as valid size for use with future support\n> of single plane non Bayer input data.\n\nIIRC the inherent constraint on the widths and heights with the current\nimplementation is that they must be powers of 2 and IIRC it applies to\n2^0 too. So:\n\nReviewed-by: Milan Zamazal \n\nBut \"IIRC\" is not a good way to express the requirements imposed by the\nimplementation. I wonder whether we could do better.\n\n> Signed-off-by: Hans de Goede \n> ---\n> src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n> 1 file changed, 2 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index a9a3e77a..5e4246a9 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -58,6 +58,8 @@ namespace libcamera {\n> * also indicates if processLine2() should be called or not.\n> * This may only be called after a successful configure() call.\n> *\n> + * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n> + *\n> * \\return The pattern size\n> */\n> \n> @@ -112,13 +114,6 @@ namespace libcamera {\n> * \\brief Statistics window, set by setWindow(), used every line\n> */\n> \n> -/**\n> - * \\var Size SwStatsCpu::patternSize_\n> - * \\brief The size of the bayer pattern\n> - *\n> - * Valid sizes are: 2x2, 4x2 or 4x4.\n> - */\n> -\n> /**\n> * \\var unsigned int SwStatsCpu::xShift_\n> * \\brief The offset of x, applied to window_.x for bayer variants","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7366C326C\n\tfor ;\n\tTue, 15 Oct 2024 15:36:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE0C06537E;\n\tTue, 15 Oct 2024 17:36:58 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E50960537\n\tfor ;\n\tTue, 15 Oct 2024 17:36:57 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-332-M16c2175PSqHk6G9Z7u2KQ-1; Tue, 15 Oct 2024 11:36:54 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-37d5ca5bfc8so1906191f8f.0\n\tfor ;\n\tTue, 15 Oct 2024 08:36:54 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-37d7fa87ed1sm1859723f8f.45.2024.10.15.08.36.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 15 Oct 2024 08:36:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Gb5A3pYl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1729006616;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=j07AqUMBpQ+UkELPvilmFeCZUEEuUziiQ1/T76B7Gfg=;\n\tb=Gb5A3pYlTAIvTH/PooHAej2bVqk0T/sBtg4xEQv8EB7IkrQDom4oq8x00kO9hPqLcWlwxi\n\tRSmeA9e+fFki9VZTNj86422ldvUv1/kDBufykp88Zx5psaWUe/vdM7zf2d+3fV4x3olCKh\n\t55dUpKV71Uc6ciSYkGdyqo8MX/lbSJk=","X-MC-Unique":"M16c2175PSqHk6G9Z7u2KQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729006613; x=1729611413;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=j07AqUMBpQ+UkELPvilmFeCZUEEuUziiQ1/T76B7Gfg=;\n\tb=mDQh6sML0mRgo0+lAvY1Mlk+wOixMJvh9EldTmte+cd+RR9Cg9huERAxeepEZGnmXW\n\tJkUxXsWwci87R3Zx7NaT5Pspm5wVVmqwOmUxGqEpG6QbFxpVItWTRIuDOhxurLyPVpCw\n\tHOUN4GUCVr8WChS+5izP+a5MzKskAUPtiqF3eKnjidcxuRCpA9ofzkPhVyvALqNQgKqo\n\tvgyiCrb+jz1bFiueInlENL7oclN11pf3yva5LR2Pg7klEJLSW0N1Z0nR5co0ELRQ1t8W\n\tarrMBvJVRp3JN+7Su2Hc7mY4JNbPl66ANsLYUP6Gupa6wErBSQhATdzbQg8N1JRCi3/c\n\t+LVQ==","X-Gm-Message-State":"AOJu0Yw/y8hW4eM9yFOGb6Z9/m82pmu3eZcNL1pT4AIfR0aAngbNlIvf\n\toh+lXoAw3YOjJ+ogpa4PAdj1szIyXiti2ldAa9mxXSLrXF+XylOhjDjS+4TNldD3wX05fecrtbh\n\tAKDaEO806k4JhpDR0FZenjnZuip5riWA+0s4ouYbMIUQULtrlg1u2lePkwR723cGBhe8KFyk=","X-Received":["by 2002:a5d:55c9:0:b0:37c:cd71:2b96 with SMTP id\n\tffacd0b85a97d-37d5529ba0dmr10547607f8f.36.1729006613633; \n\tTue, 15 Oct 2024 08:36:53 -0700 (PDT)","by 2002:a5d:55c9:0:b0:37c:cd71:2b96 with SMTP id\n\tffacd0b85a97d-37d5529ba0dmr10547594f8f.36.1729006613275; \n\tTue, 15 Oct 2024 08:36:53 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHRcWXsc6QIjivloYLx43jlpv0WUdcHSlmSutlOdSMl48pbxwt+/NOxpkD5NsW87+ViVqObxw==","From":"Milan Zamazal ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org, Maxime Ripard ","Subject":"Re: [RFC 2/4] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","In-Reply-To":"<20241009200110.275544-3-hdegoede@redhat.com> (Hans de Goede's\n\tmessage of \"Wed, 9 Oct 2024 22:01:08 +0200\")","References":"<20241009200110.275544-1-hdegoede@redhat.com>\n\t<20241009200110.275544-3-hdegoede@redhat.com>","Date":"Tue, 15 Oct 2024 17:36:52 +0200","Message-ID":"<87ikttbcob.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]