[{"id":31631,"web_url":"https://patchwork.libcamera.org/comment/31631/","msgid":"<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>","date":"2024-10-09T07:33:05","subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 09/10/2024 08:16, Stefan Klug wrote:\n> The python venv module is the standard way of creating virtual python\n> environments. 'venv' is a commonly used name for the corresponding\n> directory. For example in the tuning docs we propose to execute 'python\n> -m venv venv' to setup a local virtual environment.  During development\n> I often have these scattered around in the source tree and they show up\n> as untracked files in git. Add venv to .gitignore to prevent that.\n>\n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> ---\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n>   .gitignore | 1 +\n>   1 file changed, 1 insertion(+)\n>\n> diff --git a/.gitignore b/.gitignore\n> index f6d1d68e4a7c..51d3144085ce 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -6,3 +6,4 @@\n>   *.patch\n>   *.pyc\n>   __pycache__/\n> +venv/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1276C32E0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Oct 2024 07:33:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCC186536B;\n\tWed,  9 Oct 2024 09:33:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBD8563527\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 09:33:08 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B09012EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 09:31:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MjDg+DuT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728459091;\n\tbh=AIkAeTOXzHOgUnAHzAGTsAKlvl++XcKPipB0tEflqW4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=MjDg+DuTZcU+HdFNl6c6sUO2wM1MrajZ+DfNJk720EDVH/M9qE129ZouwGvf/rffu\n\t91L+NqcYQvW3na5SvEAc/Fa8KUbk7EjNe2iUX9mTP+u0lMha+6Jukzpv0zhk+JwW4V\n\tYyq68P9ISrEyOrbAN8tYRedPYy1/X5T8TI/yV30U=","Message-ID":"<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>","Date":"Wed, 9 Oct 2024 08:33:05 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","To":"libcamera-devel@lists.libcamera.org","References":"<20241009071608.468018-1-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20241009071608.468018-1-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31634,"web_url":"https://patchwork.libcamera.org/comment/31634/","msgid":"<172846295325.3353069.1245816283277936511@ping.linuxembedded.co.uk>","date":"2024-10-09T08:35:53","subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Dan Scally (2024-10-09 08:33:05)\n> Hi Stefan\n> \n> On 09/10/2024 08:16, Stefan Klug wrote:\n> > The python venv module is the standard way of creating virtual python\n> > environments. 'venv' is a commonly used name for the corresponding\n> > directory. For example in the tuning docs we propose to execute 'python\n> > -m venv venv' to setup a local virtual environment.  During development\n> > I often have these scattered around in the source tree and they show up\n> > as untracked files in git. Add venv to .gitignore to prevent that.\n> >\n> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > ---\n\nI would wonder if venv isn't just a global thing to ignore, but as we\nhave python bindings in libcamera it might be slightly more relevant, so\nI don't specifically object.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n> >   .gitignore | 1 +\n> >   1 file changed, 1 insertion(+)\n> >\n> > diff --git a/.gitignore b/.gitignore\n> > index f6d1d68e4a7c..51d3144085ce 100644\n> > --- a/.gitignore\n> > +++ b/.gitignore\n> > @@ -6,3 +6,4 @@\n> >   *.patch\n> >   *.pyc\n> >   __pycache__/\n> > +venv/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91E42C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Oct 2024 08:35:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B5176536B;\n\tWed,  9 Oct 2024 10:35:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 616CF63527\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 10:35:56 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 094642EC;\n\tWed,  9 Oct 2024 10:34:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kk27fIxN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728462859;\n\tbh=nl7Cff4u/ueQKfC7Fanfa8GfmIOIUumpEQH9Ap2UoJ4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Kk27fIxNj/LYlRj3pfGlwVapkF7phxjKd2y1qMIZ3/Yb8JCuKz4Mxi+vaOX/Lgkds\n\tBropJZ+asDISSHlcDG89v8mYSgdI/eR5FAtYmB5gAxxNGCP+tnKPwHLq/Tn+iu8xLV\n\tcNjrAq9t2IyVKbaf3xWJK4/pHCzNvrd9uOg29dO8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>","References":"<20241009071608.468018-1-stefan.klug@ideasonboard.com>\n\t<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>","Subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Dan Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 09 Oct 2024 09:35:53 +0100","Message-ID":"<172846295325.3353069.1245816283277936511@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31659,"web_url":"https://patchwork.libcamera.org/comment/31659/","msgid":"<20241009154353.GI25706@pendragon.ideasonboard.com>","date":"2024-10-09T15:43:53","subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Oct 09, 2024 at 09:35:53AM +0100, Kieran Bingham wrote:\n> Quoting Dan Scally (2024-10-09 08:33:05)\n> > On 09/10/2024 08:16, Stefan Klug wrote:\n> > > The python venv module is the standard way of creating virtual python\n> > > environments. 'venv' is a commonly used name for the corresponding\n> > > directory. For example in the tuning docs we propose to execute 'python\n> > > -m venv venv' to setup a local virtual environment.  During development\n> > > I often have these scattered around in the source tree and they show up\n> > > as untracked files in git. Add venv to .gitignore to prevent that.\n> > >\n> > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > > ---\n> \n> I would wonder if venv isn't just a global thing to ignore, but as we\n> have python bindings in libcamera it might be slightly more relevant, so\n> I don't specifically object.\n\nI think venv is a better candidate for ~/.config/git/ignore, given that\nthe directory name is selected by users.\n\n> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n> > >   .gitignore | 1 +\n> > >   1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/.gitignore b/.gitignore\n> > > index f6d1d68e4a7c..51d3144085ce 100644\n> > > --- a/.gitignore\n> > > +++ b/.gitignore\n> > > @@ -6,3 +6,4 @@\n> > >   *.patch\n> > >   *.pyc\n> > >   __pycache__/\n> > > +venv/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71C3AC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Oct 2024 15:44:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A61AC618C5;\n\tWed,  9 Oct 2024 17:44:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E77D7618C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 17:43:58 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.230.3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04221594;\n\tWed,  9 Oct 2024 17:42:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gwmR3aVX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728488541;\n\tbh=AP+J1klTb33VOGvYudnZA+5k6jgVG72SAmxEo9gsFVM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gwmR3aVXo97TgVWHeejqBi7PGFF3jwZ6dammuMqOnedEQ1Mtm0Xz64LJTT1MK/PSk\n\togO+PoGM4Q78s+HuPahsleJuHNAQ5gPTj8vzBZLrW4catzYKNAcybmj47WJeMoCpT8\n\tx7xuGf/+9kuSP6kCMt0s6DXpnBJXCaqQRz4gfSh4=","Date":"Wed, 9 Oct 2024 18:43:53 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Dan Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","Message-ID":"<20241009154353.GI25706@pendragon.ideasonboard.com>","References":"<20241009071608.468018-1-stefan.klug@ideasonboard.com>\n\t<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>\n\t<172846295325.3353069.1245816283277936511@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172846295325.3353069.1245816283277936511@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31664,"web_url":"https://patchwork.libcamera.org/comment/31664/","msgid":"<20241009162949.GK25706@pendragon.ideasonboard.com>","date":"2024-10-09T16:29:49","subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Oct 09, 2024 at 06:43:53PM +0300, Laurent Pinchart wrote:\n> On Wed, Oct 09, 2024 at 09:35:53AM +0100, Kieran Bingham wrote:\n> > Quoting Dan Scally (2024-10-09 08:33:05)\n> > > On 09/10/2024 08:16, Stefan Klug wrote:\n> > > > The python venv module is the standard way of creating virtual python\n> > > > environments. 'venv' is a commonly used name for the corresponding\n> > > > directory. For example in the tuning docs we propose to execute 'python\n> > > > -m venv venv' to setup a local virtual environment.  During development\n> > > > I often have these scattered around in the source tree and they show up\n> > > > as untracked files in git. Add venv to .gitignore to prevent that.\n> > > >\n> > > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > > > ---\n> > \n> > I would wonder if venv isn't just a global thing to ignore, but as we\n> > have python bindings in libcamera it might be slightly more relevant, so\n> > I don't specifically object.\n> \n> I think venv is a better candidate for ~/.config/git/ignore, given that\n> the directory name is selected by users.\n\nOr $GIT_DIR/info/exclude. Quoting \"man gitignore\",\n\n    Which file to place a pattern in depends on how the pattern is meant to be used.\n\n    •   Patterns which should be version-controlled and distributed to other\n        repositories via clone (i.e., files that all developers will want to ignore)\n        should go into a .gitignore file.\n\n    •   Patterns which are specific to a particular repository but which do not need to\n        be shared with other related repositories (e.g., auxiliary files that live\n        inside the repository but are specific to one user’s workflow) should go into\n        the $GIT_DIR/info/exclude file.\n\n    •   Patterns which a user wants Git to ignore in all situations (e.g., backup or\n        temporary files generated by the user’s editor of choice) generally go into a\n        file specified by core.excludesFile in the user’s ˜/.gitconfig. Its default\n        value is $XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not set or\n        empty, $HOME/.config/git/ignore is used instead.\n\nWhich category does venv belong to ?\n\n> > Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n> > > >   .gitignore | 1 +\n> > > >   1 file changed, 1 insertion(+)\n> > > >\n> > > > diff --git a/.gitignore b/.gitignore\n> > > > index f6d1d68e4a7c..51d3144085ce 100644\n> > > > --- a/.gitignore\n> > > > +++ b/.gitignore\n> > > > @@ -6,3 +6,4 @@\n> > > >   *.patch\n> > > >   *.pyc\n> > > >   __pycache__/\n> > > > +venv/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D6E9C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Oct 2024 16:29:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F33763538;\n\tWed,  9 Oct 2024 18:29:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2D24618C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 18:29:54 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.230.3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DDC52EC;\n\tWed,  9 Oct 2024 18:28:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AZ/bzQXd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728491297;\n\tbh=xx5YNQYEMkWAckCABmnqQUJpg4ZC8Dulp8orhgM2S4c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AZ/bzQXd4mSIbXuQmzpO+qomq9a0nLAs4jTJjoW+hSCQpNBExxeu+7cYoYHEf1wJE\n\t4mVUrJcwQR41nrQWqaxiXAoXeUKjaK0JuOQbrD6y9Nsl5FTpAGBxm3wCUHEdad+MQ2\n\tShmXsYLx+bbc7XzRR6TFc92k7BPjW3oDA+ajrocU=","Date":"Wed, 9 Oct 2024 19:29:49 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Dan Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] gitignore: Add venv directory to gitignore","Message-ID":"<20241009162949.GK25706@pendragon.ideasonboard.com>","References":"<20241009071608.468018-1-stefan.klug@ideasonboard.com>\n\t<795b945c-63f3-4b5a-8ea9-1a2765462944@ideasonboard.com>\n\t<172846295325.3353069.1245816283277936511@ping.linuxembedded.co.uk>\n\t<20241009154353.GI25706@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241009154353.GI25706@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]