{"id":21548,"url":"https://patchwork.libcamera.org/api/patches/21548/?format=json","web_url":"https://patchwork.libcamera.org/patch/21548/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241008231314.744556-3-kieran.bingham@ideasonboard.com>","date":"2024-10-08T23:13:12","name":"[v3,2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"06d82c55785d7a5e62b8daecab69bba6fc0699c9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21548/mbox/","series":[{"id":4668,"url":"https://patchwork.libcamera.org/api/series/4668/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4668","date":"2024-10-08T23:13:10","name":"MediaPipeline: Complex input device support","version":3,"mbox":"https://patchwork.libcamera.org/series/4668/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21548/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21548/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1FF1C32DE\n\tfor ;\n\tTue, 8 Oct 2024 23:13:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F50465373;\n\tWed, 9 Oct 2024 01:13:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 693906536A\n\tfor ;\n\tWed, 9 Oct 2024 01:13:23 +0200 (CEST)","from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0DA3D21;\n\tWed, 9 Oct 2024 01:11:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K//NS9qN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728429106;\n\tbh=b1bCuUEWIxg0c9z/dqJMBUBciQv78Kl+YURbzgCbQ/0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=K//NS9qNQL1msQzV84Qk04W9OPKTnrhmn78cqD4nrzLoq5jR6k1KvfjPjJN6eC+pm\n\tR+VHXaaSLjrK1rgW3BZsG17FbRwzF6DbZscYJ8ZJKofkCsGGBKCKa3OJqE/aKh0s/p\n\tHFiFCamEOzDOq+qQ/qDLoiZnB0kMfcTzUBr99zi4=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ,\n\tUmang Jain ,\n\tJacopo Mondi ","Subject":"[PATCH v3 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","Date":"Wed, 9 Oct 2024 00:13:12 +0100","Message-Id":"<20241008231314.744556-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241008231314.744556-1-kieran.bingham@ideasonboard.com>","References":"<20241008231314.744556-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The delay values should be managed correctly. Not the dealys.\n\nCorrect accordingly.\n\nReviewed-by: Umang Jain \nReviewed-by: Jacopo Mondi \nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c02c7cf374e9..2fee84e56d4d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tdata->properties_ = data->sensor_->properties();\n \n \t/*\n-\t * \\todo Read dealy values from the sensor itself or from a\n+\t * \\todo Read delay values from the sensor itself or from a\n \t * a sensor database. For now use generic values taken from\n \t * the Raspberry Pi and listed as generic values.\n \t */\n","prefixes":["v3","2/4"]}