[{"id":31690,"web_url":"https://patchwork.libcamera.org/comment/31690/","msgid":"<172854895867.532453.6107310806117715196@ping.linuxembedded.co.uk>","date":"2024-10-10T08:29:18","subject":"Re: [PATCH v3 5/7] ipa: rkisp1: Add debug metadata support to the\n\trkisp1","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-10-08 16:29:43)\n> Add a DebugMetadata helper to the context and add the corresponding\n> plumbing. This is all that is needed to support debug metadata in an\n> IPA.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> Changes in v3:\n> - Whitespace changes\n> \n> Changes in v2:\n> - Replace DebugMetadata::assignList by DebugMetadata::moveEntries\n> ---\n> src/ipa/rkisp1/ipa_context.h | 5 +++++\n> src/ipa/rkisp1/rkisp1.cpp | 3 +++\n> 2 files changed, 8 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index d52e73ad2503..7b93a9e9461d 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -17,8 +17,11 @@\n> #include \n> #include \n> #include \n> +\n> #include \n> \n> +#include \"libcamera/internal/debug_controls.h\"\n> +\n> #include \n> #include \n> #include \n> @@ -194,6 +197,8 @@ struct IPAContext {\n> \n> ControlInfoMap::Map ctrlMap;\n> \n> + DebugMetadata debugMetadata;\n> +\n> /* Interface to the Camera Helper */\n> std::unique_ptr camHelper;\n> };\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a579f21de56f..03eae01baf54 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -117,6 +117,7 @@ const IPAHwSettings ipaHwSettingsV12{\n> const ControlInfoMap::Map rkisp1Controls{\n> { &controls::AwbEnable, ControlInfo(false, true) },\n> { &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> + { &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n\nAck. This is definitely a top level control...\n\n\nReviewed-by: Kieran Bingham \n\n> { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n> @@ -326,6 +327,7 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> IPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n> + context_.debugMetadata.enableByControl(controls);\n> \n> for (auto const &a : algorithms()) {\n> Algorithm *algo = static_cast(a.get());\n> @@ -378,6 +380,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n> \n> setControls(frame);\n> \n> + context_.debugMetadata.moveEntries(metadata);\n> metadataReady.emit(frame, metadata);\n> }\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E79FC32EA\n\tfor ;\n\tThu, 10 Oct 2024 08:29:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D32C56536C;\n\tThu, 10 Oct 2024 10:29:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D225163536\n\tfor ;\n\tThu, 10 Oct 2024 10:29:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 000424D4;\n\tThu, 10 Oct 2024 10:27:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KyqQH2QY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728548863;\n\tbh=ly4ABEHSzH7uAzBKaUDjAunOYBYJ3WGPRVVomjQHW70=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=KyqQH2QYWlg41P75oe/mjHvR+S5ECSuBwhzimukcg14toQowcSNEv4+B9sgj2cizH\n\tup51bXGzM8ZmgeF2u2oIIVJrNEQkSdWJUwhf8J+ECbJu4eEqQlXdz/XfysxMW+r3/T\n\tO6eAP9zXBVRihxQlvB3KYZjj3hUn+fuwdvttGs5k=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241008153031.429906-6-stefan.klug@ideasonboard.com>","References":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>\n\t<20241008153031.429906-6-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 5/7] ipa: rkisp1: Add debug metadata support to the\n\trkisp1","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tLaurent Pinchart ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 10 Oct 2024 09:29:18 +0100","Message-ID":"<172854895867.532453.6107310806117715196@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]