[{"id":31684,"web_url":"https://patchwork.libcamera.org/comment/31684/","msgid":"<172851602145.532453.16967393395819541113@ping.linuxembedded.co.uk>","date":"2024-10-09T23:20:21","subject":"Re: [PATCH v3 1/7] libcamera: Add debug control space","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-10-08 16:29:39)\n> Add a new 'debug' controls namespace for the upcoming implementation of\n> debug metadata. While at it, sort the entries alphabetically.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n> \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Changes in v2:\n> - Order lists in meson file alphabetically\n> - Fix wording in control-ranges\n> ---\n> include/libcamera/meson.build | 5 +++--\n> src/libcamera/control_ids_debug.yaml | 6 ++++++\n> src/libcamera/control_ranges.yaml | 4 +++-\n> 3 files changed, 12 insertions(+), 3 deletions(-)\n> create mode 100644 src/libcamera/control_ids_debug.yaml\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index a969a95dbf7a..fd69a5172b6a 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -34,8 +34,9 @@ libcamera_headers_install_dir = get_option('includedir') / libcamera_include_dir\n> \n> controls_map = {\n> 'controls': {\n> - 'draft': 'control_ids_draft.yaml',\n> 'core': 'control_ids_core.yaml',\n> + 'debug': 'control_ids_debug.yaml',\n> + 'draft': 'control_ids_draft.yaml',\n> 'rpi/vc4': 'control_ids_rpi.yaml',\n> },\n> \n> @@ -55,7 +56,7 @@ foreach mode, entry : controls_map\n> files_list = []\n> input_files = []\n> foreach vendor, header : entry\n> - if vendor != 'core' and vendor != 'draft'\n> + if vendor not in ['core', 'debug', 'draft']\n> if vendor not in pipelines\n> continue\n> endif\n> diff --git a/src/libcamera/control_ids_debug.yaml b/src/libcamera/control_ids_debug.yaml\n> new file mode 100644\n> index 000000000000..797532712099\n> --- /dev/null\n> +++ b/src/libcamera/control_ids_debug.yaml\n> @@ -0,0 +1,6 @@\n> +# SPDX-License-Identifier: LGPL-2.1-or-later\n> +#\n> +%YAML 1.1\n> +---\n> +vendor: debug\n> +controls: []\n> diff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\n> index d42447d04647..6752eb986ac6 100644\n> --- a/src/libcamera/control_ranges.yaml\n> +++ b/src/libcamera/control_ranges.yaml\n> @@ -13,6 +13,8 @@ ranges:\n> draft: 10000\n> # Raspberry Pi vendor controls\n> rpi: 20000\n> - # Next range starts at 30000\n> + # Controls for debug metadata\n> + debug: 30000\n> + # Next range starts at 40000\n> \n> ...\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68003C32E0\n\tfor ;\n\tWed, 9 Oct 2024 23:20:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66F8465369;\n\tThu, 10 Oct 2024 01:20:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16B3F618C5\n\tfor ;\n\tThu, 10 Oct 2024 01:20:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56543226;\n\tThu, 10 Oct 2024 01:18:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c6C0CDYA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728515926;\n\tbh=5oUDo3p7LLiks+VKxpnqS74DEtmvusg7EN7MoOY1lL4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=c6C0CDYAF9WsWeTXLiyMpTamYIgmfcZb/Str/PfArunPiG2oTN4W367yxHvC4XbXJ\n\tlRc1V7/rvxcfr5B3RCUF1ug5QbkWKB56NA5wZ1scEopxDWaOpmiq393Atof2m0U8hv\n\tAepidRViePDSeYYTE21cIraz3K7en43C8GDeOl24=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241008153031.429906-2-stefan.klug@ideasonboard.com>","References":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>\n\t<20241008153031.429906-2-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 1/7] libcamera: Add debug control space","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tLaurent Pinchart ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 10 Oct 2024 00:20:21 +0100","Message-ID":"<172851602145.532453.16967393395819541113@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]