{"id":21539,"url":"https://patchwork.libcamera.org/api/patches/21539/?format=json","web_url":"https://patchwork.libcamera.org/patch/21539/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241008153031.429906-2-stefan.klug@ideasonboard.com>","date":"2024-10-08T15:29:39","name":"[v3,1/7] libcamera: Add debug control space","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"332d9b794dc81c83cde368fe8bc14d14f5409253","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21539/mbox/","series":[{"id":4667,"url":"https://patchwork.libcamera.org/api/series/4667/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4667","date":"2024-10-08T15:29:38","name":"Add support for IPA debugging metadata","version":3,"mbox":"https://patchwork.libcamera.org/series/4667/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21539/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21539/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF32EBE080\n\tfor ;\n\tTue, 8 Oct 2024 15:30:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ACAF6536A;\n\tTue, 8 Oct 2024 17:30:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18B47618C9\n\tfor ;\n\tTue, 8 Oct 2024 17:30:39 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d:f30b:aa60:fabf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65AB4DB2;\n\tTue, 8 Oct 2024 17:29:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UWLfpZik\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728401342;\n\tbh=N8SXyiRn6oogNlVsQAt3fKdwiGld6ohhqYMzBlH0PgM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UWLfpZikZQbYThAgNOW2Lnkv8T+7Xoyi6a7k1WP7XH6JYeSd5KmPuMOgOYiiHitjQ\n\trqaTJB68rMKhAxXIHBIOCz3u2ISP2ykiTWtMSzpyOY+2DviLO58XCAJTG/c4V+KSZD\n\tlSdmgz/6QOI58RIuT66lNM/t9hZ+owqctKM94aTE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 1/7] libcamera: Add debug control space","Date":"Tue, 8 Oct 2024 17:29:39 +0200","Message-ID":"<20241008153031.429906-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>","References":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a new 'debug' controls namespace for the upcoming implementation of\ndebug metadata. While at it, sort the entries alphabetically.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v2:\n- Order lists in meson file alphabetically\n- Fix wording in control-ranges\n---\n include/libcamera/meson.build | 5 +++--\n src/libcamera/control_ids_debug.yaml | 6 ++++++\n src/libcamera/control_ranges.yaml | 4 +++-\n 3 files changed, 12 insertions(+), 3 deletions(-)\n create mode 100644 src/libcamera/control_ids_debug.yaml","diff":"diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex a969a95dbf7a..fd69a5172b6a 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -34,8 +34,9 @@ libcamera_headers_install_dir = get_option('includedir') / libcamera_include_dir\n \n controls_map = {\n 'controls': {\n- 'draft': 'control_ids_draft.yaml',\n 'core': 'control_ids_core.yaml',\n+ 'debug': 'control_ids_debug.yaml',\n+ 'draft': 'control_ids_draft.yaml',\n 'rpi/vc4': 'control_ids_rpi.yaml',\n },\n \n@@ -55,7 +56,7 @@ foreach mode, entry : controls_map\n files_list = []\n input_files = []\n foreach vendor, header : entry\n- if vendor != 'core' and vendor != 'draft'\n+ if vendor not in ['core', 'debug', 'draft']\n if vendor not in pipelines\n continue\n endif\ndiff --git a/src/libcamera/control_ids_debug.yaml b/src/libcamera/control_ids_debug.yaml\nnew file mode 100644\nindex 000000000000..797532712099\n--- /dev/null\n+++ b/src/libcamera/control_ids_debug.yaml\n@@ -0,0 +1,6 @@\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+%YAML 1.1\n+---\n+vendor: debug\n+controls: []\ndiff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\nindex d42447d04647..6752eb986ac6 100644\n--- a/src/libcamera/control_ranges.yaml\n+++ b/src/libcamera/control_ranges.yaml\n@@ -13,6 +13,8 @@ ranges:\n draft: 10000\n # Raspberry Pi vendor controls\n rpi: 20000\n- # Next range starts at 30000\n+ # Controls for debug metadata\n+ debug: 30000\n+ # Next range starts at 40000\n \n ...\n","prefixes":["v3","1/7"]}