[{"id":31620,"web_url":"https://patchwork.libcamera.org/comment/31620/","msgid":"<w6vakq5tsqftnrtyw5sgfub5uryd7dmyuktdh3tnoe3khpb77z@mdmj56hjkonr>","date":"2024-10-08T13:44:06","subject":"Re: [PATCH] Documentation: guides: Fix FileSink source link","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Umang\n\nOn Tue, Oct 08, 2024 at 07:03:34PM GMT, Umang Jain wrote:\n> Fix the 'class FileSink' source link which got broken due to\n> commit 84ad104499d9e (\"Move test applications to src/apps/\").\n>\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n\nIndeed\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n\n> ---\n>  Documentation/guides/application-developer.rst | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 1ea8c40f..25beb55d 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -483,7 +483,7 @@ instance. An example of how to write image data to disk is available in the\n>  `FileSink class`_ which is a part of the ``cam`` utility application in the\n>  libcamera repository.\n>\n> -.. _FileSink class: https://git.libcamera.org/libcamera/libcamera.git/tree/src/cam/file_sink.cpp\n> +.. _FileSink class: https://git.libcamera.org/libcamera/libcamera.git/tree/src/apps/cam/file_sink.cpp\n>\n>  With the handling of this request completed, it is possible to re-use the\n>  request and the associated buffers and re-queue it to the camera\n> --\n> 2.45.2\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A698BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  8 Oct 2024 13:44:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D9A46353B;\n\tTue,  8 Oct 2024 15:44:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90035618C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  8 Oct 2024 15:44:10 +0200 (CEST)","from ideasonboard.com (unknown [5.77.124.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95FCD514;\n\tTue,  8 Oct 2024 15:42:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W1F3adD/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728394953;\n\tbh=xzVosQWXWNxj8aFt32YbqxN+e4XRhDVTpdWF6OfYqt0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W1F3adD/XPJUBm78P3jX4MWLUj5CO/ComkAlJ9OG8xk+e8Xqj4WNBBho6yJWMyLaJ\n\t+ugTne4oziwD8tcT80KvZAzM8moOzabsNGbjI3DAZTwGk7iQ7xopPV9qyLK02VH5QW\n\tsDyvRKWxXKEYs9/a7xUJ+wQMmAP8BEaA4HX5IO50=","Date":"Tue, 8 Oct 2024 15:44:06 +0200","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Umang Jain <umang.jain@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] Documentation: guides: Fix FileSink source link","Message-ID":"<w6vakq5tsqftnrtyw5sgfub5uryd7dmyuktdh3tnoe3khpb77z@mdmj56hjkonr>","References":"<20241008133334.202073-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241008133334.202073-1-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]