[{"id":31606,"web_url":"https://patchwork.libcamera.org/comment/31606/","msgid":"<20241007221551.GF30699@pendragon.ideasonboard.com>","date":"2024-10-07T22:15:51","subject":"Re: [PATCH v2 5/7] ipa: rkisp1: Add debug metadata support to the\n\trkisp1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 07, 2024 at 11:54:09AM +0200, Stefan Klug wrote:\n> Add a DebugMetadata helper to the context and add the corresponding\n> plumbing. This is all that is needed to support debug metadata in an\n> IPA.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> Changes in v2:\n> - Replace DebugMetadata::assignList by DebugMetadata::moveEntries\n> ---\n> src/ipa/rkisp1/ipa_context.h | 5 +++++\n> src/ipa/rkisp1/rkisp1.cpp | 3 +++\n> 2 files changed, 8 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index d52e73ad2503..7b93a9e9461d 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -17,8 +17,11 @@\n> #include \n> #include \n> #include \n> +\n> #include \n> \n> +#include \"libcamera/internal/debug_controls.h\"\n> +\n> #include \n> #include \n> #include \n> @@ -194,6 +197,8 @@ struct IPAContext {\n> \n> \tControlInfoMap::Map ctrlMap;\n> \n> +\tDebugMetadata debugMetadata;\n> +\n> \t/* Interface to the Camera Helper */\n> \tstd::unique_ptr camHelper;\n> };\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a579f21de56f..b96141aabf0f 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -117,6 +117,7 @@ const IPAHwSettings ipaHwSettingsV12{\n> const ControlInfoMap::Map rkisp1Controls{\n> \t{ &controls::AwbEnable, ControlInfo(false, true) },\n> \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> +\t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n> \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n> @@ -326,6 +327,7 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n> void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n> +\tcontext_.debugMetadata.checkForEnable(controls);\n> \n> \tfor (auto const &a : algorithms()) {\n> \t\tAlgorithm *algo = static_cast(a.get());\n> @@ -377,6 +379,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n> \t}\n> \n> \tsetControls(frame);\n> +\tcontext_.debugMetadata.moveEntries(metadata);\n> \n> \tmetadataReady.emit(frame, metadata);\n\nNitpicking, I'd write\n\n\tsetControls(frame);\n\n\tcontext_.debugMetadata.moveEntries(metadata);\n\tmetadataReady.emit(frame, metadata);\n\nReviewed-by: Laurent Pinchart \n\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB0C5BE080\n\tfor ;\n\tMon, 7 Oct 2024 22:15:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D2156353A;\n\tTue, 8 Oct 2024 00:15:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5297162C91\n\tfor ;\n\tTue, 8 Oct 2024 00:15:57 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.230.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACFF02E0;\n\tTue, 8 Oct 2024 00:14:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fblTDYRN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728339261;\n\tbh=kB/qaKYImpV6uz3AKoZFOIRz+f7QNHoFCN51fTuky+I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fblTDYRNtXG+TSUfnlU6cCQ5TNOxNe+s/tsDC9R48F9BJr7dhfKsANHIAdos7CXBn\n\t0QeU3Ym9nvVQl1gXJ+/ZEGq1aQVHjXz/LmGnqqTW6xkrQSdaRpZdudIC8TnGJIzU5X\n\txFrmKH0/qDxsub/pAi2E16MITgmkjGCu3WMICsuE=","Date":"Tue, 8 Oct 2024 01:15:51 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 5/7] ipa: rkisp1: Add debug metadata support to the\n\trkisp1","Message-ID":"<20241007221551.GF30699@pendragon.ideasonboard.com>","References":"<20241007095425.211158-1-stefan.klug@ideasonboard.com>\n\t<20241007095425.211158-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241007095425.211158-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]