[{"id":31565,"web_url":"https://patchwork.libcamera.org/comment/31565/","msgid":"<172796302103.1619946.9555012603791750513@ping.linuxembedded.co.uk>","date":"2024-10-03T13:43:41","subject":"Re: [PATCH] libcamera: software_isp: Improve wording in a comment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-10-02 17:48:01)\n> A minor wording improvement suggested on refactoring review.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\nWill apply immediately.\n\n> ---\n> src/ipa/simple/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n> index 783dfb8bc..df92edd7e 100644\n> --- a/src/ipa/simple/algorithms/agc.cpp\n> +++ b/src/ipa/simple/algorithms/agc.cpp\n> @@ -29,7 +29,7 @@ static constexpr unsigned int kExposureBinsCount = 5;\n> static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n> \n> /*\n> - * The below value implements the hysteresis for the exposure adjustment.\n> + * This implements the hysteresis for the exposure adjustment.\n> * It is small enough to have the exposure close to the optimal, and is big\n> * enough to prevent the exposure from wobbling around the optimal value.\n> */\n> -- \n> 2.44.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0D52C3257\n\tfor ;\n\tThu, 3 Oct 2024 13:43:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 859E063524;\n\tThu, 3 Oct 2024 15:43:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6A4062C92\n\tfor ;\n\tThu, 3 Oct 2024 15:43:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78D59593;\n\tThu, 3 Oct 2024 15:42:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c932anUg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727962930;\n\tbh=Ap6ljGL4q3F6PHWw3OcezTSBAB9MC26RiLz9p1h/foY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=c932anUgxvpiA+hlBbborsGRjxfY+thVeESHk2CcXUu3jXJnk4aALBfP1L9PgQljr\n\txeCE+2E9WrgeBVbALc4HJ/fOCY0jBrKip3cVn2rkRRHmRdOv4aaP3kwhqlCNKRbAEq\n\tGSsanWQpDp0wlvqbnA+Isnw5UxeHEIHCppW2FwAE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241002164801.1556328-1-mzamazal@redhat.com>","References":"<20241002164801.1556328-1-mzamazal@redhat.com>","Subject":"Re: [PATCH] libcamera: software_isp: Improve wording in a comment","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tUmang Jain ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 03 Oct 2024 14:43:41 +0100","Message-ID":"<172796302103.1619946.9555012603791750513@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]