[{"id":31572,"web_url":"https://patchwork.libcamera.org/comment/31572/","msgid":"<20241003165123.GB7009@pendragon.ideasonboard.com>","date":"2024-10-03T16:51:23","subject":"Re: [PATCH v1 8/8] [WIP] ipa: enable debug metadata by default","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Wed, Oct 02, 2024 at 06:19:26PM +0200, Stefan Klug wrote:\n> Camshark currently doesn't support metadata values that are not there on\n> every frame. Enable the debug metadata by default to test this series.\n\nPatches that are temporary and not meant for integration can be marked\nwith [DNI] (which stands for Do Not Integrate) instead of [WIP].\n\n> Signed-off-by: Stefan Klug \n\nI won't provide a R-b tag as this shouldn't be merged :-)\n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 5b1ef0c372c6..fc95f733a2e8 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -328,6 +328,11 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n> \tcontext_.debugMetadata.checkForEnable(controls);\n> +\t/*\n> +\t * Todo: Remove the unconditional enable as soon as camshark supports\n> +\t * metadata that is not available on every frame\n> +\t */\n> +\tcontext_.debugMetadata.enable();\n> \n> \tfor (auto const &a : algorithms()) {\n> \t\tAlgorithm *algo = static_cast(a.get());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18DA9C3257\n\tfor ;\n\tThu, 3 Oct 2024 16:51:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE6FB63527;\n\tThu, 3 Oct 2024 18:51:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 057A762C92\n\tfor ;\n\tThu, 3 Oct 2024 18:51:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8147F593;\n\tThu, 3 Oct 2024 18:49:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q2x5tWww\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727974193;\n\tbh=diOyaHrg4hyX+vUW5DtsdvDWAWXhCLgCSewlg5Fz8CE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q2x5tWww2vSbCRFafQ8+QI4OaA6ysIujsKNyqtWAZf1gAqtuai0PrqSrvQzGan7t6\n\tODNJof1GJsb1/5I61V8hzFZ9tulr/RPh2XxI3SG/4xgMcv4b2rUhkGwF0U6lyLLO97\n\tESxis/FgSxGBjcFx0ueAxNfdEUrnryMk9VPJVTyY=","Date":"Thu, 3 Oct 2024 19:51:23 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 8/8] [WIP] ipa: enable debug metadata by default","Message-ID":"<20241003165123.GB7009@pendragon.ideasonboard.com>","References":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>\n\t<20241002161933.247091-9-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241002161933.247091-9-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]