[{"id":31570,"web_url":"https://patchwork.libcamera.org/comment/31570/","msgid":"<20241003163746.GB32537@pendragon.ideasonboard.com>","date":"2024-10-03T16:37:46","subject":"Re: [PATCH v1 4/8] ipa: rkisp1: Add constructor to the ipa context","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Wed, Oct 02, 2024 at 06:19:22PM +0200, Stefan Klug wrote:\n> Initialization using the initializer list is cumbersome and requires\n> modifications to the list whenever the context is modified. Fix that by\n> adding a proper constructor to the context.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/ipa_context.h | 5 +++++\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> 2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index e274d9b01e1c..d52e73ad2503 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -180,6 +180,11 @@ struct IPAFrameContext : public FrameContext {\n> };\n> \n> struct IPAContext {\n> +\tIPAContext(unsigned int frameContextSize)\n> +\t\t: hw(nullptr), frameContexts(frameContextSize)\n> +\t{\n> +\t}\n> +\n> \tconst IPAHwSettings *hw;\n> \tIPACameraSensorInfo sensorInfo;\n> \tIPASessionConfiguration configuration;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 9e161cabdea4..a579f21de56f 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n> } /* namespace */\n> \n> IPARkISP1::IPARkISP1()\n> -\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n> +\t: context_(kMaxFrameContexts)\n\nThis looks nicer indeed.\n\nReviewed-by: Laurent Pinchart \n\n> {\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35C19C3257\n\tfor ;\n\tThu, 3 Oct 2024 16:37:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12F7663524;\n\tThu, 3 Oct 2024 18:37:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A4F462C92\n\tfor ;\n\tThu, 3 Oct 2024 18:37:50 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E155218D;\n\tThu, 3 Oct 2024 18:36:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ka8zj6dD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727973377;\n\tbh=KaV0IKOKPVAKbVjz79xjzO6WW5mC906l+Uru98SRn2g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ka8zj6dDQS09li5W5dhqdwdCuzUNCBJbClrlLVyr0q9P18ul1wBCIatKR3nc+7ENs\n\tVC+Cwb9q6geLKUNiliZqt/vwQHN3XfmFe6y9KQLRfzzHBOc4hEv1Vd48ug6Uaqx0br\n\tU99rx9+XqFJ4dWA+nmoUMc7CCAI3o5oWG2+BgZyQ=","Date":"Thu, 3 Oct 2024 19:37:46 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 4/8] ipa: rkisp1: Add constructor to the ipa context","Message-ID":"<20241003163746.GB32537@pendragon.ideasonboard.com>","References":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>\n\t<20241002161933.247091-5-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241002161933.247091-5-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31580,"web_url":"https://patchwork.libcamera.org/comment/31580/","msgid":"<172799685858.1375180.14092272616568399647@ping.linuxembedded.co.uk>","date":"2024-10-03T23:07:38","subject":"Re: [PATCH v1 4/8] ipa: rkisp1: Add constructor to the ipa context","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-10-03 17:37:46)\n> Hi Stefan,\n> \n> Thank you for the patch.\n> \n> On Wed, Oct 02, 2024 at 06:19:22PM +0200, Stefan Klug wrote:\n> > Initialization using the initializer list is cumbersome and requires\n> > modifications to the list whenever the context is modified. Fix that by\n> > adding a proper constructor to the context.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/ipa/rkisp1/ipa_context.h | 5 +++++\n> > src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> > 2 files changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index e274d9b01e1c..d52e73ad2503 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -180,6 +180,11 @@ struct IPAFrameContext : public FrameContext {\n> > };\n> > \n> > struct IPAContext {\n> > + IPAContext(unsigned int frameContextSize)\n> > + : hw(nullptr), frameContexts(frameContextSize)\n> > + {\n> > + }\n> > +\n> > const IPAHwSettings *hw;\n> > IPACameraSensorInfo sensorInfo;\n> > IPASessionConfiguration configuration;\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 9e161cabdea4..a579f21de56f 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n> > } /* namespace */\n> > \n> > IPARkISP1::IPARkISP1()\n> > - : context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n> > + : context_(kMaxFrameContexts)\n> \n> This looks nicer indeed.\n\nVery much indeed.\n\nWould it be a lot to ask if we could get a drive by update to do the\nsame fix for the IPU3, and Simple pipeline handlers ?\n\nIt could always still be done separately though.\n\nReviewed-by: Kieran Bingham \n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > {\n> > }\n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEFF3BD80A\n\tfor ;\n\tThu, 3 Oct 2024 23:07:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5354063526;\n\tFri, 4 Oct 2024 01:07:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B01BF63510\n\tfor ;\n\tFri, 4 Oct 2024 01:07:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95B1D55;\n\tFri, 4 Oct 2024 01:06:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f9HCiEsE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727996767;\n\tbh=i45f2UBkI1KtXSQ15C8ygy3TN0TAkthafPZbPq4lbDA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=f9HCiEsEjxXZFcvZ6hIXTEKEEp/0TJUgstbJef6DN0CciE0skppWXQC+oXXzfskGw\n\t+aYLMIkx1HRfSyCzjA4AaxDGIa4szjgsw0Ftxtjgi41atanIJlDJeE016JB3PU3AWG\n\tHfJgfws0wqfOF/stC8qIdhwJVnPr4gjFrsqKztpA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241003163746.GB32537@pendragon.ideasonboard.com>","References":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>\n\t<20241002161933.247091-5-stefan.klug@ideasonboard.com>\n\t<20241003163746.GB32537@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v1 4/8] ipa: rkisp1: Add constructor to the ipa context","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tStefan Klug ","Date":"Fri, 04 Oct 2024 00:07:38 +0100","Message-ID":"<172799685858.1375180.14092272616568399647@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]