[{"id":31540,"web_url":"https://patchwork.libcamera.org/comment/31540/","msgid":"<20241002234832.GD17537@pendragon.ideasonboard.com>","date":"2024-10-02T23:48:32","subject":"Re: [PATCH v1 1/8] libcamera: Add debug control space","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Wed, Oct 02, 2024 at 06:19:19PM +0200, Stefan Klug wrote:\n> Add a new 'debug' controls namespace for the upcoming implementation of\n> debug metadata.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> include/libcamera/meson.build | 3 ++-\n> src/libcamera/control_ids_debug.yaml | 11 +++++++++++\n> src/libcamera/control_ranges.yaml | 5 ++++-\n> 3 files changed, 17 insertions(+), 2 deletions(-)\n> create mode 100644 src/libcamera/control_ids_debug.yaml\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index a969a95dbf7a..152806988479 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -36,6 +36,7 @@ controls_map = {\n> 'controls': {\n> 'draft': 'control_ids_draft.yaml',\n> 'core': 'control_ids_core.yaml',\n> + 'debug': 'control_ids_debug.yaml',\n\nWhile at it, could you sort these alphabetically ?\n\n> 'rpi/vc4': 'control_ids_rpi.yaml',\n> },\n> \n> @@ -55,7 +56,7 @@ foreach mode, entry : controls_map\n> files_list = []\n> input_files = []\n> foreach vendor, header : entry\n> - if vendor != 'core' and vendor != 'draft'\n> + if vendor not in ['core', 'draft', 'debug']\n\nAlphabetical order here too.\n\nReviewed-by: Laurent Pinchart \n\n> if vendor not in pipelines\n> continue\n> endif\n> diff --git a/src/libcamera/control_ids_debug.yaml b/src/libcamera/control_ids_debug.yaml\n> new file mode 100644\n> index 000000000000..11ddfd7cc8d8\n> --- /dev/null\n> +++ b/src/libcamera/control_ids_debug.yaml\n> @@ -0,0 +1,11 @@\n> +# SPDX-License-Identifier: LGPL-2.1-or-later\n> +#\n> +# Copyright (C) 2024, Ideas on Board Oy\n> +#\n> +%YAML 1.1\n> +---\n> +# Unless otherwise stated, all controls are bi-directional, i.e. they can be\n> +# set through Request::controls() and returned out through Request::metadata().\n> +vendor: debug\n> +controls:\n> +\n> diff --git a/src/libcamera/control_ranges.yaml b/src/libcamera/control_ranges.yaml\n> index d42447d04647..b89a517a64cd 100644\n> --- a/src/libcamera/control_ranges.yaml\n> +++ b/src/libcamera/control_ranges.yaml\n> @@ -13,6 +13,9 @@ ranges:\n> draft: 10000\n> # Raspberry Pi vendor controls\n> rpi: 20000\n> - # Next range starts at 30000\n> + # Development controls\n> + debug: 30000\n> + # Next range starts at 40000\n> +\n> \n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54206BD80A\n\tfor ;\n\tWed, 2 Oct 2024 23:48:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3628363522;\n\tThu, 3 Oct 2024 01:48:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22A3560553\n\tfor ;\n\tThu, 3 Oct 2024 01:48:36 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB9231014;\n\tThu, 3 Oct 2024 01:47:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADzC+XOD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727912823;\n\tbh=bEFNs6iSfhVqWeo6V/uYQiUAseaaI7dMrKk/DaKT4HI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ADzC+XOD7rZYGGfREExwEVLIwz0YbfaR2EIMzafW9/QT1Yrwqk7rjFhSrIby0Is7W\n\t/JFWgkMQQuEq0AqS2ZR2I7KxzbVoTF4Y0Zw/jNVpEKpI6t1suNZNwNWawQCVyj1ZaU\n\tk51t08p3lQMvSeMleC+jtvjdHNFgm2JmiPUMz3gE=","Date":"Thu, 3 Oct 2024 02:48:32 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/8] libcamera: Add debug control space","Message-ID":"<20241002234832.GD17537@pendragon.ideasonboard.com>","References":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>\n\t<20241002161933.247091-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241002161933.247091-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]