{"id":21459,"url":"https://patchwork.libcamera.org/api/patches/21459/?format=json","web_url":"https://patchwork.libcamera.org/patch/21459/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241001102810.479285-12-mzamazal@redhat.com>","date":"2024-10-01T10:28:03","name":"[v5,11/15] config: Look up pipelines match list in configuration file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ddec7aa676f3935d5e8650cbbb9b0679c26e083e","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21459/mbox/","series":[{"id":4644,"url":"https://patchwork.libcamera.org/api/series/4644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4644","date":"2024-10-01T10:27:52","name":"Add global configuration file","version":5,"mbox":"https://patchwork.libcamera.org/series/4644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21459/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21459/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83024C3263\n\tfor ;\n\tTue, 1 Oct 2024 10:28:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6F8C65365;\n\tTue, 1 Oct 2024 12:28:53 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C3126352A\n\tfor ;\n\tTue, 1 Oct 2024 12:28:42 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-5-hOokEfI2NVCkaE2yqxPaWg-1;\n\tTue, 01 Oct 2024 06:28:38 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 583411955D6A; Tue, 1 Oct 2024 10:28:37 +0000 (UTC)","from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 183C61944B22; Tue, 1 Oct 2024 10:28:35 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Tm0WWc8O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727778521;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=2QEIP670n2CWyKydLv3O4XCvB4LxNzpiJkfRVwY+40s=;\n\tb=Tm0WWc8O1fj2ocAZUMkuCwE6R0VvPZMml1aeougt7Gl/tbprkjPpWOMpCzD2Trez4Jt1rj\n\twEuAwBpUOt9wBLYQnGPYqL6lJSesZBuD17xTiYz+Rvh9dbtXpI8JYix2V/9nReptL9oTUM\n\tZ0p4yulSiEUtD+fZZKZq2atZHPZYYZ0=","X-MC-Unique":"hOokEfI2NVCkaE2yqxPaWg-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"[PATCH v5 11/15] config: Look up pipelines match list in\n\tconfiguration file","Date":"Tue, 1 Oct 2024 12:28:03 +0200","Message-ID":"<20241001102810.479285-12-mzamazal@redhat.com>","In-Reply-To":"<20241001102810.479285-1-mzamazal@redhat.com>","References":"<20241001102810.479285-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Milan Zamazal \n---\n src/libcamera/camera_manager.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 09f587765..41e0d8229 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -15,6 +15,7 @@\n \n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n@@ -108,14 +109,15 @@ void CameraManager::Private::createPipelineHandlers()\n \t * file and only fallback on environment variable or all handlers, if\n \t * there is no configuration file.\n \t */\n-\tconst char *pipesList =\n-\t\tutils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n-\tif (pipesList) {\n+\tstd::optional pipesList =\n+\t\tGlobalConfiguration::envOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n+\t\t\t\t\t \"pipelines_match_list\");\n+\tif (pipesList.has_value()) {\n \t\t/*\n \t\t * When a list of preferred pipelines is defined, iterate\n \t\t * through the ordered list to match the enumerated devices.\n \t\t */\n-\t\tfor (const auto &pipeName : utils::split(pipesList, \",\")) {\n+\t\tfor (const auto &pipeName : utils::split(pipesList.value(), \",\")) {\n \t\t\tconst PipelineHandlerFactoryBase *factory;\n \t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n \t\t\tif (!factory)\n","prefixes":["v5","11/15"]}