[{"id":32554,"web_url":"https://patchwork.libcamera.org/comment/32554/","msgid":"<20241205201622.GH21014@pendragon.ideasonboard.com>","date":"2024-12-05T20:16:22","subject":"Re: [PATCH v5 01/15] yaml: Include stdlib.h instead of cstdlib","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Tue, Oct 01, 2024 at 12:27:53PM +0200, Milan Zamazal wrote:\n> checkstyle.py will complain about cstdlib include, let's use stdlib.h instead.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/yaml_parser.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index 4784f2dc3..d0f3df5f3 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -7,10 +7,10 @@\n> \n> #include \"libcamera/internal/yaml_parser.h\"\n> \n> -#include \n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2561BDB1C\n\tfor ;\n\tThu, 5 Dec 2024 20:16:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 283D066116;\n\tThu, 5 Dec 2024 21:16:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 971736608C\n\tfor ;\n\tThu, 5 Dec 2024 21:16:35 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E9007E2;\n\tThu, 5 Dec 2024 21:16:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ns7m8fJE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733429765;\n\tbh=7Na60bU479QjqWvNn9ayj8ZJPoGJDeVSWKmDqfPHm0U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ns7m8fJEShy3F+PSb1Me1ieuGnlCM7dGGYrTyOwO+M82qJwUb53ZluACmjF3wQALp\n\tt6YNSlsp8BUgU/UWRXUIL/fp4/PiABBbkbwvoqJPkFQRS3OzQRmgdqdWpEDkFV7DrS\n\t0S5opS2GvbFrxF5fN2B70r0J87coXA0IqkfEJPm0=","Date":"Thu, 5 Dec 2024 22:16:22 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"Re: [PATCH v5 01/15] yaml: Include stdlib.h instead of cstdlib","Message-ID":"<20241205201622.GH21014@pendragon.ideasonboard.com>","References":"<20241001102810.479285-1-mzamazal@redhat.com>\n\t<20241001102810.479285-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241001102810.479285-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]