{"id":21442,"url":"https://patchwork.libcamera.org/api/patches/21442/?format=json","web_url":"https://patchwork.libcamera.org/patch/21442/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240930195915.152187-4-jacopo.mondi@ideasonboard.com>","date":"2024-09-30T19:59:11","name":"[v9,3/5] libcamera: controls: Add ControlTypePoint","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"61bb00deb8fd4505bf4e2eae7354ef2727268fae","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21442/mbox/","series":[{"id":4642,"url":"https://patchwork.libcamera.org/api/series/4642/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4642","date":"2024-09-30T19:59:08","name":"Add Face Detection Controls","version":9,"mbox":"https://patchwork.libcamera.org/series/4642/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21442/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21442/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1330AC3257\n\tfor ;\n\tMon, 30 Sep 2024 19:59:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D2046351F;\n\tMon, 30 Sep 2024 21:59:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACCBF63502\n\tfor ;\n\tMon, 30 Sep 2024 21:59:33 +0200 (CEST)","from ideasonboard.com (unknown [95.131.46.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEBB21DD2;\n\tMon, 30 Sep 2024 21:58:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o80mdWfE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727726282;\n\tbh=nbeI3zAkGJuCUOeTHhU5AUvOYT4Cs/rB4Rg4Fv0C1/M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o80mdWfEdGbuP+A0h6CtaUGIlmZ1rDn4RIX+u311bZQnXdzNfRgWtlQY0UXDgntdR\n\tkFwzSf8r8dIqJrqOKXayDZPrJSyZgHICsgAkI1n620KniNE3GBsbCYlOEK2f43QRMR\n\tpGgPhl3OTgNhhpesRLedCRy7mNiXdRspQpCr7Yzk=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tHarvey Yang ,\n\tYudhistira Erlandinata ,\n\tBecker Hsieh ,\n\tHarvey Yang ","Subject":"[PATCH v9 3/5] libcamera: controls: Add ControlTypePoint","Date":"Mon, 30 Sep 2024 21:59:11 +0200","Message-ID":"<20240930195915.152187-4-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.46.1","In-Reply-To":"<20240930195915.152187-1-jacopo.mondi@ideasonboard.com>","References":"<20240930195915.152187-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd a control_type<> specialization for libcamera::Point to allow\nstoring data of that type in a ControlValue instance.\n\nThe new control type will be used by controls introduced in the\nnext patches.\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: Becker Hsieh \nCo-developed-by: Harvey Yang \nReviewed-by: Jacopo Mondi \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/controls.h | 6 ++++++\n src/libcamera/controls.cpp | 6 ++++++\n 2 files changed, 12 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex c5131870d402..ca60bbacad17 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -35,6 +35,7 @@ enum ControlType {\n \tControlTypeString,\n \tControlTypeRectangle,\n \tControlTypeSize,\n+\tControlTypePoint,\n };\n \n namespace details {\n@@ -97,6 +98,11 @@ struct control_type {\n \tstatic constexpr std::size_t size = 0;\n };\n \n+template<>\n+struct control_type {\n+\tstatic constexpr ControlType value = ControlTypePoint;\n+};\n+\n template\n struct control_type> : public control_type> {\n \tstatic constexpr std::size_t size = N;\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex ea4397302a21..62185d643ecd 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -60,6 +60,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeString]\t\t= sizeof(char),\n \t[ControlTypeRectangle]\t\t= sizeof(Rectangle),\n \t[ControlTypeSize]\t\t= sizeof(Size),\n+\t[ControlTypePoint]\t\t= sizeof(Point),\n };\n \n } /* namespace */\n@@ -254,6 +255,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += value->toString();\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypePoint: {\n+\t\t\tconst Point *value = reinterpret_cast(data);\n+\t\t\tstr += value->toString();\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeNone:\n \t\tcase ControlTypeString:\n \t\t\tbreak;\n","prefixes":["v9","3/5"]}