[{"id":2827,"web_url":"https://patchwork.libcamera.org/comment/2827/","msgid":"<20191008085454.goiqze4tqhfsoqdn@uno.localdomain>","date":"2019-10-08T08:54:54","subject":"Re: [libcamera-devel] [PATCH v5 06/10] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n please note this will conflict with:\n\"[PATCH v4 3/5] ipa: meson: Give IPAs access to internal libcamera APIs\"\n\nin my ipa-test series.\n\nOn Tue, Oct 08, 2019 at 02:45:30AM +0200, Niklas Söderlund wrote:\n> Allow IPA implementations to use internal libcamera headers so they can\n> utilize helpers not exposed to applications.\n>\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index f09915bc13887bd3..10448c2ffc76af4b 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -8,7 +8,7 @@ ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> foreach t : ipa_dummy_sources\n> ipa = shared_module(t[0], 'ipa_dummy.cpp',\n> name_prefix : '',\n> - include_directories : libcamera_includes,\n> + include_directories : includes,\n\nI did something slightly different here, as 'includes' will also\ninclude 'include/android/' when compiling with android support. I'm\nnot sure this should be exposed to the IPAs.\n\nlet me know which one you think it's best, I'll take either yours in\nor keep mine.\n\nThe mentioned patchs also instructs to link IPAs against libcamera:\n\n---\n src/ipa/meson.build | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)\n\ndiff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex b5bcd7b2c3db..ac16e1da6126 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -5,10 +5,16 @@ ipa_vimc_sources = [\n\n ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n\n+ipa_includes = [\n+ libcamera_includes,\n+ libcamera_internal_includes,\n+]\n+\n foreach t : ipa_vimc_sources\n ipa = shared_module(t[0], 'ipa_vimc.cpp',\n name_prefix : '',\n- include_directories : libcamera_includes,\n+ include_directories : ipa_includes,\n+ dependencies : libcamera_dep,\n install : true,\n install_dir : ipa_install_dir,\n cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n--\n2.23.0\n\n\n> install : true,\n> install_dir : ipa_install_dir,\n> cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n> --\n> 2.23.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C35C60BC6\n\tfor ;\n\tTue, 8 Oct 2019 10:53:09 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 2890A200018;\n\tTue, 8 Oct 2019 08:53:08 +0000 (UTC)"],"Date":"Tue, 8 Oct 2019 10:54:54 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008085454.goiqze4tqhfsoqdn@uno.localdomain>","References":"<20191008004534.1585142-1-niklas.soderlund@ragnatech.se>\n\t<20191008004534.1585142-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ttqrb74fpdpr6cve\"","Content-Disposition":"inline","In-Reply-To":"<20191008004534.1585142-7-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v5 06/10] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 08:53:09 -0000"}}]