{"id":21434,"url":"https://patchwork.libcamera.org/api/patches/21434/?format=json","web_url":"https://patchwork.libcamera.org/patch/21434/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240930152039.72459-2-umang.jain@ideasonboard.com>","date":"2024-09-30T15:20:38","name":"[1/2] libcamera: pixel_format: Add isRaw() helper","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"f292eb463e90bd21edc195795b1617c2caace294","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21434/mbox/","series":[{"id":4640,"url":"https://patchwork.libcamera.org/api/series/4640/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4640","date":"2024-09-30T15:20:37","name":"libcamera: pixelformat: Add isRaw() helper","version":1,"mbox":"https://patchwork.libcamera.org/series/4640/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21434/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21434/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53626C3257\n\tfor ;\n\tMon, 30 Sep 2024 15:20:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBCD96351B;\n\tMon, 30 Sep 2024 17:20:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 007A363518\n\tfor ;\n\tMon, 30 Sep 2024 17:20:46 +0200 (CEST)","from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3E4932A;\n\tMon, 30 Sep 2024 17:19:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"srCWnVAk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727709555;\n\tbh=qktxQKMBuvhmkuSEABOIVjB0z+lsOLERssYxH3hA6nY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=srCWnVAkLL+iFIuqpvBVSBvwdh++UGstIvtnNv2+rA80JwrAbgONA8C6C8eWz+tQ5\n\tbzUBFfV1tscsdDhJwDel90EGsaraz3PQxfMVvxly2VEGVTpQQP/Ama2TTzKXSO6Wq3\n\tyT2O+Cxx6q8swY9D6+roAabSSVG0TPbTXIhLCLa0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ,\n\tJacopo Mondi ,\n\tKieran Bingham ,\n\tDaniel Scally ,\n\tUmang Jain ","Subject":"[PATCH 1/2] libcamera: pixel_format: Add isRaw() helper","Date":"Mon, 30 Sep 2024 20:50:38 +0530","Message-ID":"<20240930152039.72459-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240930152039.72459-1-umang.jain@ideasonboard.com>","References":"<20240930152039.72459-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a isRaw() helper to the PixelFormat class, to know whether the\npixel format has RAW encoding.\n\nThis will used by validation and configuration code paths in pipeline\nhandlers, to know whether a pixel format is a raw format or not.\n\nSigned-off-by: Umang Jain \n---\n include/libcamera/pixel_format.h | 1 +\n src/libcamera/pixel_format.cpp | 11 +++++++++++\n 2 files changed, 12 insertions(+)","diff":"diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\nindex 1b4d8c7c..aed53ea6 100644\n--- a/include/libcamera/pixel_format.h\n+++ b/include/libcamera/pixel_format.h\n@@ -37,6 +37,7 @@ public:\n \tconstexpr uint64_t modifier() const { return modifier_; }\n \n \tstd::string toString() const;\n+\tbool isRaw() const;\n \n \tstatic PixelFormat fromString(const std::string &name);\n \ndiff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\nindex 314179a8..436ef5fb 100644\n--- a/src/libcamera/pixel_format.cpp\n+++ b/src/libcamera/pixel_format.cpp\n@@ -100,6 +100,17 @@ bool PixelFormat::operator<(const PixelFormat &other) const\n * \\return DRM modifier\n */\n \n+/**\n+ * \\brief Checks if \\a this is a RAW pixel format\n+ * \\return True if \\a this is a RAW pixel format, false otherwise\n+ */\n+bool PixelFormat::isRaw() const\n+{\n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(*this);\n+\n+\treturn info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n /**\n * \\brief Assemble and return a string describing the pixel format\n * \\return A string describing the pixel format\n","prefixes":["1/2"]}