[{"id":31511,"web_url":"https://patchwork.libcamera.org/comment/31511/","msgid":"","date":"2024-10-01T18:25:07","subject":"Re: [PATCH v2 5/7] pipeline: rpi: Track which ISP output is\n\tconfigured for a stream","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Mon, Sep 30, 2024 at 03:14:13PM GMT, Naushir Patuck wrote:\n> Add a ispIndex field to CropParams that is used to track\n> which ISP output (0/1) will be used for a given stream during\n> configuration.\n>\n> Tracking this information is required for an upcoming change where crop\n> rectangles can be specified for each configured stream. Currently, the\n> value is fixed to 0.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 ++++--\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n> 2 files changed, 5 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index 75babbe17f31..9d23a1994f00 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -135,8 +135,8 @@ public:\n> \tIPACameraSensorInfo sensorInfo_;\n>\n> \tstruct CropParams {\n> -\t\tCropParams(Rectangle ispCrop_, Size ispMinCropSize_)\n> -\t\t\t: ispCrop(ispCrop_), ispMinCropSize(ispMinCropSize_)\n> +\t\tCropParams(Rectangle ispCrop_, Size ispMinCropSize_, unsigned int ispIndex_)\n> +\t\t\t: ispCrop(ispCrop_), ispMinCropSize(ispMinCropSize_), ispIndex(ispIndex_)\n> \t\t{\n> \t\t}\n>\n> @@ -148,6 +148,8 @@ public:\n> \t\tRectangle ispCrop;\n> \t\t/* Minimum crop size in ISP output pixels */\n> \t\tSize ispMinCropSize;\n> +\t\t/* Index of the ISP output channel for this crop */\n> +\t\tunsigned int ispIndex;\n> \t};\n>\n> \t/* Mapping of CropParams keyed by the output stream order in CameraConfiguration */\n> diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> index 8080f55a1cf4..cfed214ddbd4 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> +++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> @@ -714,7 +714,7 @@ int Vc4CameraData::platformConfigure(const RPi::RPiCameraConfiguration *rpiConfi\n> \t */\n> \tcropParams_.emplace(std::piecewise_construct,\n> \t\t\t std::forward_as_tuple(0),\n> -\t\t\t std::forward_as_tuple(ispCrop, testCrop.size()));\n> +\t\t\t std::forward_as_tuple(ispCrop, testCrop.size(), 0));\n>\n> \treturn 0;\n> }\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B55D7BD80A\n\tfor ;\n\tTue, 1 Oct 2024 18:25:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9222660553;\n\tTue, 1 Oct 2024 20:25:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 278D860553\n\tfor ;\n\tTue, 1 Oct 2024 20:25:12 +0200 (CEST)","from ideasonboard.com (unknown [5.77.89.72])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9140A1A;\n\tTue, 1 Oct 2024 20:23:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mC5+vPYs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727807020;\n\tbh=m0JjkiaRrq9IebjpNV8MmT0nLB5mpcyZ3yxIVEdHa4Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mC5+vPYsKeIpkfFBNTyq6MjYjce2iOMjSoWmPft/99PFVpU5JBXHkHix0nr+Nv9AR\n\tH7NlMcUtPED+VM8K9gXLiVaB5OFZLon1BZOBXVBfdSqpt9fuZWiSuthQ2XOCQcoWpW\n\tVvrwmhZLF8fAXVIaOjqILAovrX1lY4wEcfvDcQ38=","Date":"Tue, 1 Oct 2024 20:25:07 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org, \n\tLaurent Pinchart ","Subject":"Re: [PATCH v2 5/7] pipeline: rpi: Track which ISP output is\n\tconfigured for a stream","Message-ID":"","References":"<20240930141415.8857-1-naush@raspberrypi.com>\n\t<20240930141415.8857-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240930141415.8857-6-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]