[{"id":31470,"web_url":"https://patchwork.libcamera.org/comment/31470/","msgid":"<CAHW6GYK0WaSPHCF+_wc537fe8wtLSoMEOB46GTESU0auwXBufA@mail.gmail.com>","date":"2024-09-30T15:02:42","subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this. Looks sensible!\n\nOn Mon, 30 Sept 2024 at 09:40, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> A default CT of 4500K is used in a couple of places. Add a constexpr\n> value for the default CT value and use it instead.\n>\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n\nThanks!\nDavid\n\n> ---\n>  src/ipa/rpi/controller/rpi/awb.cpp | 6 ++++--\n>  1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> index f45525bce2d1..24f296fc66fa 100644\n> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> @@ -20,6 +20,8 @@ using namespace libcamera;\n>\n>  LOG_DEFINE_CATEGORY(RPiAwb)\n>\n> +constexpr double DefaultCT = 4500.0;\n> +\n>  #define NAME \"rpi.awb\"\n>\n>  /*\n> @@ -214,7 +216,7 @@ void Awb::initialise()\n>                 syncResults_.gainB = 1.0 / config_.ctB.eval(syncResults_.temperatureK);\n>         } else {\n>                 /* random values just to stop the world blowing up */\n> -               syncResults_.temperatureK = 4500;\n> +               syncResults_.temperatureK = DefaultCT;\n>                 syncResults_.gainR = syncResults_.gainG = syncResults_.gainB = 1.0;\n>         }\n>         prevSyncResults_ = syncResults_;\n> @@ -716,7 +718,7 @@ void Awb::awbGrey()\n>                 sumR += *ri, sumB += *bi;\n>         double gainR = sumR.G / (sumR.R + 1),\n>                gainB = sumB.G / (sumB.B + 1);\n> -       asyncResults_.temperatureK = 4500; /* don't know what it is */\n> +       asyncResults_.temperatureK = DefaultCT; /* don't know what it is */\n>         asyncResults_.gainR = gainR;\n>         asyncResults_.gainG = 1.0;\n>         asyncResults_.gainB = gainB;\n> --\n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC613C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Sep 2024 15:02:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAE9B63512;\n\tMon, 30 Sep 2024 17:02:58 +0200 (CEST)","from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com\n\t[IPv6:2607:f8b0:4864:20::f30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CE5B63502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 17:02:56 +0200 (CEST)","by mail-qv1-xf30.google.com with SMTP id\n\t6a1803df08f44-6cb4c013b78so19491866d6.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 08:02:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KJqU0sxI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1727708575; x=1728313375;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=UBNZt9RATAJrIIcFGUsC00jPnmZMSbQBRXcf/MsM1ss=;\n\tb=KJqU0sxIWkl2PLId4YPcVTPTELEfwsFxJo3oNZVlmQS30IuQKE647XtpIXuklIrTc4\n\tMXaRON6EXVnZ1zHTE2JZyHmjG8WGCyEoHhDqMM/V6vGrs6SUabosBnN9xgJHD10jple6\n\tejbmIzuSHGUT6/S3VAcw/ZR4EF0rARErXOWLwy+k7+pSx4UgSp9/uOA36xanfGX+bjoh\n\t+dpyNiyp2jw+Q1Qm6JAyOa5ypvI9oFon10DYbMnTyjyM8E9KLeRkrDvXJfMBGB1xfeIm\n\tXK1WRdB0dv/3+j09IyWNREulHgC0w364BBp4QOXHYsdc+rahsnJihCDPfqvBmCXqFY5i\n\t8bcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727708575; x=1728313375;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=UBNZt9RATAJrIIcFGUsC00jPnmZMSbQBRXcf/MsM1ss=;\n\tb=LFgAThXBY9lCpF5d1SIg2JZOYBY21WUL8Hyroue2vEBHb7ZU5vRY6Ej3IwZlZieTgT\n\ts07IeXjU+8rvNQmhXISiL1uFPYSmFfZsX5+Ne59BEpPxUzd3fZiI1xkxWPLmJAy7FF7l\n\toBqKBhIQghpsPFK68Gwx/+j/Ia0QA/krNeNo4h7KlwaiCveG4RJ914TdkIkMCQSNk9l/\n\tNkSU8kwwM7evDrrRTXyATM+6ZmcLboX98s87vaqf3IvPwgc0YVBlKyNKQCWtftzDeA0/\n\tBdAZd0UtCIxE3alum2EH8b0q0nxfyYQIe71cqfvFC41XlSfcfi9dEjE+x5dT+RWtfX3P\n\tYyWA==","X-Gm-Message-State":"AOJu0YwKqguoPLht2HdP+fOLFGbSyCiL8WKYnf1RlHpo0peULW+XTjQ3\n\tI2/5UQrisQl28e7EbCFsh8hZFvyVh2N6sFkse7koEAzJn1Gk45dbt+EG28rWC3Ze7ABw3V6Tp2A\n\tUvF/RTfhiejj/NCuAIU534sJ5wRq0LF0LFNeci56mWkaaJQ7/","X-Google-Smtp-Source":"AGHT+IEb9pxZdRxkEsKFNPJKv10rXXh09huDrexitAhp+kLhVdEX8OjEd/hv/hsgdN3pDzFSvmqL2N2XskrG8mxrkZw=","X-Received":"by 2002:a05:6214:5c42:b0:6cb:4b8b:344b with SMTP id\n\t6a1803df08f44-6cb4b8b368amr113635476d6.46.1727708573927;\n\tMon, 30 Sep 2024 08:02:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20240930084040.2919-1-naush@raspberrypi.com>\n\t<20240930084040.2919-2-naush@raspberrypi.com>","In-Reply-To":"<20240930084040.2919-2-naush@raspberrypi.com>","From":"David Plowman <david.plowman@raspberrypi.com>","Date":"Mon, 30 Sep 2024 16:02:42 +0100","Message-ID":"<CAHW6GYK0WaSPHCF+_wc537fe8wtLSoMEOB46GTESU0auwXBufA@mail.gmail.com>","Subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31472,"web_url":"https://patchwork.libcamera.org/comment/31472/","msgid":"<20240930152014.GJ31662@pendragon.ideasonboard.com>","date":"2024-09-30T15:20:14","subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Sep 30, 2024 at 09:40:39AM +0100, Naushir Patuck wrote:\n> A default CT of 4500K is used in a couple of places. Add a constexpr\n> value for the default CT value and use it instead.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> ---\n>  src/ipa/rpi/controller/rpi/awb.cpp | 6 ++++--\n>  1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> index f45525bce2d1..24f296fc66fa 100644\n> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> @@ -20,6 +20,8 @@ using namespace libcamera;\n>  \n>  LOG_DEFINE_CATEGORY(RPiAwb)\n>  \n> +constexpr double DefaultCT = 4500.0;\n\ns/DefaultCT/kDefaultCT/\n\n> +\n>  #define NAME \"rpi.awb\"\n>  \n>  /*\n> @@ -214,7 +216,7 @@ void Awb::initialise()\n>  \t\tsyncResults_.gainB = 1.0 / config_.ctB.eval(syncResults_.temperatureK);\n>  \t} else {\n>  \t\t/* random values just to stop the world blowing up */\n> -\t\tsyncResults_.temperatureK = 4500;\n> +\t\tsyncResults_.temperatureK = DefaultCT;\n>  \t\tsyncResults_.gainR = syncResults_.gainG = syncResults_.gainB = 1.0;\n>  \t}\n>  \tprevSyncResults_ = syncResults_;\n> @@ -716,7 +718,7 @@ void Awb::awbGrey()\n>  \t\tsumR += *ri, sumB += *bi;\n>  \tdouble gainR = sumR.G / (sumR.R + 1),\n>  \t       gainB = sumB.G / (sumB.B + 1);\n> -\tasyncResults_.temperatureK = 4500; /* don't know what it is */\n> +\tasyncResults_.temperatureK = DefaultCT; /* don't know what it is */\n\n\"don't know what it is\" sounds like the person who wrote the code\ndoesn't know what it does :-)\n\nDo I understand correctly that with the grey world model you can't\nestimate the colour temperature ? If so, while at it, I'd write\n\n\t/*\n\t * The grey world model can't estimate the colour temperature, use a\n\t * default value.\n\t */\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>  \tasyncResults_.gainR = gainR;\n>  \tasyncResults_.gainG = 1.0;\n>  \tasyncResults_.gainB = gainB;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AED23C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Sep 2024 15:20:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3F3C63512;\n\tMon, 30 Sep 2024 17:20:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C37463502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 17:20:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 265C6280;\n\tMon, 30 Sep 2024 17:18:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ti1eOxJH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727709526;\n\tbh=K2Tte8lC6rG2AnN4l0sCF1Lyvg+GbsW1QnAg/tBV9JQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ti1eOxJHwKZcdzzTDahYq+4bjjuT00qoh451mUUuOXuT9jJOULdC7qfeM7fAF5l9P\n\ts2YDdP4+FGPySqPsJjjDBdVbkqXuOrzHAimtomz0xS3mniycspS0a07QqfT/bIOSbt\n\tShQ/f5R0dx+tPyO6ZRqF/pitJb9oYMYHHRWzhvtg=","Date":"Mon, 30 Sep 2024 18:20:14 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","Message-ID":"<20240930152014.GJ31662@pendragon.ideasonboard.com>","References":"<20240930084040.2919-1-naush@raspberrypi.com>\n\t<20240930084040.2919-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240930084040.2919-2-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31491,"web_url":"https://patchwork.libcamera.org/comment/31491/","msgid":"<CAEmqJPoGP1-F06bKOd9+0MpkYfc7=4vEd19XteR98JOuDW0Rww@mail.gmail.com>","date":"2024-10-01T08:46:30","subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for the feedback.\n\nOn Mon, 30 Sept 2024 at 16:20, Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Mon, Sep 30, 2024 at 09:40:39AM +0100, Naushir Patuck wrote:\n> > A default CT of 4500K is used in a couple of places. Add a constexpr\n> > value for the default CT value and use it instead.\n> >\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > ---\n> >  src/ipa/rpi/controller/rpi/awb.cpp | 6 ++++--\n> >  1 file changed, 4 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> > index f45525bce2d1..24f296fc66fa 100644\n> > --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> > +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> > @@ -20,6 +20,8 @@ using namespace libcamera;\n> >\n> >  LOG_DEFINE_CATEGORY(RPiAwb)\n> >\n> > +constexpr double DefaultCT = 4500.0;\n>\n> s/DefaultCT/kDefaultCT/\n\nI'd prefer to keep it as-is because it's consistent with the rest of\nthe algorithm code in RPi land.\n\n>\n> > +\n> >  #define NAME \"rpi.awb\"\n> >\n> >  /*\n> > @@ -214,7 +216,7 @@ void Awb::initialise()\n> >               syncResults_.gainB = 1.0 / config_.ctB.eval(syncResults_.temperatureK);\n> >       } else {\n> >               /* random values just to stop the world blowing up */\n> > -             syncResults_.temperatureK = 4500;\n> > +             syncResults_.temperatureK = DefaultCT;\n> >               syncResults_.gainR = syncResults_.gainG = syncResults_.gainB = 1.0;\n> >       }\n> >       prevSyncResults_ = syncResults_;\n> > @@ -716,7 +718,7 @@ void Awb::awbGrey()\n> >               sumR += *ri, sumB += *bi;\n> >       double gainR = sumR.G / (sumR.R + 1),\n> >              gainB = sumB.G / (sumB.B + 1);\n> > -     asyncResults_.temperatureK = 4500; /* don't know what it is */\n> > +     asyncResults_.temperatureK = DefaultCT; /* don't know what it is */\n>\n> \"don't know what it is\" sounds like the person who wrote the code\n> doesn't know what it does :-)\n\nHmmm, I really should remove that comment!\n\n>\n> Do I understand correctly that with the grey world model you can't\n> estimate the colour temperature ? If so, while at it, I'd write\n>\n>         /*\n>          * The grey world model can't estimate the colour temperature, use a\n>          * default value.\n>          */\n>\n\nAck, I'll do that.\n\nNaush\n\n\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> >       asyncResults_.gainR = gainR;\n> >       asyncResults_.gainG = 1.0;\n> >       asyncResults_.gainB = gainB;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34B0EBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Oct 2024 08:47:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5F1463512;\n\tTue,  1 Oct 2024 10:47:01 +0200 (CEST)","from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com\n\t[IPv6:2607:f8b0:4864:20::b2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 648A560553\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Oct 2024 10:47:00 +0200 (CEST)","by mail-yb1-xb2a.google.com with SMTP id\n\t3f1490d57ef6-e0bd34b58d3so734995276.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 01 Oct 2024 01:47:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"tudY+rff\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1727772419; x=1728377219;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DdzzBTIl6QQ36bVcDGxpMXPCSyQQXZ2CybjDq1MLdwY=;\n\tb=tudY+rff3I0FWlPLoF6c2qigiHU2IEs0jngNcKUbzYBPI3c3hb/yn92vbX75CUmC6t\n\tlGwXr4xycR3B31Kx1AOLcNjG5ILqdR03L3F2ae/FKYB/Si4L0m73DTwBfaacLRZ7USEB\n\tI4992pIofcknb6XpJChCziZxVITW2gxkU8neHxwSWjdM0nRw2Xrm5KgZh1GJZn4T5vjU\n\tjAuLI+3vmQ10gobkGkjfqvBdzdGJyaPi9lUA/f1wb9Rz9UvT/msVft8MO1kgqJpYAh+L\n\t8YdK0ekhA/u8whvsfeR4v5JbIyb4GnLiL8+wu4jEXdlSForsULs+SPz4hkkUZS2MSi9Q\n\tPV4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727772419; x=1728377219;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=DdzzBTIl6QQ36bVcDGxpMXPCSyQQXZ2CybjDq1MLdwY=;\n\tb=tn4XRBoWy3G9TFUipxIrrv2vVr2fMT7N2XYbVb7oCL70NWhAo3qRBTDHhZ+1tIgE9F\n\tasg0U0VG45D6WaAT4/l2mInFTQwwOuBBqS4j8cAvEaVc9RAGn9Xd/TjIn1FzAM5wi0on\n\ti97QBhhgZAB6DKFCATI82swG/bi4qdzqcwV7Jznp+jGyV+bImBAcvy+FCTLThhWZ1t/x\n\tJUBLqyip0pk+uZwp4sbbWUSXQpLNI3pSUhyuXxHow8WebFvtE6RxOLp8yKvFRRUvXWln\n\t6DCNeo5lCUWMZSXPKeh6GturSuXIl6dEHCWak17SiN0twH25ZehvoP52kXjVo/TE1wKY\n\tqeYg==","X-Gm-Message-State":"AOJu0YwZuIfwFiEM2dtqSz+0vcDBIGUr7NW43y+VPFowEwGPT/oBc0de\n\t9Dbg1JBvk0HxUZZ/GQzf4QfIzKnRdvcEmDqXQH/BuvWiI17dJ9PeT+XwXUfNiHhjg9n1EzseuJm\n\tYy4D8IHVvprNFDngUesvOdzkWh/KsNgEA1BagMg==","X-Google-Smtp-Source":"AGHT+IH6c4pTT99DmAQdVGnNju16+18ffdzYILtu0P175jL3JgKkz+CGq+FoN65D8Ye7E+5182W0rZ7NHaLp0GO+OZI=","X-Received":"by 2002:a05:690c:89:b0:6d3:c6e:1aea with SMTP id\n\t00721157ae682-6e258e4249emr35114357b3.10.1727772419289;\n\tTue, 01 Oct 2024 01:46:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20240930084040.2919-1-naush@raspberrypi.com>\n\t<20240930084040.2919-2-naush@raspberrypi.com>\n\t<20240930152014.GJ31662@pendragon.ideasonboard.com>","In-Reply-To":"<20240930152014.GJ31662@pendragon.ideasonboard.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Tue, 1 Oct 2024 09:46:30 +0100","Message-ID":"<CAEmqJPoGP1-F06bKOd9+0MpkYfc7=4vEd19XteR98JOuDW0Rww@mail.gmail.com>","Subject":"Re: [PATCH 1/2] ipa: rpi: awb: Add a const for the default colour\n\ttemperature","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]