{"id":21404,"url":"https://patchwork.libcamera.org/api/patches/21404/?format=json","web_url":"https://patchwork.libcamera.org/patch/21404/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240927134624.801004-12-mzamazal@redhat.com>","date":"2024-09-27T13:46:17","name":"[v8,11/18] libcamera: software_isp: Call Algorithm::prepare","commit_ref":"2dc696be219e3d337ac335217f9dbad5f6822554","pull_url":null,"state":"accepted","archived":false,"hash":"b5083a496ce110b6caebf695369c32db82bf7a8e","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21404/mbox/","series":[{"id":4634,"url":"https://patchwork.libcamera.org/api/series/4634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4634","date":"2024-09-27T13:46:06","name":"Software ISP refactoring","version":8,"mbox":"https://patchwork.libcamera.org/series/4634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21404/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21404/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 189FDC3257\n\tfor ;\n\tFri, 27 Sep 2024 13:47:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE1E763533;\n\tFri, 27 Sep 2024 15:47:09 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 958C863517\n\tfor ;\n\tFri, 27 Sep 2024 15:47:04 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-645-kn8SllOtMxmOM-seKmVcQQ-1;\n\tFri, 27 Sep 2024 09:46:59 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8277A18F3607; Fri, 27 Sep 2024 13:46:58 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.123])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8B6D21956054; Fri, 27 Sep 2024 13:46:56 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"P6X7h8dC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727444823;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=bnqls9g7Q36b9f/sBHWAWxCjPn+WVYFcEqKuYi1wsqE=;\n\tb=P6X7h8dChKb0rA/iGwVJyv720PN11blIa6E8tyf56spm488Dim+gp5d2fv4TK+71+Wdu6D\n\t5peqlIK/u0smvT+xV7rXqZ9BCTUiyfLj0Pd1KijNDu+z98d1gD+APvtYQTF6K6k7nuce9l\n\t8eAWopEOOmQIgVDUmQ0pnsCrvtXvE6A=","X-MC-Unique":"kn8SllOtMxmOM-seKmVcQQ-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ,\n\tLaurent Pinchart ,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"[PATCH v8 11/18] libcamera: software_isp: Call Algorithm::prepare","Date":"Fri, 27 Sep 2024 15:46:17 +0200","Message-ID":"<20240927134624.801004-12-mzamazal@redhat.com>","In-Reply-To":"<20240927134624.801004-1-mzamazal@redhat.com>","References":"<20240927134624.801004-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch adds Algorithm::prepare call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nReviewed-by: Daniel Scally \nReviewed-by: Kieran Bingham \n---\n include/libcamera/ipa/soft.mojom | 1 +\n src/ipa/simple/soft_simple.cpp | 8 ++++++++\n src/libcamera/software_isp/software_isp.cpp | 1 +\n 3 files changed, 10 insertions(+)","diff":"diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex ddccd154d..347fd69b4 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -24,6 +24,7 @@ interface IPASoftInterface {\n \t\t=> (int32 ret);\n \n \t[async] queueRequest(uint32 frame, libcamera.ControlList sensorControls);\n+\t[async] fillParamsBuffer(uint32 frame);\n \t[async] processStats(uint32 frame,\n \t\t\t uint32 bufferId,\n \t\t\t libcamera.ControlList sensorControls);\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex eb3bbd920..3a0cb6e0a 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -79,6 +79,7 @@ public:\n \tvoid stop() override;\n \n \tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n+\tvoid fillParamsBuffer(const uint32_t frame) override;\n \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n \t\t\t const ControlList &sensorControls) override;\n \n@@ -279,6 +280,13 @@ void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &contro\n \t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n+void IPASoftSimple::fillParamsBuffer(const uint32_t frame)\n+{\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->prepare(context_, frame, frameContext, params_);\n+}\n+\n void IPASoftSimple::processStats([[maybe_unused]] const uint32_t frame,\n \t\t\t\t [[maybe_unused]] const uint32_t bufferId,\n \t\t\t\t const ControlList &sensorControls)\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 3a01bdccc..47677784d 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -351,6 +351,7 @@ void SoftwareIsp::stop()\n */\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n+\tipa_->fillParamsBuffer(frame);\n \tdebayer_->invokeMethod(&DebayerCpu::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n","prefixes":["v8","11/18"]}