[{"id":31396,"web_url":"https://patchwork.libcamera.org/comment/31396/","msgid":"<172734685001.3726802.14810565256898667299@ping.linuxembedded.co.uk>","date":"2024-09-26T10:34:10","subject":"Re: [PATCH 1/2] ipa: rpi: Replace last users of math.c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"in $SUBJECT s/math.c/math.h/\n\nQuoting Laurent Pinchart (2024-09-26 11:06:39)\n> As described in the coding style document, libcamera favours \n> over . Replace the last few occurrences of the latter with the\n> former in the Raspberry Pi IPA and adapt the code accordingly. In some\n> cases, the include is simply dropped as it isn't needed.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx283.cpp | 2 +-\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 6 +++---\n> src/ipa/rpi/controller/histogram.cpp | 6 +++---\n> src/ipa/rpi/controller/rpi/af.cpp | 2 +-\n> src/ipa/rpi/controller/rpi/black_level.cpp | 1 -\n> src/ipa/rpi/controller/rpi/lux.cpp | 1 -\n> src/ipa/rpi/controller/rpi/noise.cpp | 4 ++--\n> src/ipa/rpi/controller/rpi/sharpen.cpp | 4 ++--\n> 8 files changed, 12 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> index 1fd4d7f31b04..cb0be72a0aa7 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> @@ -8,7 +8,7 @@\n> #include \n> \n> #include \"cam_helper.h\"\n> -#include \"math.h\"\n> +\n> using namespace RPiController;\n> \n> class CamHelperImx283 : public CamHelper\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index 24275e121836..e57ab5381c31 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -5,7 +5,7 @@\n> * camera helper for imx290 sensor\n> */\n> \n> -#include \n> +#include \n> \n> #include \"cam_helper.h\"\n> \n> @@ -37,13 +37,13 @@ CamHelperImx290::CamHelperImx290()\n> \n> uint32_t CamHelperImx290::gainCode(double gain) const\n> {\n> - int code = 66.6667 * log10(gain);\n> + int code = 66.6667 * std::log10(gain);\n> return std::max(0, std::min(code, 0xf0));\n> }\n> \n> double CamHelperImx290::gain(uint32_t gainCode) const\n> {\n> - return pow(10, 0.015 * gainCode);\n> + return std::pow(10, 0.015 * gainCode);\n> }\n> \n> void CamHelperImx290::getDelays(int &exposureDelay, int &gainDelay,\n> diff --git a/src/ipa/rpi/controller/histogram.cpp b/src/ipa/rpi/controller/histogram.cpp\n> index ba5b25dd9b36..130898397d3c 100644\n> --- a/src/ipa/rpi/controller/histogram.cpp\n> +++ b/src/ipa/rpi/controller/histogram.cpp\n> @@ -4,7 +4,7 @@\n> *\n> * histogram calculations\n> */\n> -#include \n> +#include \n> #include \n> \n> #include \"histogram.h\"\n> @@ -49,9 +49,9 @@ double Histogram::interBinMean(double binLo, double binHi) const\n> {\n> assert(binHi >= binLo);\n> double sumBinFreq = 0, cumulFreq = 0;\n> - for (double binNext = floor(binLo) + 1.0; binNext <= ceil(binHi);\n> + for (double binNext = std::floor(binLo) + 1.0; binNext <= std::ceil(binHi);\n> binLo = binNext, binNext += 1.0) {\n> - int bin = floor(binLo);\n> + int bin = std::floor(binLo);\n> double freq = (cumulative_[bin + 1] - cumulative_[bin]) *\n> (std::min(binNext, binHi) - binLo);\n> sumBinFreq += bin * freq;\n> diff --git a/src/ipa/rpi/controller/rpi/af.cpp b/src/ipa/rpi/controller/rpi/af.cpp\n> index 5ca76dd98b4b..2157eb94f427 100644\n> --- a/src/ipa/rpi/controller/rpi/af.cpp\n> +++ b/src/ipa/rpi/controller/rpi/af.cpp\n> @@ -7,8 +7,8 @@\n> \n> #include \"af.h\"\n> \n> +#include \n> #include \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/ipa/rpi/controller/rpi/black_level.cpp b/src/ipa/rpi/controller/rpi/black_level.cpp\n> index ea991df9f60d..4c968f14a1ca 100644\n> --- a/src/ipa/rpi/controller/rpi/black_level.cpp\n> +++ b/src/ipa/rpi/controller/rpi/black_level.cpp\n> @@ -5,7 +5,6 @@\n> * black level control algorithm\n> */\n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/ipa/rpi/controller/rpi/lux.cpp b/src/ipa/rpi/controller/rpi/lux.cpp\n> index 7b31faab472f..652d85d7e22f 100644\n> --- a/src/ipa/rpi/controller/rpi/lux.cpp\n> +++ b/src/ipa/rpi/controller/rpi/lux.cpp\n> @@ -4,7 +4,6 @@\n> *\n> * Lux control algorithm\n> */\n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/rpi/controller/rpi/noise.cpp b/src/ipa/rpi/controller/rpi/noise.cpp\n> index 3f1c62cf1508..145175fb4940 100644\n> --- a/src/ipa/rpi/controller/rpi/noise.cpp\n> +++ b/src/ipa/rpi/controller/rpi/noise.cpp\n> @@ -5,7 +5,7 @@\n> * Noise control algorithm\n> */\n> \n> -#include \n> +#include \n> \n> #include \n> \n> @@ -69,7 +69,7 @@ void Noise::prepare(Metadata *imageMetadata)\n> * make some adjustments based on the camera mode (such as\n> * binning), if we knew how to discover it...\n> */\n> - double factor = sqrt(deviceStatus.analogueGain) / modeFactor_;\n> + double factor = std::sqrt(deviceStatus.analogueGain) / modeFactor_;\n> struct NoiseStatus status;\n> status.noiseConstant = referenceConstant_ * factor;\n> status.noiseSlope = referenceSlope_ * factor;\n> diff --git a/src/ipa/rpi/controller/rpi/sharpen.cpp b/src/ipa/rpi/controller/rpi/sharpen.cpp\n> index 39537f4aaf0a..1d143ff53287 100644\n> --- a/src/ipa/rpi/controller/rpi/sharpen.cpp\n> +++ b/src/ipa/rpi/controller/rpi/sharpen.cpp\n> @@ -5,7 +5,7 @@\n> * sharpening control algorithm\n> */\n> \n> -#include \n> +#include \n> \n> #include \n> \n> @@ -68,7 +68,7 @@ void Sharpen::prepare(Metadata *imageMetadata)\n> * we adjust the limit and threshold less aggressively. Using a sqrt\n> * function is an arbitrary but gentle way of accomplishing this.\n> */\n> - double userStrengthSqrt = sqrt(userStrength_);\n> + double userStrengthSqrt = std::sqrt(userStrength_);\n> struct SharpenStatus status;\n> /*\n> * Binned modes seem to need the sharpening toned down with this\n> \n> base-commit: f2088eb91fd6477b152233b9031cb115ca1ae824\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55CD0C0F1B\n\tfor ;\n\tThu, 26 Sep 2024 10:34:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6452263510;\n\tThu, 26 Sep 2024 12:34:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B452D63502\n\tfor ;\n\tThu, 26 Sep 2024 12:34:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BE65169;\n\tThu, 26 Sep 2024 12:32:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Uvyk1DjV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727346764;\n\tbh=kdPscNifo2AIzOj8bItdWpAmJuji8KYZsJep3/SDOrw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Uvyk1DjV0AeAoXH72z3jLQeuccFaZS7vFLj2DyEog05IzbwQolnXfl8AUC0lKWkX9\n\t/HnYrDx+JH16zacHiYLqabFNQqzYzKfDVq0X1wmsr2MlRCCTGHt/kxBWCPx1PD43Y2\n\t8c4kCB58Ghvw6QutXu+MZlMWDO0vwxaYjEcjV01M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240926100640.3504-1-laurent.pinchart@ideasonboard.com>","References":"<20240926100640.3504-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/2] ipa: rpi: Replace last users of math.c","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tDavid Plowman ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 26 Sep 2024 11:34:10 +0100","Message-ID":"<172734685001.3726802.14810565256898667299@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31460,"web_url":"https://patchwork.libcamera.org/comment/31460/","msgid":"","date":"2024-09-30T07:33:59","subject":"Re: [PATCH 1/2] ipa: rpi: Replace last users of math.c","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThanks for the fixes.\n\nOn Thu, 26 Sept 2024 at 11:06, Laurent Pinchart\n wrote:\n>\n> As described in the coding style document, libcamera favours \n> over . Replace the last few occurrences of the latter with the\n> former in the Raspberry Pi IPA and adapt the code accordingly. In some\n> cases, the include is simply dropped as it isn't needed.\n>\n> Signed-off-by: Laurent Pinchart \n\nHaven't tested this, but all looks reasonable to me\n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx283.cpp | 2 +-\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 6 +++---\n> src/ipa/rpi/controller/histogram.cpp | 6 +++---\n> src/ipa/rpi/controller/rpi/af.cpp | 2 +-\n> src/ipa/rpi/controller/rpi/black_level.cpp | 1 -\n> src/ipa/rpi/controller/rpi/lux.cpp | 1 -\n> src/ipa/rpi/controller/rpi/noise.cpp | 4 ++--\n> src/ipa/rpi/controller/rpi/sharpen.cpp | 4 ++--\n> 8 files changed, 12 insertions(+), 14 deletions(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> index 1fd4d7f31b04..cb0be72a0aa7 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx283.cpp\n> @@ -8,7 +8,7 @@\n> #include \n>\n> #include \"cam_helper.h\"\n> -#include \"math.h\"\n> +\n> using namespace RPiController;\n>\n> class CamHelperImx283 : public CamHelper\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index 24275e121836..e57ab5381c31 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -5,7 +5,7 @@\n> * camera helper for imx290 sensor\n> */\n>\n> -#include \n> +#include \n>\n> #include \"cam_helper.h\"\n>\n> @@ -37,13 +37,13 @@ CamHelperImx290::CamHelperImx290()\n>\n> uint32_t CamHelperImx290::gainCode(double gain) const\n> {\n> - int code = 66.6667 * log10(gain);\n> + int code = 66.6667 * std::log10(gain);\n> return std::max(0, std::min(code, 0xf0));\n> }\n>\n> double CamHelperImx290::gain(uint32_t gainCode) const\n> {\n> - return pow(10, 0.015 * gainCode);\n> + return std::pow(10, 0.015 * gainCode);\n> }\n>\n> void CamHelperImx290::getDelays(int &exposureDelay, int &gainDelay,\n> diff --git a/src/ipa/rpi/controller/histogram.cpp b/src/ipa/rpi/controller/histogram.cpp\n> index ba5b25dd9b36..130898397d3c 100644\n> --- a/src/ipa/rpi/controller/histogram.cpp\n> +++ b/src/ipa/rpi/controller/histogram.cpp\n> @@ -4,7 +4,7 @@\n> *\n> * histogram calculations\n> */\n> -#include \n> +#include \n> #include \n>\n> #include \"histogram.h\"\n> @@ -49,9 +49,9 @@ double Histogram::interBinMean(double binLo, double binHi) const\n> {\n> assert(binHi >= binLo);\n> double sumBinFreq = 0, cumulFreq = 0;\n> - for (double binNext = floor(binLo) + 1.0; binNext <= ceil(binHi);\n> + for (double binNext = std::floor(binLo) + 1.0; binNext <= std::ceil(binHi);\n> binLo = binNext, binNext += 1.0) {\n> - int bin = floor(binLo);\n> + int bin = std::floor(binLo);\n> double freq = (cumulative_[bin + 1] - cumulative_[bin]) *\n> (std::min(binNext, binHi) - binLo);\n> sumBinFreq += bin * freq;\n> diff --git a/src/ipa/rpi/controller/rpi/af.cpp b/src/ipa/rpi/controller/rpi/af.cpp\n> index 5ca76dd98b4b..2157eb94f427 100644\n> --- a/src/ipa/rpi/controller/rpi/af.cpp\n> +++ b/src/ipa/rpi/controller/rpi/af.cpp\n> @@ -7,8 +7,8 @@\n>\n> #include \"af.h\"\n>\n> +#include \n> #include \n> -#include \n> #include \n>\n> #include \n> diff --git a/src/ipa/rpi/controller/rpi/black_level.cpp b/src/ipa/rpi/controller/rpi/black_level.cpp\n> index ea991df9f60d..4c968f14a1ca 100644\n> --- a/src/ipa/rpi/controller/rpi/black_level.cpp\n> +++ b/src/ipa/rpi/controller/rpi/black_level.cpp\n> @@ -5,7 +5,6 @@\n> * black level control algorithm\n> */\n>\n> -#include \n> #include \n>\n> #include \n> diff --git a/src/ipa/rpi/controller/rpi/lux.cpp b/src/ipa/rpi/controller/rpi/lux.cpp\n> index 7b31faab472f..652d85d7e22f 100644\n> --- a/src/ipa/rpi/controller/rpi/lux.cpp\n> +++ b/src/ipa/rpi/controller/rpi/lux.cpp\n> @@ -4,7 +4,6 @@\n> *\n> * Lux control algorithm\n> */\n> -#include \n>\n> #include \n>\n> diff --git a/src/ipa/rpi/controller/rpi/noise.cpp b/src/ipa/rpi/controller/rpi/noise.cpp\n> index 3f1c62cf1508..145175fb4940 100644\n> --- a/src/ipa/rpi/controller/rpi/noise.cpp\n> +++ b/src/ipa/rpi/controller/rpi/noise.cpp\n> @@ -5,7 +5,7 @@\n> * Noise control algorithm\n> */\n>\n> -#include \n> +#include \n>\n> #include \n>\n> @@ -69,7 +69,7 @@ void Noise::prepare(Metadata *imageMetadata)\n> * make some adjustments based on the camera mode (such as\n> * binning), if we knew how to discover it...\n> */\n> - double factor = sqrt(deviceStatus.analogueGain) / modeFactor_;\n> + double factor = std::sqrt(deviceStatus.analogueGain) / modeFactor_;\n> struct NoiseStatus status;\n> status.noiseConstant = referenceConstant_ * factor;\n> status.noiseSlope = referenceSlope_ * factor;\n> diff --git a/src/ipa/rpi/controller/rpi/sharpen.cpp b/src/ipa/rpi/controller/rpi/sharpen.cpp\n> index 39537f4aaf0a..1d143ff53287 100644\n> --- a/src/ipa/rpi/controller/rpi/sharpen.cpp\n> +++ b/src/ipa/rpi/controller/rpi/sharpen.cpp\n> @@ -5,7 +5,7 @@\n> * sharpening control algorithm\n> */\n>\n> -#include \n> +#include \n>\n> #include \n>\n> @@ -68,7 +68,7 @@ void Sharpen::prepare(Metadata *imageMetadata)\n> * we adjust the limit and threshold less aggressively. Using a sqrt\n> * function is an arbitrary but gentle way of accomplishing this.\n> */\n> - double userStrengthSqrt = sqrt(userStrength_);\n> + double userStrengthSqrt = std::sqrt(userStrength_);\n> struct SharpenStatus status;\n> /*\n> * Binned modes seem to need the sharpening toned down with this\n>\n> base-commit: f2088eb91fd6477b152233b9031cb115ca1ae824\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECD9DC0F1B\n\tfor ;\n\tMon, 30 Sep 2024 07:34:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9299863512;\n\tMon, 30 Sep 2024 09:34:20 +0200 (CEST)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n\t[IPv6:2607:f8b0:4864:20::1136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E136663500\n\tfor ;\n\tMon, 30 Sep 2024 09:34:18 +0200 (CEST)","by mail-yw1-x1136.google.com with SMTP id\n\t00721157ae682-6e23ebd0cacso1535567b3.0\n\tfor ;\n\tMon, 30 Sep 2024 00:34:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"r6eYd8Tk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1727681657; x=1728286457;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=kllRpF+gdAOuGYw6El7uY586ojuhW4mWJyhbJdwpJFI=;\n\tb=r6eYd8Tk1kNOOVt/o4mU8jATCrupD6Thyb8LKpiiEQCH/esi8Im0WBhm2qqBAI0Rt8\n\tr7rle4NNMC1yrs2uS9R2awK99n5zeKBC7Yq8/AGOkvlvbtZBoE1XolBnq6R7LMR1MX2G\n\ttNBVYWnKeZeQCfIhg2urEgLlgQfvsCaAK5SDz409XS9KQ3fxc5v1RMfXVqfr/PghliXc\n\tvMplyFUUAq49vOR/m0a8Qtwwz8uAZ777jhHHndNoq6RSLr3mfnNdGrZTYr9JyYfHDYVh\n\tugTcixEnjyAUKhJPtUafvW+nEzYmYieImeXC56fqmwrOHeGfrMem/nbdIdy+kHfXCCmA\n\tFKzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727681657; x=1728286457;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=kllRpF+gdAOuGYw6El7uY586ojuhW4mWJyhbJdwpJFI=;\n\tb=pwOSPW080FptuJALndqg/fOcky/peyNp6aetmhVaAwKRWhEqKUcS+E9V4bjVPjRHEY\n\t20wL/xEWPDe8WSQvIqVxqHAstIRvYczDIIP4ZUGBA7Bq5vIjMCjLpa08LI5OHBuAcuC1\n\t58oCQRWFNv7enMsGfH/TorW5+YhiYJ64raxTFC1n0s88MvVOCeGOtb9/YEtY5yjHjoBY\n\t0LIaTr4wO4+qFLfFHxSUoVmbDAVaXoXD8rvLcOqZx4+ZQoFx3tkVMBTl3O0Yo/TjZs7D\n\tj5PyfR374x2ihBHZ0Gp0Wcd+V2bzwrf/aEWKkS4MQiBv9V4adNgxFahJYxk6SaO4PPwH\n\tUiew==","X-Gm-Message-State":"AOJu0Yz7/tjkPG3esJGMelztYcYYZiT3RWS1iwE2ilItFI4Ljr2GpRLi\n\tEJPoPIP/SeclaYtPoFxOOgfsXZECGDNtv39lGwcAf5PyCwDkYc1RTMClFWulm51loQWHt/T8Bpv\n\tcGxc9FZmMjt+sDAoB+lSL3HYXFXjPsqb+hx+zB7YO+VAxsiSi","X-Google-Smtp-Source":"AGHT+IEu6JaOHKB7rIHQ6gPiK0ZEE3tfg5kqfmCpEfUGYgHosNXjbLNMMXGNLf7AOWkjWXNJEya0hCYKPfag/dfubxY=","X-Received":"by 2002:a05:690c:ed6:b0:6e2:636:d9fe with SMTP id\n\t00721157ae682-6e25867cfb9mr21265947b3.0.1727681657504;\n\tMon, 30 Sep 2024 00:34:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20240926100640.3504-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20240926100640.3504-1-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 30 Sep 2024 08:33:59 +0100","Message-ID":"","Subject":"Re: [PATCH 1/2] ipa: rpi: Replace last users of math.c","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tDavid Plowman ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]