{"id":21365,"url":"https://patchwork.libcamera.org/api/patches/21365/?format=json","web_url":"https://patchwork.libcamera.org/patch/21365/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240925095850.348259-12-mzamazal@redhat.com>","date":"2024-09-25T09:58:43","name":"[v4,11/15] config: Look up pipelines match list in configuration file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a4c81defedc9f90459447c381630b5da36b58f67","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21365/mbox/","series":[{"id":4623,"url":"https://patchwork.libcamera.org/api/series/4623/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4623","date":"2024-09-25T09:58:32","name":"Add global configuration file","version":4,"mbox":"https://patchwork.libcamera.org/series/4623/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21365/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21365/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EF59C0F1B\n\tfor ;\n\tWed, 25 Sep 2024 09:59:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 763236351F;\n\tWed, 25 Sep 2024 11:59:42 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F1D663522\n\tfor ;\n\tWed, 25 Sep 2024 11:59:31 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-572-UbM3ASGQNqiDGqwwOnJAvA-1;\n\tWed, 25 Sep 2024 05:59:26 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E30431944DE0; Wed, 25 Sep 2024 09:59:25 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.29])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6CECB19560AA; Wed, 25 Sep 2024 09:59:24 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FDZ2mxN8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727258370;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=qpim49Zhr42Ew3CgfSRDTUo2P5q25kT1ix74VU6Ppr0=;\n\tb=FDZ2mxN80kUaUhhcs3cBNpWhOOD75BNIp4Ym60brqKnREWcWFIWj1buxw55UlUE8Sf8ygC\n\ttvVFIyxcYSm/31PNuSIb58xULaCQbZX4FQjHv6Zh0+0JYIG0IKF792MKPFxNv3U09Ekomc\n\t/2TcWEtiXE1pkfc4Csdtm47G9l52KBw=","X-MC-Unique":"UbM3ASGQNqiDGqwwOnJAvA-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"[PATCH v4 11/15] config: Look up pipelines match list in\n\tconfiguration file","Date":"Wed, 25 Sep 2024 11:58:43 +0200","Message-ID":"<20240925095850.348259-12-mzamazal@redhat.com>","In-Reply-To":"<20240925095850.348259-1-mzamazal@redhat.com>","References":"<20240925095850.348259-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Milan Zamazal \n---\n src/libcamera/camera_manager.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex c1093320c..6675032b5 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -118,14 +118,15 @@ void CameraManager::Private::createPipelineHandlers()\n \t * file and only fallback on environment variable or all handlers, if\n \t * there is no configuration file.\n \t */\n-\tconst char *pipesList =\n-\t\tutils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n-\tif (pipesList) {\n+\tstd::optional pipesList =\n+\t\tGlobalConfiguration::envOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n+\t\t\t\t\t \"pipelines_match_list\");\n+\tif (pipesList.has_value()) {\n \t\t/*\n \t\t * When a list of preferred pipelines is defined, iterate\n \t\t * through the ordered list to match the enumerated devices.\n \t\t */\n-\t\tfor (const auto &pipeName : utils::split(pipesList, \",\")) {\n+\t\tfor (const auto &pipeName : utils::split(pipesList.value(), \",\")) {\n \t\t\tconst PipelineHandlerFactoryBase *factory;\n \t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n \t\t\tif (!factory)\n","prefixes":["v4","11/15"]}