[{"id":31423,"web_url":"https://patchwork.libcamera.org/comment/31423/","msgid":"","date":"2024-09-26T19:44:47","subject":"Re: [PATCH v4 12/15] config: Allow enabling software ISP in runtime","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2024. szeptember 25., szerda 11:58 keltezéssel, Milan Zamazal írta:\n\n> [...]\n> \tswIspEnabled_ = info->swIspEnabled;\n> +\tfor (GlobalConfiguration::Configuration entry :\n> +\t GlobalConfiguration::configuration()\n> +\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n> +\t\t\t .asList()) {\n> +\t\tauto name = entry[\"driver\"].get();\n> +\t\tif (name.has_value() and !name.value().compare(info->driver)) {\n\nI think\n\n if (name == info->driver)\n\nshould work.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> +\t\t\tswIspEnabled_ = entry[\"software_isp\"].get().value_or(swIspEnabled_);\n> +\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n> +\t\t\tbreak;\n> +\t\t}\n> +\t}\n> \n> \t/* Locate the sensors. */\n> \tstd::vector sensors = locateSensors(media);\n> --\n> 2.44.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 033CDC0F1B\n\tfor ;\n\tThu, 26 Sep 2024 19:44:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E39126350F;\n\tThu, 26 Sep 2024 21:44:52 +0200 (CEST)","from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59161618DA\n\tfor ;\n\tThu, 26 Sep 2024 21:44:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"MPyZl7hi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1727379890; x=1727639090;\n\tbh=mUejSpmTFwafc1XuHJoY1yyITrdr5JRELotkoWMeSvw=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=MPyZl7hiOFHL80KojSEuDRbk7lVQ73MHosni0roZ/MG3jDKGt95miMrGgkyD3dVVG\n\tYumt6IF75dsgGkIRtfzd27sJCbAsPS2jeB5n51XsexAE2q90VTBQ0pbArB8cJxYe1P\n\tyhvDvA4putsHPIyaqksXc7EDWTBYG8QM75RNxqbTJGLmJo/bFfRi5VQOOIzTbjySMN\n\ti1jiITaNpWf97xXegFtWOpdqfsaC1nUt5ozuhzN6/2HfZAI8FyeBPfFVpNxfjy9sGC\n\to3lJDpjln+wiocR/fuPLR0qR6cgerAAKOqit0aGswJz6sDX0p6N9/KqCWE+2oORD3L\n\ttsRgAf5u5P20w==","Date":"Thu, 26 Sep 2024 19:44:47 +0000","To":"Milan Zamazal ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"Re: [PATCH v4 12/15] config: Allow enabling software ISP in runtime","Message-ID":"","In-Reply-To":"<20240925095850.348259-13-mzamazal@redhat.com>","References":"<20240925095850.348259-1-mzamazal@redhat.com>\n\t<20240925095850.348259-13-mzamazal@redhat.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"fff024d6339cc8e628211d3104ba49056d18a707","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31442,"web_url":"https://patchwork.libcamera.org/comment/31442/","msgid":"<8734llp6n3.fsf@redhat.com>","date":"2024-09-27T13:29:04","subject":"Re: [PATCH v4 12/15] config: Allow enabling software ISP in runtime","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Barnabás,\n\nBarnabás Pőcze writes:\n\n> Hi\n>\n>\n> 2024. szeptember 25., szerda 11:58 keltezéssel, Milan Zamazal írta:\n>\n>> [...]\n>> \tswIspEnabled_ = info->swIspEnabled;\n>> +\tfor (GlobalConfiguration::Configuration entry :\n>> +\t GlobalConfiguration::configuration()\n>> +\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n>> +\t\t\t .asList()) {\n>> +\t\tauto name = entry[\"driver\"].get();\n>> +\t\tif (name.has_value() and !name.value().compare(info->driver)) {\n>\n> I think\n>\n> if (name == info->driver)\n>\n> should work.\n\nOK, thank you, I'll fix it in v5.\n\n> Regards,\n> Barnabás Pőcze\n>\n>\n>> +\t\t\tswIspEnabled_ = entry[\"software_isp\"].get().value_or(swIspEnabled_);\n>> +\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n>> +\t\t\tbreak;\n>> +\t\t}\n>> +\t}\n>> \n>> \t/* Locate the sensors. */\n>> \tstd::vector sensors = locateSensors(media);\n>> --\n>> 2.44.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3F8FC0F1B\n\tfor ;\n\tFri, 27 Sep 2024 13:29:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 953DC63510;\n\tFri, 27 Sep 2024 15:29:11 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D65DF634F2\n\tfor ;\n\tFri, 27 Sep 2024 15:29:09 +0200 (CEST)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-663-vRJ_3Of7NwOK3RTS0LXZkQ-1; Fri, 27 Sep 2024 09:29:07 -0400","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-37cd32f9c59so661259f8f.1\n\tfor ;\n\tFri, 27 Sep 2024 06:29:07 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42f57e1394fsm27436605e9.33.2024.09.27.06.29.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Sep 2024 06:29:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Cs+BtSlR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727443748;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=hvBV6eFfEqOTPq39HtIiAdv+GAclLX40280TDZkzhuw=;\n\tb=Cs+BtSlRk69ptKx1Rf4H05ppYTvCWui59mdctVs2HHZVQ//YjQXDDKD+TStsqZW4RbaCoF\n\tLoc9rkrAGDT9CfjtdxARu8uJ4z0hKnOBbHtNK1vPZRdi+ZsRtIU88d/6QqAvZP9Z0/6GfE\n\ti8lzeP1uOL1n3QIoXmXPLB9MIDcZbbQ=","X-MC-Unique":"vRJ_3Of7NwOK3RTS0LXZkQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727443746; x=1728048546;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=BqK5dh0AiZIzM0qX0ItX2WPzsr6BhaZZNpeZn7eiljU=;\n\tb=SvXvlJQI1IdUZnAo5r4iHmM4U9sY/traQB0ZDBYRX2i0xHcBvH7BWXVPuYZsC9l3k7\n\tYkdRkWRtDFNpNOLmQwCgcQ/HI6i2xpcMLMiSNyyV/O7a6zBZLzN3QMV/9iWW7CapGlap\n\ttaanVLtfO/Db39O8wwfRS73p/9iNTwxWVdZZ4FysoB/79K339mXmgFU4N0lFqsRRXHDy\n\tGDU7fZ1JJgCYmL54moxSAp6YD0/Ku+zNUIU9jOg929Q9OF6qXg3alse4WEvysD3SPV5/\n\t33xAPYtbtsFrTFSXCffn0JeTG/YtiGazRIuYF5WC6+q6l9FsDQA5BWsiPw10VYe72+2M\n\ttpyw==","X-Gm-Message-State":"AOJu0YwG/QWHBBARxWvO5ixiY8mM00sbsDFDo3/A+P3t+ZoYbSjXTCcl\n\tYUmqC6B4D7xovLNlq05CrZUOkNxJQxW+pI6Pbv8sTcJ51CVbXHqep+6jfjqtBmQSaFaIyJZFL+N\n\t4Mh5aDFiwRZN90tGqrjXrkoantJJLjg0+fEr6hnfvMMEhP7IHFkUjwYmHCQcmheQJ3dlbYq4=","X-Received":["by 2002:adf:a2cf:0:b0:368:5ba0:622 with SMTP id\n\tffacd0b85a97d-37cd5b31972mr1945535f8f.44.1727443746095; \n\tFri, 27 Sep 2024 06:29:06 -0700 (PDT)","by 2002:adf:a2cf:0:b0:368:5ba0:622 with SMTP id\n\tffacd0b85a97d-37cd5b31972mr1945518f8f.44.1727443745676; \n\tFri, 27 Sep 2024 06:29:05 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFcFw++smiS1GXNgwxzRcm3lH9psLYQ4/r+mQFJW4zGd1ZpOxc/3sTbS29Cd9E173GR8FxmbQ==","From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, Naushir Patuck ","Subject":"Re: [PATCH v4 12/15] config: Allow enabling software ISP in runtime","In-Reply-To":"\n\t( =?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Thu,\n\t26 Sep 2024 19:44:47 +0000\")","References":"<20240925095850.348259-1-mzamazal@redhat.com>\n\t<20240925095850.348259-13-mzamazal@redhat.com>\n\t","Date":"Fri, 27 Sep 2024 15:29:04 +0200","Message-ID":"<8734llp6n3.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]