{"id":21351,"url":"https://patchwork.libcamera.org/api/patches/21351/?format=json","web_url":"https://patchwork.libcamera.org/patch/21351/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240925081551.3265942-3-chenghaoyang@google.com>","date":"2024-09-25T08:12:25","name":"[v8,2/3] libcamera: Add face detection controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"b4bb422d1cab9a48889e38831900731aa002ca30","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21351/mbox/","series":[{"id":4622,"url":"https://patchwork.libcamera.org/api/series/4622/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4622","date":"2024-09-25T08:12:23","name":"Add Face Detection Controls","version":8,"mbox":"https://patchwork.libcamera.org/series/4622/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21351/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21351/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16005C0F1B\n\tfor ;\n\tWed, 25 Sep 2024 08:16:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BB526350B;\n\tWed, 25 Sep 2024 10:16:09 +0200 (CEST)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22A47634F4\n\tfor ;\n\tWed, 25 Sep 2024 10:16:05 +0200 (CEST)","by mail-pl1-x62b.google.com with SMTP id\n\td9443c01a7336-2053525bd90so60170455ad.0\n\tfor ;\n\tWed, 25 Sep 2024 01:16:05 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20b002aaa8fsm6336465ad.240.2024.09.25.01.16.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 25 Sep 2024 01:16:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"oLHloQKA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727252163; x=1727856963;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=GWZlrTn3UIKHPYN3S3TmQEW5JGVkDju8QySmkcDjybo=;\n\tb=oLHloQKAy15ePGzt7lJxq9UQ/HTxW+3glvwlLPqL2ARf6+6dSfHRZALhGNwzELnyL2\n\t01kGeZmWdPAm5G07Cpbf8vRFy0iXSb96pOCsPuFeXvk5JuTCDC5Q+5hickNBHgwMZnsy\n\tGCzEJbtFR1b5OLyOBzsvduktcExU3kckBE0qk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727252163; x=1727856963;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=GWZlrTn3UIKHPYN3S3TmQEW5JGVkDju8QySmkcDjybo=;\n\tb=S14OsNZpXMEBnMUXMkR2Ybq54T0SCcVzKqTQ7E4o7806Q5ctaWJpUa0tBmLgFdvVXd\n\ty24rJ3iadPdLr/uylB9xOBn/aHkuOGoB3XdGN6ZLNcTWhjfxbYP6+ZGmomhtskrCUotT\n\twFzPw6fQgoWl9W4xz3/PvJM84zZzg458Fj4FHcMkD4krf3z/CZeraQ8vDYrNoNKu0jtQ\n\trDuivmL8vLdENd8ypBmVbZT8DFWjiHWCZNlZ29og0HF2Qf8zOZCTs3rMtAftDhhb9GAI\n\t3vj6Dg1+e4pvd8Z37+xsRoqNvs95r+hZ6HJ3JNjDrQ7YTHhQ0WV272kr98IG6nN3WmFC\n\t4mUQ==","X-Gm-Message-State":"AOJu0YxBWR2ba5peszyEWcghfgwj1336gHCXr+9HDPDzlkPv+Iom/Ffy\n\tapcMAtWQBTrez05z1uN5EZRUVncUbfWaMWagdlrgJzRtEXHcdgoshLYfczrjh3nfI4sfQnTz5kw\n\t=","X-Google-Smtp-Source":"AGHT+IERYT2KthmAJbnfu9sY/NJDGf+saa4glEfOrvG435tjaUV2adnRImTnZWeZhTphQq9AkCmenA==","X-Received":"by 2002:a17:902:d4c9:b0:1f6:fcd9:5b86 with SMTP id\n\td9443c01a7336-20afc40cfd8mr36086535ad.12.1727252163308; \n\tWed, 25 Sep 2024 01:16:03 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Yudhistira Erlandinata ,\n\tbecker hsieh ,\n\tHarvey Yang ,\n\tJacopo Mondi ","Subject":"[PATCH v8 2/3] libcamera: Add face detection controls","Date":"Wed, 25 Sep 2024 08:12:25 +0000","Message-ID":"<20240925081551.3265942-3-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.792.g87dc391469-goog","In-Reply-To":"<20240925081551.3265942-1-chenghaoyang@google.com>","References":"<20240925081551.3265942-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd FaceDetectMode, FaceDetectFaceRectangles, FaceDetectFaceScores,\nand FaceDetectFaceLandmark. Also add ControlTypePoint for supporting\nFaceDetectFaceLandmark.\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: becker hsieh \nCo-developed-by: Harvey Yang \nReviewed-by: Jacopo Mondi \n---\n include/libcamera/controls.h | 6 ++\n src/libcamera/control_ids_draft.yaml | 88 ++++++++++++++++++++++++++++\n src/libcamera/controls.cpp | 6 ++\n 3 files changed, 100 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 7c2bb287..bf1b8609 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -34,6 +34,7 @@ enum ControlType {\n \tControlTypeString,\n \tControlTypeRectangle,\n \tControlTypeSize,\n+\tControlTypePoint,\n };\n \n namespace details {\n@@ -87,6 +88,11 @@ struct control_type {\n \tstatic constexpr ControlType value = ControlTypeSize;\n };\n \n+template<>\n+struct control_type {\n+\tstatic constexpr ControlType value = ControlTypePoint;\n+};\n+\n template\n struct control_type> : public control_type> {\n };\ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 9bef5bf1..6a472b48 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -227,4 +227,92 @@ controls:\n value. All of the custom test patterns will be static (that is the\n raw image must not vary from frame to frame).\n \n+ - FaceDetectMode:\n+ type: uint8_t\n+ description: |\n+ Reporting mode of face detection.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_DETECT_MODE.\n+\n+ \\sa FaceDetectFaceRectangles\n+ \\sa FaceDetectFaceScores\n+ \\sa FaceDetectFaceLandmarks\n+ \\sa FaceDetectFaceIds\n+\n+ enum:\n+ - name: FaceDetectModeOff\n+ value: 0\n+ description: |\n+ Pipeline should not report face detection result.\n+\n+ - name: FaceDetectModeSimple\n+ value: 1\n+ description: |\n+ Pipeline should at least report FaceDetectFaceRectangles and\n+ FaceDetectFaceScores for each detected face.\n+ FaceDetectFaceLandmarks and FaceDetectFaceIds are optional.\n+\n+ - name: FaceDetectModeFull\n+ value: 2\n+ description: |\n+ Pipeline should report all face controls, including\n+ FaceDetectFaceRectangles, FaceDetectFaceScores,\n+ FaceDetectFaceLandmarks, and FaceDeteceFaceIds.\n+\n+ - FaceDetectFaceRectangles:\n+ type: Rectangle\n+ description: |\n+ Boundary rectangles of the detected faces.\n+ The number of values should be the number of faces reported in\n+ FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceRectangles control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_RECTANGLES.\n+\n+ size: [n]\n+\n+ - FaceDetectFaceScores:\n+ type: uint8_t\n+ description: |\n+ Confidence score of each of the detected faces by face detector.\n+ The range of score is [0, 100].\n+ The FaceDetectFaceScores control can only be returned in metadata.\n+ The number of values should be the number of faces reported in\n+ FaceDetectFaceRectangles.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_SCORES.\n+\n+ size: [n]\n+\n+ - FaceDetectFaceLandmarks:\n+ type: Point\n+ description: |\n+ Array of human face landmark coordinates in format:\n+ [..., left_eye_i, right_eye_i, mouth_i, left_eye_i+1, ...],\n+ with i = index of face.\n+ The number of values should be 3 * the number of faces reported in\n+ FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceLandmarks control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_LANDMARKS.\n+\n+ size: [n]\n+\n+ - FaceDetectFaceIds:\n+ type: int32_t\n+ description: |\n+ Each detected face is given a unique ID that is valid for as long as\n+ the face is visible to the camera device. A face that leaves the field\n+ of view and later returns may be assigned a new ID.\n+ The number of values should be the number of faces reported in\n+ FaceDetectFaceRectangles.\n+\n+ The FaceDetectFaceIds control can only be returned in metadata.\n+\n+ Currently identical to ANDROID_STATISTICS_FACE_IDS.\n+\n+ size: [n]\n+\n ...\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex dba74404..c452e607 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -60,6 +60,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeString]\t\t= sizeof(char),\n \t[ControlTypeRectangle]\t\t= sizeof(Rectangle),\n \t[ControlTypeSize]\t\t= sizeof(Size),\n+\t[ControlTypePoint]\t\t= sizeof(Point),\n };\n \n } /* namespace */\n@@ -254,6 +255,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += value->toString();\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypePoint: {\n+\t\t\tconst Point *value = reinterpret_cast(data);\n+\t\t\tstr += value->toString();\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeNone:\n \t\tcase ControlTypeString:\n \t\t\tbreak;\n","prefixes":["v8","2/3"]}