[{"id":31341,"web_url":"https://patchwork.libcamera.org/comment/31341/","msgid":"<20240924174032.GH30551@pendragon.ideasonboard.com>","date":"2024-09-24T17:40:32","subject":"Re: [PATCH] utils: abi-compat: sort meson options","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Sep 24, 2024 at 06:34:33PM +0100, Kieran Bingham wrote:\n> Sort the options passed to meson setup alphabetically when performing a\n> slimline libcamera build.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> This is based on top of https://patchwork.libcamera.org/patch/21347/\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> utils/abi-compat.sh | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/utils/abi-compat.sh b/utils/abi-compat.sh\n> index a7b2481572bd..31f61e320404 100755\n> --- a/utils/abi-compat.sh\n> +++ b/utils/abi-compat.sh\n> @@ -156,16 +156,16 @@ create_abi_dump() {\n> \t\t# Generate a minimal libcamera build. \"lib\" and \"prefix\" are\n> \t\t# defined explicitly to avoid system default ambiguities.\n> \t\tmeson setup \"$build\" \"$worktree\" \\\n> -\t\t\t-Dlibdir=lib \\\n> -\t\t\t-Dprefix=/usr/local/ \\\n> -\t\t\t-Ddocumentation=disabled \\\n> \t\t\t-Dcam=disabled \\\n> -\t\t\t-Dqcam=disabled \\\n> -\t\t\t-Dpycamera=disabled \\\n> +\t\t\t-Ddocumentation=disabled \\\n> \t\t\t-Dgstreamer=disabled \\\n> \t\t\t-Dlc-compliance=disabled \\\n> -\t\t\t-Dtracing=disabled \\\n> -\t\t\t-Dpipelines=\n> +\t\t\t-Dlibdir=lib \\\n> +\t\t\t-Dpipelines= \\\n> +\t\t\t-Dprefix=/usr/local/ \\\n> +\t\t\t-Dpycamera=disabled \\\n> +\t\t\t-Dqcam=disabled \\\n> +\t\t\t-Dtracing=disabled\n> \n> \t\tninja -C \"$build\"\n> \t\tDESTDIR=\"$install\" ninja -C \"$build\" install","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 752F3C3257\n\tfor ;\n\tTue, 24 Sep 2024 17:41:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 746976350F;\n\tTue, 24 Sep 2024 19:41:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AB4563500\n\tfor ;\n\tTue, 24 Sep 2024 19:41:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DB5E7E2;\n\tTue, 24 Sep 2024 19:39:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NLRUT5KI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727199578;\n\tbh=AH5koZd96smCvwuOb5SxBS4pxwbjCg4Ec4BCckcHle8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NLRUT5KIvJhPCIJPzihH90vrjT6PLBrx2A1nxgrph4lMqAnUb4wQCbxwrUxkQHFPw\n\tMBpLvhPur6BNgdpH9/ueTtPi1IxOWwhl2jx+RAhPcUtGrIK7ivfIH9YbBuwQaQvVIo\n\tSWeGqIFJIbyyZdKvpaNzKXObynV19xi8g4fDhbWU=","Date":"Tue, 24 Sep 2024 20:40:32 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] utils: abi-compat: sort meson options","Message-ID":"<20240924174032.GH30551@pendragon.ideasonboard.com>","References":"<20240924173433.3378703-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240924173433.3378703-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]