[{"id":31296,"web_url":"https://patchwork.libcamera.org/comment/31296/","msgid":"<20240923084749.GA8227@pendragon.ideasonboard.com>","date":"2024-09-23T08:47:49","subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey and Han-Lin,\n\nThank you for the patch.\n\nOn Mon, Sep 23, 2024 at 07:09:56AM +0000, Harvey Yang wrote:\n> From: Han-Lin Chen \n> \n> ciri has sensors: hi1339, gc08a3, and gc05a2.\n> \n> Signed-off-by: Han-Lin Chen \n> Co-developed-by: Xing Gu \n> Co-developed-by: Yudhistira Erlandinata \n> Co-developed-by: Harvey Yang \n> ---\n> .../sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 4e5217ab..a224f8d2 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -276,6 +276,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"hi1339\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n> +\t\t\t},\n> +\t\t} },\n\nUnless I'm mistaken, the driver for this sensor hasn't been posted to\nthe linux-media mailing list. The policy in libcamera is that drivers\nneed to be on their way to upstream. You could split this patch in two\nto merge support for the gc08a3 and gc05a2 already, and address the\nhi1339 when the driver gets posted.\n\n> +\t\t{ \"gc08a3\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n> +\t\t\t},\n> +\t\t} },\n\nSensor support also requires adding a sensor helper in\nsrc/ipa/libipa/camera_sensor_helper.cpp.\n\n> +\t\t{ \"gc05a2\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n\nDo those three sensors really have a pixel size of 1.12µm, or was that\nby any chance copied from the previous entry in the table ?\n\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> +\t\t\t},\n> +\t\t} },\n\nPlease sort entries alphabetically.\n\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2B35C0F1B\n\tfor ;\n\tMon, 23 Sep 2024 08:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 569E46350F;\n\tMon, 23 Sep 2024 10:48:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E781C6350A\n\tfor ;\n\tMon, 23 Sep 2024 10:48:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E65132E0;\n\tMon, 23 Sep 2024 10:46:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NSeROmFa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727081215;\n\tbh=ibjG69N5fKjTdsuVG4r7pop8FmEIJo91pCN5AhPUBQ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NSeROmFalohYj8ypPpJHR+VJXh1gNkZy3U6/ot8uADdGbpyIiXvaEF97KvC1gO+st\n\tExpGJcNFyl/lk2n6a+uDoqiJGD4xIlBBCtKIKVQXnf4Kbn0gjza61JTt4ILHUxsUOF\n\tJboxzlnZtbVaChrD0ScaAOSPdJ/BOiflhBBrKU7Y=","Date":"Mon, 23 Sep 2024 11:47:49 +0300","From":"Laurent Pinchart ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ","Subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","Message-ID":"<20240923084749.GA8227@pendragon.ideasonboard.com>","References":"<20240923071618.2395064-1-chenghaoyang@google.com>\n\t<20240923071618.2395064-2-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20240923071618.2395064-2-chenghaoyang@google.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31330,"web_url":"https://patchwork.libcamera.org/comment/31330/","msgid":"","date":"2024-09-24T09:01:25","subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Thanks Laurent for the quick review,\n\nOn Mon, Sep 23, 2024 at 4:48 PM Laurent Pinchart\n wrote:\n>\n> Hi Harvey and Han-Lin,\n>\n> Thank you for the patch.\n>\n> On Mon, Sep 23, 2024 at 07:09:56AM +0000, Harvey Yang wrote:\n> > From: Han-Lin Chen \n> >\n> > ciri has sensors: hi1339, gc08a3, and gc05a2.\n> >\n> > Signed-off-by: Han-Lin Chen \n> > Co-developed-by: Xing Gu \n> > Co-developed-by: Yudhistira Erlandinata \n> > Co-developed-by: Harvey Yang \n> > ---\n> > .../sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++\n> > 1 file changed, 21 insertions(+)\n> >\n> > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > index 4e5217ab..a224f8d2 100644\n> > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > @@ -276,6 +276,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > { controls::draft::TestPatternModeColorBars, 1 },\n> > },\n> > } },\n> > + { \"hi1339\", {\n> > + .unitCellSize = { 1120, 1120 },\n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 2 },\n> > + },\n> > + } },\n>\n> Unless I'm mistaken, the driver for this sensor hasn't been posted to\n> the linux-media mailing list. The policy in libcamera is that drivers\n> need to be on their way to upstream. You could split this patch in two\n> to merge support for the gc08a3 and gc05a2 already, and address the\n> hi1339 when the driver gets posted.\n\nYeah right. hi1339 is the old sensor used on an old ciri model in the\ndevelopment process. Therefore, I don't think we're using it in\nproduction and MTK may just skip upstreaming it.\n\nI'll drop this in the next version.\n\n\n>\n> > + { \"gc08a3\", {\n> > + .unitCellSize = { 1120, 1120 },\n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 2 },\n> > + },\n> > + } },\n>\n> Sensor support also requires adding a sensor helper in\n> src/ipa/libipa/camera_sensor_helper.cpp.\n\nAh got it, while I'm not sure if we want to use it in\nmtkisp7's ipa, as the algorithm returns an integer\nas the analogue gain [1], instead of double.\nThe algo also doesn't need the gain fed back. It\nkeeps the recent values searchable by request\nids.\n\n[1]: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/libcamera/mtkisp7/src/ipa/mtkisp7/hal3a/hal_3a.cpp;l=946\n\n>\n> > + { \"gc05a2\", {\n> > + .unitCellSize = { 1120, 1120 },\n>\n> Do those three sensors really have a pixel size of 1.12µm, or was that\n> by any chance copied from the previous entry in the table ?\n\nIt's 1.12um for \"gc05a2\" [1] and \"gc08a3\" [2] at least.\n\n[1]: https://en.gcoreinc.com/products/index?cid=2&subcid=5\n[2]: https://en.gcoreinc.com/products/index?cid=2&subcid=4\n\n>\n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 1 },\n> > + },\n> > + } },\n>\n> Please sort entries alphabetically.\n\nWill do.\n\nBR,\nHarvey\n\n\n>\n> > };\n> >\n> > const auto it = sensorProps.find(sensor);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F14B2C3257\n\tfor ;\n\tTue, 24 Sep 2024 09:01:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB8E663513;\n\tTue, 24 Sep 2024 11:01:39 +0200 (CEST)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D157634F9\n\tfor ;\n\tTue, 24 Sep 2024 11:01:38 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2f75aa08a96so54779921fa.1\n\tfor ;\n\tTue, 24 Sep 2024 02:01:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FJgdppVF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727168497; x=1727773297;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Y5BaBqovcbz7EbtGDIRXrBXo5+6Q0c1hGfD6lAIxHM0=;\n\tb=FJgdppVF9KaUH0I0O9dEKtUgK5/XLD12VL6Ap9b3xFgDqj3FiUiHn4wFTbFz9evosL\n\tYLG7DCm/aFv2NvZ6cHQ/Sze6cpr/UPs5YUDsrCCGchZ1u2CgqjYRQyZD0LQjVob9rIS5\n\tI+CNO00S14FL+STg9OZb7SUymIJNiis/Uj0r4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727168497; x=1727773297;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Y5BaBqovcbz7EbtGDIRXrBXo5+6Q0c1hGfD6lAIxHM0=;\n\tb=ZiGFSwAh9QNzbtOmJypwaym/E9JJ63FeYEErVY+t3pAzw7N94GbtgiqhfRFofgYh5d\n\tkh/yXUjgFje69fwJZCxLHEMDFsW+rX4iBA95biLYncjglIdp8hAXmN5A+MUqQ+yCYZL+\n\tBm/9SKmBeLxb2gIJ3MFN6ET87MS/zFA5FBBx3MimgrWOxGeRw/5wnd8AXtg99UUIZXdy\n\t4hshaze2BMqqjXS7s1bPdBOAqIZ4+Nf+tI3Cn7TiMzzSDgT5V03O5r0P5DEbjh0i2XYq\n\tQ3vViCshKlHVZfrvNJSDfzm+bJEwbsvQLccalIBMWFZwwxM5+nMJDWhXTOAgdsg9pQql\n\tixOg==","X-Gm-Message-State":"AOJu0YyS9E2TZUvWBLQwo+dzisVla0d3AYA4M2RaH2pgm3TMTzXNhlGd\n\th7F/anjPQsuIWVeaatGiDf7cEBpMFrVGcNRVDNLdZvD4G2lBSoj40bFD15piSqmZqXIarzOSvkF\n\tR4zRCN0OBF4yoHfSbw3H8cUu0U0fZHjSIaLOOp0Ttd311c4E=","X-Google-Smtp-Source":"AGHT+IGHzBiOpDzdol4EtPPQWAl7N53mb7KMIZgKTWWsPSo5FoEJpPRJ4d/4vCeHVZMo8XCfRwTX2qdLubKV7jvPV+U=","X-Received":"by 2002:a05:651c:2226:b0:2ef:1d8d:2201 with SMTP id\n\t38308e7fff4ca-2f7cb31ca28mr73491491fa.23.1727168496744;\n\tTue, 24 Sep 2024 02:01:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20240923071618.2395064-1-chenghaoyang@google.com>\n\t<20240923071618.2395064-2-chenghaoyang@google.com>\n\t<20240923084749.GA8227@pendragon.ideasonboard.com>","In-Reply-To":"<20240923084749.GA8227@pendragon.ideasonboard.com>","From":"Cheng-Hao Yang ","Date":"Tue, 24 Sep 2024 17:01:25 +0800","Message-ID":"","Subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31340,"web_url":"https://patchwork.libcamera.org/comment/31340/","msgid":"<20240924153053.GA30551@pendragon.ideasonboard.com>","date":"2024-09-24T15:30:53","subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Sep 24, 2024 at 05:01:25PM +0800, Cheng-Hao Yang wrote:\n> On Mon, Sep 23, 2024 at 4:48 PM Laurent Pinchart wrote:\n> > On Mon, Sep 23, 2024 at 07:09:56AM +0000, Harvey Yang wrote:\n> > > From: Han-Lin Chen \n> > >\n> > > ciri has sensors: hi1339, gc08a3, and gc05a2.\n> > >\n> > > Signed-off-by: Han-Lin Chen \n> > > Co-developed-by: Xing Gu \n> > > Co-developed-by: Yudhistira Erlandinata \n> > > Co-developed-by: Harvey Yang \n> > > ---\n> > > .../sensor/camera_sensor_properties.cpp | 21 +++++++++++++++++++\n> > > 1 file changed, 21 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > index 4e5217ab..a224f8d2 100644\n> > > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > @@ -276,6 +276,27 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > { controls::draft::TestPatternModeColorBars, 1 },\n> > > },\n> > > } },\n> > > + { \"hi1339\", {\n> > > + .unitCellSize = { 1120, 1120 },\n> > > + .testPatternModes = {\n> > > + { controls::draft::TestPatternModeOff, 0 },\n> > > + { controls::draft::TestPatternModeColorBars, 2 },\n> > > + },\n> > > + } },\n> >\n> > Unless I'm mistaken, the driver for this sensor hasn't been posted to\n> > the linux-media mailing list. The policy in libcamera is that drivers\n> > need to be on their way to upstream. You could split this patch in two\n> > to merge support for the gc08a3 and gc05a2 already, and address the\n> > hi1339 when the driver gets posted.\n> \n> Yeah right. hi1339 is the old sensor used on an old ciri model in the\n> development process. Therefore, I don't think we're using it in\n> production and MTK may just skip upstreaming it.\n> \n> I'll drop this in the next version.\n> \n> > > + { \"gc08a3\", {\n> > > + .unitCellSize = { 1120, 1120 },\n> > > + .testPatternModes = {\n> > > + { controls::draft::TestPatternModeOff, 0 },\n> > > + { controls::draft::TestPatternModeColorBars, 2 },\n> > > + },\n> > > + } },\n> >\n> > Sensor support also requires adding a sensor helper in\n> > src/ipa/libipa/camera_sensor_helper.cpp.\n> \n> Ah got it, while I'm not sure if we want to use it in\n> mtkisp7's ipa, as the algorithm returns an integer\n> as the analogue gain [1], instead of double.\n\nlibipa models the analog gain as a real value, and the sensor helpers\nare tasked with converting that value to the analog gain value that the\nsensor expects. This assumes that the kernel driver passes the value to\nthe sensor without performing any conversion, which is what we require\nfrom drivers (the driver can still clamp the value to the supported\nrange, and should expose the range through the min/max values for the\ncontrol). Your IPA module doesn't have to use libipa, but new sensors\nneed to be added to libipa so that they will work with all the platforms\nwe support.\n\n> The algo also doesn't need the gain fed back. It\n> keeps the recent values searchable by request\n> ids.\n\nWe still need the back conversion to be implemented in libipa, for\nplatform that need it.\n\n> [1]: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/libcamera/mtkisp7/src/ipa/mtkisp7/hal3a/hal_3a.cpp;l=946\n> \n> > > + { \"gc05a2\", {\n> > > + .unitCellSize = { 1120, 1120 },\n> >\n> > Do those three sensors really have a pixel size of 1.12µm, or was that\n> > by any chance copied from the previous entry in the table ?\n> \n> It's 1.12um for \"gc05a2\" [1] and \"gc08a3\" [2] at least.\n> \n> [1]: https://en.gcoreinc.com/products/index?cid=2&subcid=5\n> [2]: https://en.gcoreinc.com/products/index?cid=2&subcid=4\n\nThanks.\n\n> > > + .testPatternModes = {\n> > > + { controls::draft::TestPatternModeOff, 0 },\n> > > + { controls::draft::TestPatternModeColorBars, 1 },\n> > > + },\n> > > + } },\n> >\n> > Please sort entries alphabetically.\n> \n> Will do.\n> \n> > > };\n> > >\n> > > const auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29344C3257\n\tfor ;\n\tTue, 24 Sep 2024 15:31:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D20506350F;\n\tTue, 24 Sep 2024 17:31:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9618563500\n\tfor ;\n\tTue, 24 Sep 2024 17:31:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63D08827;\n\tTue, 24 Sep 2024 17:29:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bjJNTzq/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727191798;\n\tbh=Np+io0f2lVJkgmCd5ZDgysJW3RSi3b0ih6zLNqbeE5c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bjJNTzq/SdJQkMcqXOEzp2WgTh+vyMWaadEUJJFgKgfMjJD9czgyakUUzjE1BicPG\n\tXjNeS04vi4wmyqn71MpsneI0HoejUdEwzOcjiSIdfRf5YYUkbQbc2q/2JeSBo3ZyAW\n\tAP+prn+AS7U1PSwiE1Ifj68HHpnSGtmxEmcIWlIo=","Date":"Tue, 24 Sep 2024 18:30:53 +0300","From":"Laurent Pinchart ","To":"Cheng-Hao Yang ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ","Subject":"Re: [PATCH 1/1] libcamera: Add camera sensor properties for ciri","Message-ID":"<20240924153053.GA30551@pendragon.ideasonboard.com>","References":"<20240923071618.2395064-1-chenghaoyang@google.com>\n\t<20240923071618.2395064-2-chenghaoyang@google.com>\n\t<20240923084749.GA8227@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]