[{"id":31432,"web_url":"https://patchwork.libcamera.org/comment/31432/","msgid":"","date":"2024-09-27T07:29:46","subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn 16/09/24 7:32 pm, Kieran Bingham wrote:\n> The delay values should be managed correctly. Not the dealys.\n>\n> Correct accordingly, but I also hope we'll resolve this\n> task soon too.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c02c7cf374e9..2fee84e56d4d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \tdata->properties_ = data->sensor_->properties();\n> \n> \t/*\n> -\t * \\todo Read dealy values from the sensor itself or from a\n> +\t * \\todo Read delay values from the sensor itself or from a\n> \t * a sensor database. For now use generic values taken from\n> \t * the Raspberry Pi and listed as generic values.\n> \t */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1E15C3257\n\tfor ;\n\tFri, 27 Sep 2024 07:29:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBB6363510;\n\tFri, 27 Sep 2024 09:29:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D27ED618DB\n\tfor ;\n\tFri, 27 Sep 2024 09:29:51 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 822008BF;\n\tFri, 27 Sep 2024 09:28:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oCRgqsOP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727422103;\n\tbh=XDd5M9zJgL4dmhwM8WxJejEWJ6HGXaCZUBYt6VNmb/Y=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=oCRgqsOPR39gvTNRjPaG45I7muRdCXS50AcUPdYKUYjL893nMqYyj8f49PlKcVM9D\n\tRpu4N190kal76Y3y1agaC5BRDpPVQFFpFhGo1TW/D1C0rtx0DdySR0uaGr3DbYIYxi\n\tXQExoS0sVanBW2LVta18DJbcoUQYCZQbJBxvoMlI=","Message-ID":"","Date":"Fri, 27 Sep 2024 12:59:46 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20240916140241.47845-1-kieran.bingham@ideasonboard.com>\n\t<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31444,"web_url":"https://patchwork.libcamera.org/comment/31444/","msgid":"","date":"2024-09-27T13:48:19","subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote:\n> The delay values should be managed correctly. Not the dealys.\n\n:)\n\nReviewed-by: Jacopo Mondi \n\n>\n> Correct accordingly, but I also hope we'll resolve this\n> task soon too.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c02c7cf374e9..2fee84e56d4d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \tdata->properties_ = data->sensor_->properties();\n>\n> \t/*\n> -\t * \\todo Read dealy values from the sensor itself or from a\n> +\t * \\todo Read delay values from the sensor itself or from a\n> \t * a sensor database. For now use generic values taken from\n> \t * the Raspberry Pi and listed as generic values.\n> \t */\n> --\n> 2.46.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E798CC0F1B\n\tfor ;\n\tFri, 27 Sep 2024 13:48:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 914D66351E;\n\tFri, 27 Sep 2024 15:48:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 428F66350B\n\tfor ;\n\tFri, 27 Sep 2024 15:48:23 +0200 (CEST)","from ideasonboard.com (mob-5-90-58-180.net.vodafone.it\n\t[5.90.58.180])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C5098BF;\n\tFri, 27 Sep 2024 15:46:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rSO3d0PX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727444814;\n\tbh=cuqxI2+AA0IgWkFY4hreKbMRfc+rZCNukVIx5QQeIfw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rSO3d0PXPS1fIGxZ9eTq28kVH6leqWT+y/lb/OZY0ayirjPqIEE4hrk5EaTif39aw\n\tgWyfntJ+kt+5r/Bw6+kkTuqjZsIpm0XJDNteDvW3LkmJMrf93bCeXAombWChnv5I/h\n\tipPER4Mrehv0RUD5IDFUMWO0+HAZObrARiNwOgB0=","Date":"Fri, 27 Sep 2024 15:48:19 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","Message-ID":"","References":"<20240916140241.47845-1-kieran.bingham@ideasonboard.com>\n\t<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31445,"web_url":"https://patchwork.libcamera.org/comment/31445/","msgid":"","date":"2024-09-27T13:48:45","subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote:\n> The delay values should be managed correctly. Not the dealys.\n>\n> Correct accordingly, but I also hope we'll resolve this\n> task soon too.\n\nMaybe the second part shouldn't be in the commit message\n\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c02c7cf374e9..2fee84e56d4d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \tdata->properties_ = data->sensor_->properties();\n>\n> \t/*\n> -\t * \\todo Read dealy values from the sensor itself or from a\n> +\t * \\todo Read delay values from the sensor itself or from a\n> \t * a sensor database. For now use generic values taken from\n> \t * the Raspberry Pi and listed as generic values.\n> \t */\n> --\n> 2.46.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48BE9C0F1B\n\tfor ;\n\tFri, 27 Sep 2024 13:48:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C0556351F;\n\tFri, 27 Sep 2024 15:48:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBC1B6350B\n\tfor ;\n\tFri, 27 Sep 2024 15:48:48 +0200 (CEST)","from ideasonboard.com (mob-5-90-58-180.net.vodafone.it\n\t[5.90.58.180])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 156498BF;\n\tFri, 27 Sep 2024 15:47:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tMURnSOd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727444840;\n\tbh=QYwH2GR5TVicuVb1ZwQ/XS0xURJCIq+LNxOnNugEDVY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tMURnSOdIHwHJrY2nczAkAmdnIqqmG9WuXCQ/mm4EXvz3N5fEST0qwBnuSoJdKogn\n\tMoyvNrNT9/yrHVmU5GXKjHuGixD/v50SkTiKR9KDy1nXRYtiJfnF+Dcg8jYoRhvh3Z\n\tfXtMoCCxKJ2kROHaZoaVuPh3dQ3CqrNpv4REf5uE=","Date":"Fri, 27 Sep 2024 15:48:45 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","Message-ID":"","References":"<20240916140241.47845-1-kieran.bingham@ideasonboard.com>\n\t<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240916140241.47845-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31446,"web_url":"https://patchwork.libcamera.org/comment/31446/","msgid":"<172744535929.532453.11045517679602453330@ping.linuxembedded.co.uk>","date":"2024-09-27T13:55:59","subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2024-09-27 14:48:45)\n> On Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote:\n> > The delay values should be managed correctly. Not the dealys.\n> >\n> > Correct accordingly, but I also hope we'll resolve this\n> > task soon too.\n> \n> Maybe the second part shouldn't be in the commit message\n\nHappy to drop the second paragraph. This was only a drive by commit\nwhile I was here.\n\n> \n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index c02c7cf374e9..2fee84e56d4d 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> > data->properties_ = data->sensor_->properties();\n> >\n> > /*\n> > - * \\todo Read dealy values from the sensor itself or from a\n> > + * \\todo Read delay values from the sensor itself or from a\n> > * a sensor database. For now use generic values taken from\n> > * the Raspberry Pi and listed as generic values.\n> > */\n> > --\n> > 2.46.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADA60C3257\n\tfor ;\n\tFri, 27 Sep 2024 13:56:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6276F6350F;\n\tFri, 27 Sep 2024 15:56:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0858F634F2\n\tfor ;\n\tFri, 27 Sep 2024 15:56:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09CB88BF;\n\tFri, 27 Sep 2024 15:54:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O04q9ulg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727445273;\n\tbh=kMvgSHE2h9W5AK++PAKvyd+voZbAgza10Tj/i6y1m2E=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=O04q9ulgZ0M2lj74iggOcjL0HVi1306QGNF3ZsNyx0H8+wmqxunM1PLZZ3wkexL+6\n\tYdLARPGux4qQHpWh0Tqh7V2bfzjdOS2ICkjETK33fNkDTk7nfmdVOB18ykQ5YjwghW\n\tqf2ue0lc+Zkf0DQrDoNWUAsIsUThPdD0AfGSNo6Q=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240916140241.47845-1-kieran.bingham@ideasonboard.com>\n\t<20240916140241.47845-3-kieran.bingham@ideasonboard.com>\n\t","Subject":"Re: [PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task","From":"Kieran Bingham ","Cc":"libcamera devel ","To":"Jacopo Mondi ","Date":"Fri, 27 Sep 2024 14:55:59 +0100","Message-ID":"<172744535929.532453.11045517679602453330@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]