[{"id":31243,"web_url":"https://patchwork.libcamera.org/comment/31243/","msgid":"","date":"2024-09-16T13:32:37","subject":"Re: [PATCH v4 3/3] py: Add bindings for ControlId enum name","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch. \n\nOn Mon, Sep 16, 2024 at 01:24:20AM +0200, Paul Elder wrote:\n> Add python bindings for querying enum value names from a ControlId.\n> \n> Example usage:\n> >>> cid\n> libcamera.ControlId(16, AwbMode, ControlType.Integer32)\n> >>> cid.enumerators()\n> {0: 'AwbAuto', 1: 'AwbIncandescent', 2: 'AwbTungsten', 3: 'AwbFluorescent', 4: 'AwbIndoor', 5: 'AwbDaylight', 6: 'AwbCloudy', 7: 'AwbCustom'}\n> >>> cinfo\n> libcamera.ControlInfo([2..5])\n> >>> cinfo.values\n> [2, 3, 5]\n> >>> [cid.enumerators()[v] for v in cinfo.values]\n> ['AwbTungsten', 'AwbFluorescent', 'AwbDaylight']\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefam\n> \n> ---\n> Changes in v4:\n> - s/enum_str/enumerators/\n> - s/enumToString/enumerators/\n> - add example usage to commit message\n> \n> Changes in v3:\n> - s/enumName/enumToString/\n> - s/enum_name/enum_str/\n> \n> New in v2\n> ---\n> src/py/libcamera/py_main.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index ab33f38a8..983b76f6e 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -404,7 +404,8 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def(\"__repr__\", [](const ControlId &self) {\n> \t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n> \t\t\t\t.format(self.id(), self.name(), self.type());\n> -\t\t});\n> +\t\t})\n> +\t\t.def(\"enumerators\", &ControlId::enumerators);\n> \n> \tpyControlInfo\n> \t\t.def_property_readonly(\"min\", [](const ControlInfo &self) {\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92833C3257\n\tfor ;\n\tMon, 16 Sep 2024 13:32:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38C4F634FD;\n\tMon, 16 Sep 2024 15:32:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5317D634F5\n\tfor ;\n\tMon, 16 Sep 2024 15:32:41 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:4bc9:a45:b0af:8993:ee4e:ea06:9114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA095497;\n\tMon, 16 Sep 2024 15:31:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mgtnmwTb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726493480;\n\tbh=Z/SWLhtW48EaGj/5ix+Epu6jkC4rjDf2QCbpDNarZVQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mgtnmwTbhSTvYlAeOtm2FKJ1n3L7EUUHhcvsl+Y+4uaotyUsOBQ/5KshtVIbAJODK\n\tS6ZL/kWzdmLYb8NXQyz2/UevdHMLOCS3PwcboycV6aqdF9q3P6Sb6Bh3ArQLCRfywG\n\tYictECgCJfvlnl+7t3ShUxHVM1524xAVNRlanspY=","Date":"Mon, 16 Sep 2024 15:32:37 +0200","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"Re: [PATCH v4 3/3] py: Add bindings for ControlId enum name","Message-ID":"","References":"<20240915232420.2106705-1-paul.elder@ideasonboard.com>\n\t<20240915232420.2106705-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240915232420.2106705-4-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31364,"web_url":"https://patchwork.libcamera.org/comment/31364/","msgid":"<20240925205554.GC5373@pendragon.ideasonboard.com>","date":"2024-09-25T20:55:54","subject":"Re: [PATCH v4 3/3] py: Add bindings for ControlId enum name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Sep 16, 2024 at 01:24:20AM +0200, Paul Elder wrote:\n> Add python bindings for querying enum value names from a ControlId.\n> \n> Example usage:\n> >>> cid\n> libcamera.ControlId(16, AwbMode, ControlType.Integer32)\n> >>> cid.enumerators()\n> {0: 'AwbAuto', 1: 'AwbIncandescent', 2: 'AwbTungsten', 3: 'AwbFluorescent', 4: 'AwbIndoor', 5: 'AwbDaylight', 6: 'AwbCloudy', 7: 'AwbCustom'}\n> >>> cinfo\n> libcamera.ControlInfo([2..5])\n> >>> cinfo.values\n> [2, 3, 5]\n> >>> [cid.enumerators()[v] for v in cinfo.values]\n> ['AwbTungsten', 'AwbFluorescent', 'AwbDaylight']\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v4:\n> - s/enum_str/enumerators/\n> - s/enumToString/enumerators/\n> - add example usage to commit message\n> \n> Changes in v3:\n> - s/enumName/enumToString/\n> - s/enum_name/enum_str/\n> \n> New in v2\n> ---\n> src/py/libcamera/py_main.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index ab33f38a8..983b76f6e 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -404,7 +404,8 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def(\"__repr__\", [](const ControlId &self) {\n> \t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n> \t\t\t\t.format(self.id(), self.name(), self.type());\n> -\t\t});\n> +\t\t})\n> +\t\t.def(\"enumerators\", &ControlId::enumerators);\n> \n> \tpyControlInfo\n> \t\t.def_property_readonly(\"min\", [](const ControlInfo &self) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8602EC3257\n\tfor ;\n\tWed, 25 Sep 2024 20:55:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E87963511;\n\tWed, 25 Sep 2024 22:55:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAB05634FB\n\tfor ;\n\tWed, 25 Sep 2024 22:55:56 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C613F842;\n\tWed, 25 Sep 2024 22:54:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FNbyZdQU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727297669;\n\tbh=NM8TKGelcFOyROl9nuq7WZAZVhYisfn/sb1lhb7Y52E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FNbyZdQUx19OfhSP0LxfepB0EWnFAwoFhbM2HcbTdzu2UfuxS0sjiUTM6L3JTM7fz\n\tq18tmWTcRL2zQs5SBZmrCkldvM2x0YQvSD2KY2gfTA8vdfIgbKsxLZ4SYFCXfJ5ybz\n\tH5PpO5eGqDCSek8bp6uoGJmXEVFMOwTz5ZhZ2gpM=","Date":"Wed, 25 Sep 2024 23:55:54 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, stefan.klug@ideasonboard.com,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 3/3] py: Add bindings for ControlId enum name","Message-ID":"<20240925205554.GC5373@pendragon.ideasonboard.com>","References":"<20240915232420.2106705-1-paul.elder@ideasonboard.com>\n\t<20240915232420.2106705-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240915232420.2106705-4-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]