[{"id":31180,"web_url":"https://patchwork.libcamera.org/comment/31180/","msgid":"<20240911222558.GM4470@pendragon.ideasonboard.com>","date":"2024-09-11T22:25:58","subject":"Re: [PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string\n\thelper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 11, 2024 at 11:18:16PM +0200, Kieran Bingham wrote:\n> Replace the open-coded implementation of a link representation\n> with the operator<< overload string representation to simplify\n> the code and unify appearance of reporting MediaLinks.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nYou don't need to sign your patch twice :-)\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1e7ec7d97255..2d205e9925ef 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t}\n> \n> \t\tLOG(SimplePipeline, Debug)\n> -\t\t\t<< \"Link '\" << source->entity()->name()\n> -\t\t\t<< \"':\" << source->index()\n> -\t\t\t<< \" -> '\" << sink->entity()->name()\n> -\t\t\t<< \"':\" << sink->index()\n> -\t\t\t<< \" configured with format \" << *format;\n> +\t\t\t<< \"Link \" << *link << \": configured with format \"\n> +\t\t\t<< *format;\n> \t}\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A630FBF415\n\tfor ;\n\tWed, 11 Sep 2024 22:26:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 573C9634FB;\n\tThu, 12 Sep 2024 00:26:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC9A0634E4\n\tfor ;\n\tThu, 12 Sep 2024 00:26:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D80F4496;\n\tThu, 12 Sep 2024 00:25:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QeT7iSdC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726093514;\n\tbh=aUI1JdTozc9LdAmrs/2sGjn+WXRZspQJGnjpuD+VMRk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QeT7iSdC5Qm9ot0E4laIGQ8bPWCdDG0RWS+hMnInP4WhhBxYIFjVGMdxObIBKdilc\n\tOVIk5vqy+toq4pGaXtud4RmRtnYH6+8KogiRlelCtdvXq8/8nUVF+1LAHho/rQjCTT\n\ttkuo1ZmIdVAUtbl/oAVNPhCAWm8V3MgVfsNDCTus=","Date":"Thu, 12 Sep 2024 01:25:58 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string\n\thelper","Message-ID":"<20240911222558.GM4470@pendragon.ideasonboard.com>","References":"<20240911211816.73763-1-kieran.bingham@ideasonboard.com>\n\t<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31190,"web_url":"https://patchwork.libcamera.org/comment/31190/","msgid":"","date":"2024-09-12T09:02:59","subject":"Re: [PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string\n\thelper","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\n\nOn Wed, Sep 11, 2024 at 11:18:16PM +0200, Kieran Bingham wrote:\n> Replace the open-coded implementation of a link representation\n> with the operator<< overload string representation to simplify\n> the code and unify appearance of reporting MediaLinks.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1e7ec7d97255..2d205e9925ef 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t}\n> \n> \t\tLOG(SimplePipeline, Debug)\n> -\t\t\t<< \"Link '\" << source->entity()->name()\n> -\t\t\t<< \"':\" << source->index()\n> -\t\t\t<< \" -> '\" << sink->entity()->name()\n> -\t\t\t<< \"':\" << sink->index()\n> -\t\t\t<< \" configured with format \" << *format;\n> +\t\t\t<< \"Link \" << *link << \": configured with format \"\n> +\t\t\t<< *format;\n> \t}\n> \n> \treturn 0;\n> -- \n> 2.46.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1742DBF415\n\tfor ;\n\tThu, 12 Sep 2024 09:03:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB13F634FC;\n\tThu, 12 Sep 2024 11:03:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C41E3634F5\n\tfor ;\n\tThu, 12 Sep 2024 11:03:01 +0200 (CEST)","from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7C92496;\n\tThu, 12 Sep 2024 11:01:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Uypjc4BF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726131703;\n\tbh=/1HcJgDu2F9hMpph0Toifa8gS9aDPBrfusNV+OKNHXg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Uypjc4BFcGqBu5vmlkuHfDAcnZ/4y5MGUOuCklFoC8ebkvWjqW9oh+XfIDmePL/GC\n\tcqtxWW2tOTX7dnWxrypBZzh47Ovx0fLhUJghV2EeqcvweSogn9JXN7Xk4b6HOByh+T\n\tso5i4qg+zSxTsunjuiDDLKSWxTWx/bmLP6Usy2Ns=","Date":"Thu, 12 Sep 2024 11:02:59 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel , \n\tLaurent Pinchart ","Subject":"Re: [PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string\n\thelper","Message-ID":"","References":"<20240911211816.73763-1-kieran.bingham@ideasonboard.com>\n\t<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]