[{"id":31188,"web_url":"https://patchwork.libcamera.org/comment/31188/","msgid":"<3a4pnpsdb7n3hfmghxq5ui7bf22y6rztwq466wniiazanfmlev@a6bkdqc347e7>","date":"2024-09-12T08:58:29","subject":"Re: [PATCH v2 2/4] libcamera: media_object: Add MediaLink string\n\trepresentations","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nMissed v2, so\n\nOn Wed, Sep 11, 2024 at 11:18:14PM +0200, Kieran Bingham wrote:\n> Various parts of libcamera print the representation of a MediaLink by\n> inline joining the parts to make a string representation.\n> \n> This repeated use case can be supported with a common helper to print\n> the MediaLink in a common manner using the existing toString() and\n> operator<< overload style to make it easier to report on MediaLink\n> types.\n> \n> This implementation will report in the following style:\n> \n> 'imx283 1-001a'[0] -> 'video-mux'[0]\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> v2:\n> - Fix documentation\n> - Use MediaPad helper \n> \n> include/libcamera/internal/media_object.h | 4 ++++\n> src/libcamera/media_object.cpp | 25 +++++++++++++++++++++++\n> 2 files changed, 29 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index d80d5f4574c7..9356d204d6e5 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -48,6 +48,8 @@ public:\n> \tunsigned int flags() const { return flags_; }\n> \tint setEnabled(bool enable);\n> \n> +\tstd::string toString() const;\n> +\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(MediaLink)\n> \n> @@ -61,6 +63,8 @@ private:\n> \tunsigned int flags_;\n> };\n> \n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link);\n> +\n> class MediaPad : public MediaObject\n> {\n> public:\n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index 25f16707ab73..3e3772a628c2 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -146,6 +146,31 @@ MediaLink::MediaLink(const struct media_v2_link *link, MediaPad *source,\n> {\n> }\n> \n> +/**\n> + * \\brief Generate a string representation of the MediaLink\n> + * \\return A string representing the MediaLink\n> + */\n> +std::string MediaLink::toString() const\n> +{\n> +\tstd::stringstream ss;\n> +\tss << *this;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> +/**\n> + * \\brief Insert a text representation of a Link into an output stream\n> + * \\param[in] out The output stream\n> + * \\param[in] link The MediaLink\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link)\n> +{\n> +\tout << *link.source() << \" -> \" << *link.sink();\n> +\n> +\treturn out;\n> +}\n> +\n> /**\n> * \\fn MediaLink::source()\n> * \\brief Retrieve the link's source pad\n> -- \n> 2.46.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDB12C324C\n\tfor ;\n\tThu, 12 Sep 2024 08:58:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C2A5634FE;\n\tThu, 12 Sep 2024 10:58:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80A87634F9\n\tfor ;\n\tThu, 12 Sep 2024 10:58:32 +0200 (CEST)","from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5484D496;\n\tThu, 12 Sep 2024 10:57:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xv3u30rU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726131434;\n\tbh=mfDieUMothvL7x1hWDlblnjS7bAaKTw+t5UQHMZtiHE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xv3u30rUv6EtVSQEPwIASkAqImTYd9Hxq4Ovlmdgt0R3vbQvshFjjfZ2jT4qtuSix\n\tZHH4voJJoNAEqEbYX53IGeDZsKAaVd/p6OjFlTtDNTAIZ0CVMHGrt1MTlESl5c1ebn\n\t5kKB+t3l6Nd2JAid8ZIiqUFODbcpZ+t84Ie2s9K0=","Date":"Thu, 12 Sep 2024 10:58:29 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel , \n\tLaurent Pinchart ","Subject":"Re: [PATCH v2 2/4] libcamera: media_object: Add MediaLink string\n\trepresentations","Message-ID":"<3a4pnpsdb7n3hfmghxq5ui7bf22y6rztwq466wniiazanfmlev@a6bkdqc347e7>","References":"<20240911211816.73763-1-kieran.bingham@ideasonboard.com>\n\t<20240911211816.73763-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240911211816.73763-3-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]