[{"id":31177,"web_url":"https://patchwork.libcamera.org/comment/31177/","msgid":"<20240911162925.GH4470@pendragon.ideasonboard.com>","date":"2024-09-11T16:29:25","subject":"Re: [PATCH v2 2/2] apps: cam: Print control array sizes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Sep 11, 2024 at 06:24:00PM +0200, Paul Elder wrote:\n> Now that controls can be queried for array information, print it in\n> --list-controls when applicable.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> \n> ---\n> No change in v2\n> ---\n> src/apps/cam/camera_session.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index 37de6c9f3..9c7f84993 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -169,6 +169,11 @@ void CameraSession::listControls() const\n> \t\t\t\tstd::cout << \" - \" << id->enumToString(val) << \" (\" << val << \")\" << std::endl;\n> \t\t\t}\n> \t\t}\n> +\n> +\t\tif (id->isArray()) {\n> +\t\t\tstd::size_t size = id->size();\n> +\t\t\tstd::cout << \" Size: \" << (size == std::numeric_limits::max() ? \"n\" : std::to_string(size)) << std::endl;\n\nToo long. With that fixed,\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t}\n> \t}\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AB69C324C\n\tfor ;\n\tWed, 11 Sep 2024 16:30:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D45C9634FF;\n\tWed, 11 Sep 2024 18:30:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3DD4618FB\n\tfor ;\n\tWed, 11 Sep 2024 18:29:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05685BEB;\n\tWed, 11 Sep 2024 18:28:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gqb3xqT3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726072122;\n\tbh=v6IU0AeNuaLrKU2Ek36QObX5OoY/l/FQTYYpMLzX+KQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gqb3xqT3ni87r+pquQCSAbpD5YqYvkdAOL4R4p9uI2jAVJQEd8jrZ2gGythwWEy3A\n\t5HQHhf/vsn/sbC7vFDwU4tgLlA0MB44CYm0/YR7p6OqiuT4PgzctWMII6L0a5JJHce\n\tysotRVMVWJ0mp+Qep6u4nXECcbT4+J/8y4LR/2Fs=","Date":"Wed, 11 Sep 2024 19:29:25 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 2/2] apps: cam: Print control array sizes","Message-ID":"<20240911162925.GH4470@pendragon.ideasonboard.com>","References":"<20240911162400.1906661-1-paul.elder@ideasonboard.com>\n\t<20240911162400.1906661-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240911162400.1906661-3-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]