[{"id":31157,"web_url":"https://patchwork.libcamera.org/comment/31157/","msgid":"<172600386641.412786.13067261429718766337@ping.linuxembedded.co.uk>","date":"2024-09-10T21:31:06","subject":"Re: [PATCH 3/3] py: Add bindings for ControlId enum name","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2024-09-10 21:48:12)\n> Add python bindings for quering enum value names from a ControlId.\n\ns/quering/querying/\n\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> ---\n> New in v2\n> ---\n>  src/py/libcamera/py_main.cpp | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index ab33f38a8..f6aff5005 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -404,7 +404,8 @@ PYBIND11_MODULE(_libcamera, m)\n>                 .def(\"__repr__\", [](const ControlId &self) {\n>                         return py::str(\"libcamera.ControlId({}, {}, {})\")\n>                                 .format(self.id(), self.name(), self.type());\n> -               });\n> +               })\n> +               .def(\"enum_name\", &ControlId::enumName);\n\nLooks too easy ? ;-)\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n>  \n>         pyControlInfo\n>                 .def_property_readonly(\"min\", [](const ControlInfo &self) {\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E62DABF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Sep 2024 21:31:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BE1F634F5;\n\tTue, 10 Sep 2024 23:31:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C3EE634E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Sep 2024 23:31:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A09EE3EA;\n\tTue, 10 Sep 2024 23:29:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vSbFxvGE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726003791;\n\tbh=PGf2bEM/5wOG7T7jjDpwpwAgbcD2Z6X7saU+o8vB+jo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vSbFxvGEn9Qo7OD0UGLgiS4D8w9Qmw9LYXEZHudF1rXuK5/YbDsEHeUmMxUZHqhKL\n\tJPRL1n6dAc3K7UFN0dZF8tyDzAgPS2R/XQLqnjMXLLm8Gs4Xd6NB+pCuAH0cGLmNDf\n\trpODkt0aIM0NuD1cvxbOoi4cQ1EPNZ8x6PGNpIio=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240910204812.2581246-4-paul.elder@ideasonboard.com>","References":"<20240910204812.2581246-1-paul.elder@ideasonboard.com>\n\t<20240910204812.2581246-4-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH 3/3] py: Add bindings for ControlId enum name","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Paul Elder <paul.elder@ideasonboard.com>, stefan.klug@ideasonboard.com","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 10 Sep 2024 22:31:06 +0100","Message-ID":"<172600386641.412786.13067261429718766337@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]