[{"id":31161,"web_url":"https://patchwork.libcamera.org/comment/31161/","msgid":"<2824780f-6645-4293-a924-0b901a4fe2e5@ideasonboard.com>","date":"2024-09-11T06:27:02","subject":"Re: [PATCH 2/3] apps: cam: Print control enum values more nicely","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul\n\nThank you for the patch\n\nOn 11/09/24 2:18 am, Paul Elder wrote:\n> Now that enum names can be obtained from ControlId, use that information\n> to print out the list of supported enum values in --list-controls.\n>\n> Signed-off-by: Paul Elder \n\nReviewed-by: Umang Jain \n>\n> ---\n> No change in v2\n> ---\n> src/apps/cam/camera_session.cpp | 12 ++++++++++--\n> 1 file changed, 10 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index 097dc4792..964f2e8c3 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -159,8 +159,16 @@ CameraSession::~CameraSession()\n> void CameraSession::listControls() const\n> {\n> \tfor (const auto &[id, info] : camera_->controls()) {\n> -\t\tstd::cout << \"Control: \" << id->name() << \": \"\n> -\t\t\t << info.toString() << std::endl;\n> +\t\tif (info.values().size() == 0) {\n> +\t\t\tstd::cout << \"Control: \" << id->name() << \": \"\n> +\t\t\t\t << info.toString() << std::endl;\n> +\t\t} else {\n> +\t\t\tstd::cout << \"Control: \" << id->name() << \": \" << std::endl;\n> +\t\t\tfor (const auto &value : info.values()) {\n> +\t\t\t\tint32_t val = value.get();\n> +\t\t\t\tstd::cout << \" - \" << id->enumName(val) << \" (\" << val << \")\" << std::endl;\n> +\t\t\t}\n> +\t\t}\n> \t}\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A2E2C324C\n\tfor ;\n\tWed, 11 Sep 2024 06:27:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DC88634F5;\n\tWed, 11 Sep 2024 08:27:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7E7D618F1\n\tfor ;\n\tWed, 11 Sep 2024 08:27:07 +0200 (CEST)","from [IPV6:2405:201:2015:f873:c173:4b:4a04:3a21] (unknown\n\t[IPv6:2405:201:2015:f873:c173:4b:4a04:3a21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BBD05B3;\n\tWed, 11 Sep 2024 08:25:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bQ+fUhNY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726035950;\n\tbh=8DhrrB+jFuJI8nuIRCK4lGDdlPqse9yL29SlTbzvO2w=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=bQ+fUhNYPoA7ouxbX62yEliv4y2/Do+jC/RtsyTrMIAitpWOU2lwdgaQSuSDuhnPS\n\tGETxxWBptyzQlTK9wCdXYhNBYZ2aH7a8H09wtNP9nN9So84ZCf+UOg6WcvQHGSBjMB\n\tI8/PLG0zXrxIZNVPDcPOzlJUETuK5nWp7YwH0+gU=","Message-ID":"<2824780f-6645-4293-a924-0b901a4fe2e5@ideasonboard.com>","Date":"Wed, 11 Sep 2024 11:57:02 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/3] apps: cam: Print control enum values more nicely","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"stefan.klug@ideasonboard.com","References":"<20240910204812.2581246-1-paul.elder@ideasonboard.com>\n\t<20240910204812.2581246-3-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240910204812.2581246-3-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]