[{"id":31127,"web_url":"https://patchwork.libcamera.org/comment/31127/","msgid":"<172588788702.2319503.926584602336894130@ping.linuxembedded.co.uk>","date":"2024-09-09T13:18:07","subject":"Re: [PATCH v11 7/7] libcamera: software_isp: Refactor SoftwareIsp to\n\tuse DmaBufAllocator::exportBuffers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Harvey Yang (2024-09-07 15:28:32)\n> As the helper function DmaBufAllocator::exportBuffers is added, we can\n> avoid some code duplication in SoftwareIsp as well.\n> \n> Signed-off-by: Harvey Yang \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n> 1 file changed, 1 insertion(+), 19 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 1140372c..3455f13a 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -255,25 +255,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n> if (stream == nullptr)\n> return -EINVAL;\n> \n> - for (unsigned int i = 0; i < count; i++) {\n> - const std::string name = \"frame-\" + std::to_string(i);\n> - const size_t frameSize = debayer_->frameSize();\n> -\n> - FrameBuffer::Plane outPlane;\n> - outPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n> - if (!outPlane.fd.isValid()) {\n> - LOG(SoftwareIsp, Error)\n> - << \"failed to allocate a dma_buf\";\n> - return -ENOMEM;\n> - }\n> - outPlane.offset = 0;\n> - outPlane.length = frameSize;\n> -\n> - std::vector planes{ outPlane };\n> - buffers->emplace_back(std::make_unique(std::move(planes)));\n> - }\n> -\n> - return count;\n> + return dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n> }\n> \n> /**\n> -- \n> 2.46.0.469.g59c65b2a67-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40426BF415\n\tfor ;\n\tMon, 9 Sep 2024 13:18:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D664634F9;\n\tMon, 9 Sep 2024 15:18:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FBCF634EE\n\tfor ;\n\tMon, 9 Sep 2024 15:18:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 025323DA;\n\tMon, 9 Sep 2024 15:16:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p8lCahXt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725887814;\n\tbh=wWSBiw7Snd3o1to9TxCTAgc7odr7qYZ7g2+Uvcfsc2U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=p8lCahXtGvzsYWIqyX/naofoiR5Y9YGurS+DnjOFqnETLAqw/ikB8UD3ATe+3C4TS\n\tqyC/NCOr+cVwZ0BX5oQenuPn6LhbvAom6zWCQYfnWnXGyzdCgYo+fgmLzeB47u3t2w\n\tlSF6dknSStwSpMMO9lJgmUzhlfgh0yJlN4+b2IeA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240907143110.2210711-8-chenghaoyang@google.com>","References":"<20240907143110.2210711-1-chenghaoyang@google.com>\n\t<20240907143110.2210711-8-chenghaoyang@google.com>","Subject":"Re: [PATCH v11 7/7] libcamera: software_isp: Refactor SoftwareIsp to\n\tuse DmaBufAllocator::exportBuffers","From":"Kieran Bingham ","Cc":"Harvey Yang ,\n\tHarvey Yang ,\n\tMilan Zamazal ","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 09 Sep 2024 14:18:07 +0100","Message-ID":"<172588788702.2319503.926584602336894130@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]