[{"id":2814,"web_url":"https://patchwork.libcamera.org/comment/2814/","msgid":"<20191007033703.GL4740@pendragon.ideasonboard.com>","date":"2019-10-07T03:37:03","subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: meson: Allow IPAs to\n\tinclude internal headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for thr patch.\n\nOn Sun, Oct 06, 2019 at 10:08:50PM +0200, Jacopo Mondi wrote:\n> Extend the list of inclusion paths for the IPA modules in src/ipa/ to\n> include internal libcamera headers.\n> \n> Only Open Source IPA implementations will live in src/ipa/ and they link\n> against libcamera, so they should be able to include internal headers as\n> well as public ones.\n\nThe contents look good, but the commit message is now a bit outdated.\nHow about the following ?\n\n----\nipa: meson: Give IPAs access to internal libcamera APIs\n\nOpen source IPA implementations can benefit from usage of libcamera\ninternal APIs. Allow this by compiling against the internal headers and\nlinking against libcamera.\n----\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/meson.build | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index b5bcd7b2c3db..ac16e1da6126 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -5,10 +5,16 @@ ipa_vimc_sources = [\n> \n> ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> \n> +ipa_includes = [\n> + libcamera_includes,\n> + libcamera_internal_includes,\n> +]\n> +\n> foreach t : ipa_vimc_sources\n> ipa = shared_module(t[0], 'ipa_vimc.cpp',\n> name_prefix : '',\n> - include_directories : libcamera_includes,\n> + include_directories : ipa_includes,\n> + dependencies : libcamera_dep,\n> install : true,\n> install_dir : ipa_install_dir,\n> cpp_args : '-DLICENSE=\"' + t[1] + '\"')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14A9B60BC6\n\tfor ;\n\tMon, 7 Oct 2019 05:37:07 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(modemcable151.96-160-184.mc.videotron.ca [184.160.96.151])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32175DD;\n\tMon, 7 Oct 2019 05:37:06 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570419426;\n\tbh=clIgwQUj4qHa7nbtUX93aDzI6eCPteAzi5UEypyMIYs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jkjfvQcio7ytMKl3Y6LjdJZwuT5JdFAg3QL48ndshLQbP+AlXQ1bK2qVnC81l4iZW\n\tivYfPH8q8Xy+8E51DZmIHdA4yKtpUmcr10a143eKeTBGzMVzrOm6xG0yVY1ko5sA0H\n\tUVtq1dJ6FjLSVY4pc9mnDRvWQ5J4j8pVtim1vTu8=","Date":"Mon, 7 Oct 2019 06:37:03 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191007033703.GL4740@pendragon.ideasonboard.com>","References":"<20191006200852.11775-1-jacopo@jmondi.org>\n\t<20191006200852.11775-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191006200852.11775-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: meson: Allow IPAs to\n\tinclude internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 07 Oct 2019 03:37:07 -0000"}}]