{"id":2117,"url":"https://patchwork.libcamera.org/api/patches/2117/?format=json","web_url":"https://patchwork.libcamera.org/patch/2117/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191006200852.11775-2-jacopo@jmondi.org>","date":"2019-10-06T20:08:48","name":"[libcamera-devel,v3,1/5] ipa: vimc: Rename ipa_dummy to ipa_vimc","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b98fc412b807c012e0ca7aec123eb87acc1c7e74","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2117/mbox/","series":[{"id":524,"url":"https://patchwork.libcamera.org/api/series/524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=524","date":"2019-10-06T20:08:47","name":"test: Add IPA interface test support","version":3,"mbox":"https://patchwork.libcamera.org/series/524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2117/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2117/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F164F60E1E\n\tfor ;\n\tSun, 6 Oct 2019 22:07:12 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AC907C0003\n\tfor ;\n\tSun, 6 Oct 2019 20:07:12 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 6 Oct 2019 22:08:48 +0200","Message-Id":"<20191006200852.11775-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191006200852.11775-1-jacopo@jmondi.org>","References":"<20191006200852.11775-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/5] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Oct 2019 20:07:13 -0000"},"content":"The DummyIPA is actually a test IPA module for the virtual media\ncontroller driver VIMC. Rename it accordingly to its usage.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} | 10 +++++-----\n src/ipa/meson.build | 10 +++++-----\n test/ipa/ipa_test.cpp | 2 +-\n 3 files changed, 11 insertions(+), 11 deletions(-)\n rename src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} (71%)","diff":"diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_vimc.cpp\nsimilarity index 71%\nrename from src/ipa/ipa_dummy.cpp\nrename to src/ipa/ipa_vimc.cpp\nindex 9d0cbdc8b1ad..abc06e7f5fd5 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_vimc.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n+ * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n */\n \n #include \n@@ -12,15 +12,15 @@\n \n namespace libcamera {\n \n-class IPADummy : public IPAInterface\n+class IPAVimc : public IPAInterface\n {\n public:\n \tint init();\n };\n \n-int IPADummy::init()\n+int IPAVimc::init()\n {\n-\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n+\tstd::cout << \"initializing vimc IPA!\" << std::endl;\n \treturn 0;\n }\n \n@@ -39,7 +39,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \n IPAInterface *ipaCreate()\n {\n-\treturn new IPADummy();\n+\treturn new IPAVimc();\n }\n };\n \ndiff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex f09915bc1388..b5bcd7b2c3db 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -1,12 +1,12 @@\n-ipa_dummy_sources = [\n- ['ipa_dummy', 'LGPL-2.1-or-later'],\n- ['ipa_dummy_isolate', 'Proprietary'],\n+ipa_vimc_sources = [\n+ ['ipa_vimc', 'LGPL-2.1-or-later'],\n+ ['ipa_vimc_isolate', 'Proprietary'],\n ]\n \n ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n \n-foreach t : ipa_dummy_sources\n- ipa = shared_module(t[0], 'ipa_dummy.cpp',\n+foreach t : ipa_vimc_sources\n+ ipa = shared_module(t[0], 'ipa_vimc.cpp',\n name_prefix : '',\n include_directories : libcamera_includes,\n install : true,\ndiff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex b9e1bd61c299..8f9b2d8058ec 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -62,7 +62,7 @@ protected:\n \t\t\t\"GPL-2.0-or-later\",\n \t\t};\n \n-\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n+\t\tcount += runTest(\"src/ipa/ipa_vimc.so\", testInfo);\n \n \t\tif (count < 0)\n \t\t\treturn TestFail;\n","prefixes":["libcamera-devel","v3","1/5"]}