[{"id":31078,"web_url":"https://patchwork.libcamera.org/comment/31078/","msgid":"<87ikvd3z45.fsf@redhat.com>","date":"2024-09-03T08:44:42","subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for handling this.\n\nLaurent Pinchart writes:\n\n> The ipa_interface.h file includes a number of headers that are not\n> directly used. Remove them, and add them to the source files that\n> include ipa_interface.h as required.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/ipa/ipa_interface.h | 7 -------\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> src/ipa/vimc/vimc.cpp | 1 +\n> src/libcamera/pipeline/vimc/vimc.cpp | 3 +++\n> .../libcamera_templates/core_ipa_interface.h.tmpl | 4 ++++\n> .../libcamera_templates/module_ipa_interface.h.tmpl | 7 +++++++\n> 7 files changed, 18 insertions(+), 7 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 2fdc085e771f..dce9637a2238 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,13 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -\n> -#include \n> -#include \n> -#include \n> -\n> namespace libcamera {\n> \n> /*\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 6ebf7c1dcab4..10a8c86d8e64 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -23,7 +23,9 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index f164d7c51ccf..78d2c375d6dc 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -18,6 +18,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index ebd63fa6cc09..5495401f1731 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 0ec9928eec23..325174b90087 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> #include \n> \n> @@ -21,6 +22,8 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> #include \n> #include \n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> index 590135b88421..3942e5708d98 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> @@ -18,6 +18,10 @@\n> {% if has_string %}#include {% endif %}\n> {% if has_array %}#include {% endif %}\n> \n> +#include \n> +#include \n> +#include \n> +\n> #include \n> \n> namespace libcamera {\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> index 0111d0c4c591..5d70ea6a2c29 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> @@ -18,6 +18,13 @@\n> {% if has_string %}#include {% endif %}\n> {% if has_array %}#include {% endif %}\n> \n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +\n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62BC2C324C\n\tfor ;\n\tTue, 3 Sep 2024 08:44:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E713634CB;\n\tTue, 3 Sep 2024 10:44:49 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A019F6345D\n\tfor ;\n\tTue, 3 Sep 2024 10:44:47 +0200 (CEST)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-353-fhXA-UUbMbabvgILkaWgBQ-1; Tue, 03 Sep 2024 04:44:45 -0400","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-42bbd062ac1so36725715e9.0\n\tfor ;\n\tTue, 03 Sep 2024 01:44:45 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42c89dca8absm17533185e9.27.2024.09.03.01.44.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 03 Sep 2024 01:44:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dfRL3BRU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725353086;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=jxKX773PwcM1OPxaImsUecrJfoO2sXw2FmNSPt9ljlc=;\n\tb=dfRL3BRUxTruUwahyEUXYn/zTXSraT7EeqUqxePHEYFcuzcmFlKaQIeFnaOJP2iVxhsgsF\n\tIganDB3X06fHzNnVAWyn/pYIk1Rn+CLrg2vo8/nysGFQqJLXTRK0trg2onLLOO/vvM1Hjb\n\t6/fYclv2XsN0++On3uv87NaZ2a2aweI=","X-MC-Unique":"fhXA-UUbMbabvgILkaWgBQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725353084; x=1725957884;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jxKX773PwcM1OPxaImsUecrJfoO2sXw2FmNSPt9ljlc=;\n\tb=ZNa3/j6vpx3xjeUlh6Urg4bsaLQXDMDvNJCN62UorlzAcfOXb0svBTxtLF4eCxVr/M\n\t1WEAUyR7VXskNjMwc/JH4HMiGUkgdGfoLqsaRWks0R22TEZoFOx0V3jCjsShq7/cQJZ/\n\tlBb2v310ufaEd11Q2NlPWAoRqSPDfcTQQ3ClU6g+Yb8J4+/MmCea6ZQsookS+NeqodLY\n\tlIQV7jKciNPl/TsThL0xxeC9o4h5O3ppbeGt6gqBHLwZsHJ17sL1GXGSTUDdKoN3r/ko\n\thYdDrrW1BQ2NLK7I3rQK1qreG/daSbwpkmxteyOdpjYMJB2ECtf8iosQnxLu526CMJV+\n\tocFA==","X-Gm-Message-State":"AOJu0YwaAfjfDzaf/e/GODSAAV1+0jMwnMQlle2iqFp55dGFLBBM+mFH\n\tXM8VZdL1HjEWpMvRyWmXqbfD+3KBEphgx58d2sjN7wVwt4dWJY+X2RUD8AX1QzpfF63BfWmLRTX\n\tdGpAlNdxo4YnJkPN4iPdmK17f3HU5VA/G/L3pf2PiTjJlgqdwBse8Va+WwypIROhLEWtLajc=","X-Received":["by 2002:a05:600c:3503:b0:428:2e9:6573 with SMTP id\n\t5b1f17b1804b1-42bdc6370a2mr69023815e9.17.1725353084009; \n\tTue, 03 Sep 2024 01:44:44 -0700 (PDT)","by 2002:a05:600c:3503:b0:428:2e9:6573 with SMTP id\n\t5b1f17b1804b1-42bdc6370a2mr69023665e9.17.1725353083524; \n\tTue, 03 Sep 2024 01:44:43 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEpC9nApGiqZrBL8sr/6IS7Hh8xSDT4chaxjOZHI+tdGr6YSGje9CFrLUI5B+4gw2zOPlCIfw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Paul Elder\n\t","Subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","In-Reply-To":"<20240902221317.19005-2-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Tue, 3 Sep 2024 01:13:17 +0300\")","References":"<20240902221317.19005-1-laurent.pinchart@ideasonboard.com>\n\t<20240902221317.19005-2-laurent.pinchart@ideasonboard.com>","Date":"Tue, 03 Sep 2024 10:44:42 +0200","Message-ID":"<87ikvd3z45.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31088,"web_url":"https://patchwork.libcamera.org/comment/31088/","msgid":"<172544773069.129190.16196313446944815895@ping.linuxembedded.co.uk>","date":"2024-09-04T11:02:10","subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-09-02 23:13:17)\n> The ipa_interface.h file includes a number of headers that are not\n> directly used. Remove them, and add them to the source files that\n> include ipa_interface.h as required.\n\nDid you work through this manually? Or use a tool (like iwyu?). I saw\nsome mails where Milan has referenced LSP ? What's that?\n\nAnyway,\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/ipa/ipa_interface.h | 7 -------\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> src/ipa/vimc/vimc.cpp | 1 +\n> src/libcamera/pipeline/vimc/vimc.cpp | 3 +++\n> .../libcamera_templates/core_ipa_interface.h.tmpl | 4 ++++\n> .../libcamera_templates/module_ipa_interface.h.tmpl | 7 +++++++\n> 7 files changed, 18 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 2fdc085e771f..dce9637a2238 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,13 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -\n> -#include \n> -#include \n> -#include \n> -\n> namespace libcamera {\n> \n> /*\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 6ebf7c1dcab4..10a8c86d8e64 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -23,7 +23,9 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index f164d7c51ccf..78d2c375d6dc 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -18,6 +18,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index ebd63fa6cc09..5495401f1731 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 0ec9928eec23..325174b90087 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> #include \n> \n> @@ -21,6 +22,8 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> #include \n> #include \n> \n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> index 590135b88421..3942e5708d98 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> @@ -18,6 +18,10 @@\n> {% if has_string %}#include {% endif %}\n> {% if has_array %}#include {% endif %}\n> \n> +#include \n> +#include \n> +#include \n> +\n> #include \n> \n> namespace libcamera {\n> diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> index 0111d0c4c591..5d70ea6a2c29 100644\n> --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> @@ -18,6 +18,13 @@\n> {% if has_string %}#include {% endif %}\n> {% if has_array %}#include {% endif %}\n> \n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +\n> #include \n> #include \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4578DC324C\n\tfor ;\n\tWed, 4 Sep 2024 11:02:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E48F7634E4;\n\tWed, 4 Sep 2024 13:02:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60B8F618FE\n\tfor ;\n\tWed, 4 Sep 2024 13:02:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E23B42E3;\n\tWed, 4 Sep 2024 13:01:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gxHseXS0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725447661;\n\tbh=1MEysv5VrloMkywks/80JUvJuddoXtfWmb4PdvGsIP4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gxHseXS0kFYAktcsbY/OzkF+PkQSrtEthhN/R2AdAXX+Zlthb2BsiYrzN5Gca13ev\n\toDfmiYyqJoss/8vFJEij7620jlX+b57oUO86ixhnzwNaBj/MqZ/F7RprxkVlX+Yh2F\n\tfSSO64ZlGLc7zJAztRgroH47o3Mcei+viWqyqW/Q=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240902221317.19005-2-laurent.pinchart@ideasonboard.com>","References":"<20240902221317.19005-1-laurent.pinchart@ideasonboard.com>\n\t<20240902221317.19005-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","From":"Kieran Bingham ","Cc":"Paul Elder ,\n\tMilan Zamazal ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 04 Sep 2024 12:02:10 +0100","Message-ID":"<172544773069.129190.16196313446944815895@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31089,"web_url":"https://patchwork.libcamera.org/comment/31089/","msgid":"<20240904110746.GI16183@pendragon.ideasonboard.com>","date":"2024-09-04T11:07:46","subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 04, 2024 at 12:02:10PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-09-02 23:13:17)\n> > The ipa_interface.h file includes a number of headers that are not\n> > directly used. Remove them, and add them to the source files that\n> > include ipa_interface.h as required.\n> \n> Did you work through this manually? Or use a tool (like iwyu?).\n\nThis series is a follow-up on Milan's patch series, so it's manual.\n\n> I saw\n> some mails where Milan has referenced LSP ? What's that?\n\nLSP stands for Language Server Protocol. It's a protocol to communicate\nbetween code editors and components that know how to interpret a\nparticular language, to handle things like syntax highlighting, code\nlinting and other checks. It allows decoupling the language-specific\nbackends from the editors. I think it was initially developed for VS\ncode. Saying that \"LSP\" reported an issue is a bit of a language abuse I\nthink, it's the C++-specific backend, in this case clangd, that reported\nthe problems. A different C++ server would likely report different\nissues.\n\n> Anyway,\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/ipa/ipa_interface.h | 7 -------\n> > src/ipa/ipu3/ipu3.cpp | 2 ++\n> > src/ipa/rkisp1/rkisp1.cpp | 1 +\n> > src/ipa/vimc/vimc.cpp | 1 +\n> > src/libcamera/pipeline/vimc/vimc.cpp | 3 +++\n> > .../libcamera_templates/core_ipa_interface.h.tmpl | 4 ++++\n> > .../libcamera_templates/module_ipa_interface.h.tmpl | 7 +++++++\n> > 7 files changed, 18 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > index 2fdc085e771f..dce9637a2238 100644\n> > --- a/include/libcamera/ipa/ipa_interface.h\n> > +++ b/include/libcamera/ipa/ipa_interface.h\n> > @@ -7,13 +7,6 @@\n> > \n> > #pragma once\n> > \n> > -#include \n> > -#include \n> > -\n> > -#include \n> > -#include \n> > -#include \n> > -\n> > namespace libcamera {\n> > \n> > /*\n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index 6ebf7c1dcab4..10a8c86d8e64 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -23,7 +23,9 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > +#include \n> > #include \n> > \n> > #include \n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index f164d7c51ccf..78d2c375d6dc 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -18,6 +18,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> > index ebd63fa6cc09..5495401f1731 100644\n> > --- a/src/ipa/vimc/vimc.cpp\n> > +++ b/src/ipa/vimc/vimc.cpp\n> > @@ -14,6 +14,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > #include \n> > \n> > #include \n> > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> > index 0ec9928eec23..325174b90087 100644\n> > --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> > @@ -14,6 +14,7 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > #include \n> > #include \n> > \n> > @@ -21,6 +22,8 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > +#include \n> > #include \n> > #include \n> > \n> > diff --git a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> > index 590135b88421..3942e5708d98 100644\n> > --- a/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> > +++ b/utils/codegen/ipc/generators/libcamera_templates/core_ipa_interface.h.tmpl\n> > @@ -18,6 +18,10 @@\n> > {% if has_string %}#include {% endif %}\n> > {% if has_array %}#include {% endif %}\n> > \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > #include \n> > \n> > namespace libcamera {\n> > diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> > index 0111d0c4c591..5d70ea6a2c29 100644\n> > --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> > +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_interface.h.tmpl\n> > @@ -18,6 +18,13 @@\n> > {% if has_string %}#include {% endif %}\n> > {% if has_array %}#include {% endif %}\n> > \n> > +#include \n> > +#include \n> > +\n> > +#include \n> > +#include \n> > +#include \n> > +\n> > #include \n> > #include \n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E582BF415\n\tfor ;\n\tWed, 4 Sep 2024 11:08:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E2BE634E7;\n\tWed, 4 Sep 2024 13:08:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7D67618FE\n\tfor ;\n\tWed, 4 Sep 2024 13:08:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2048B3C7;\n\tWed, 4 Sep 2024 13:07:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KZmPVrqe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725448027;\n\tbh=eyVK2aUFpPnO3uEsDelb1s7/ub71TcNpzBteB3Ye+Rk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KZmPVrqeXXt2BAOCt9MghWsybD9ud+28v0BjTrlWWEpOEyIaqotLVMGfjcOsRuNhy\n\t2tw+WSSRuW9h36YTxySAUVsSlArM5yyR7TK4/nOfdbocasf6ICLH0yQyg835hpJmc0\n\t9PrgzgY3ttsBYb6KD0f4HqdH+h/ldVZNBercFjJs=","Date":"Wed, 4 Sep 2024 14:07:46 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ,\n\tMilan Zamazal ","Subject":"Re: [PATCH 2/2] libcamera: ipa: Drop unneded includes from\n\tipa_interface.h","Message-ID":"<20240904110746.GI16183@pendragon.ideasonboard.com>","References":"<20240902221317.19005-1-laurent.pinchart@ideasonboard.com>\n\t<20240902221317.19005-2-laurent.pinchart@ideasonboard.com>\n\t<172544773069.129190.16196313446944815895@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172544773069.129190.16196313446944815895@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]