[{"id":31072,"web_url":"https://patchwork.libcamera.org/comment/31072/","msgid":"<20240902194630.GO1995@pendragon.ideasonboard.com>","date":"2024-09-02T19:46:30","subject":"Re: [PATCH v3 18/18] libcamera: includes: Formatting improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:11PM +0200, Milan Zamazal wrote:\n> The LSP autoformatter doesn't like some of the current formatting, let's\n> make it happier. Note that not all of its suggestions were accepted\n> because readability is preferred and adjusting .clang-format may not be\n> easy or possible.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/utils.h | 2 +-\n> include/libcamera/internal/ipa_data_serializer.h | 7 ++++---\n> 2 files changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 98c683a7..a9b27d0f 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -12,8 +12,8 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 13470a89..66d9a19f 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> #include \n> +\n> #include \n> \n> #include \"libcamera/internal/control_serializer.h\"\n> @@ -161,7 +162,7 @@ public:\n> \t\tstd::vector::const_iterator fdIter = fdsBegin;\n> \t\tfor (uint32_t i = 0; i < vecLen; i++) {\n> \t\t\tuint32_t sizeofData = readPOD(dataIter, 0, dataEnd);\n> -\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n> +\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n> \t\t\tdataIter += 8;\n> \n> \t\t\tret[i] = IPADataSerializer::deserialize(dataIter,\n> @@ -268,7 +269,7 @@ public:\n> \t\tstd::vector::const_iterator fdIter = fdsBegin;\n> \t\tfor (uint32_t i = 0; i < mapLen; i++) {\n> \t\t\tuint32_t sizeofData = readPOD(dataIter, 0, dataEnd);\n> -\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n> +\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n> \t\t\tdataIter += 8;\n> \n> \t\t\tK key = IPADataSerializer::deserialize(dataIter,\n> @@ -280,7 +281,7 @@ public:\n> \t\t\tdataIter += sizeofData;\n> \t\t\tfdIter += sizeofFds;\n> \t\t\tsizeofData = readPOD(dataIter, 0, dataEnd);\n> -\t\t\tsizeofFds = readPOD(dataIter, 4, dataEnd);\n> +\t\t\tsizeofFds = readPOD(dataIter, 4, dataEnd);\n> \t\t\tdataIter += 8;\n> \n> \t\t\tconst V value = IPADataSerializer::deserialize(dataIter,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CBFCC324C\n\tfor ;\n\tMon, 2 Sep 2024 19:47:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44DCF63471;\n\tMon, 2 Sep 2024 21:47:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B876A618FF\n\tfor ;\n\tMon, 2 Sep 2024 21:47:03 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4821B4CE;\n\tMon, 2 Sep 2024 21:45:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rdj8vB5X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725306352;\n\tbh=tsB82clOeDod8xw1Blr8TcH+o0673WYFsxHlHofi6ko=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rdj8vB5XrxikJyJxQCclFyikp4uTeQT6ZMD2r+Wirm8die6NMQQJSPih1PpPxI0jq\n\tE3HZOXHkcSZ+eXP2tih2iU4uZr+OJJ5u2pthE2xufoF2HG4DfgjuxvEGKBHHt0xhf1\n\tzvTNi7gg+SMT4VGhtxQyMopEXp4kwVt/dda60Um4=","Date":"Mon, 2 Sep 2024 22:46:30 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 18/18] libcamera: includes: Formatting improvements","Message-ID":"<20240902194630.GO1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-19-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-19-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]