[{"id":31071,"web_url":"https://patchwork.libcamera.org/comment/31071/","msgid":"<20240902194552.GN1995@pendragon.ideasonboard.com>","date":"2024-09-02T19:45:52","subject":"Re: [PATCH v3 17/18] libcamera: includes: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:10PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/libcamera/base/event_dispatcher.h            | 2 --\n>  include/libcamera/base/log.h                         | 1 -\n>  include/libcamera/base/memfd.h                       | 2 --\n>  include/libcamera/base/signal.h                      | 1 -\n>  include/libcamera/base/span.h                        | 1 -\n>  include/libcamera/base/timer.h                       | 1 -\n>  include/libcamera/base/utils.h                       | 1 -\n>  include/libcamera/framebuffer.h                      | 1 -\n>  include/libcamera/internal/camera_manager.h          | 1 -\n>  include/libcamera/internal/camera_sensor.h           | 1 -\n>  include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n>  include/libcamera/internal/dma_buf_allocator.h       | 2 --\n>  include/libcamera/internal/formats.h                 | 1 -\n>  include/libcamera/internal/ipa_data_serializer.h     | 4 ----\n>  include/libcamera/internal/ipa_proxy.h               | 2 --\n>  include/libcamera/internal/ipc_pipe_unixsocket.h     | 1 -\n>  include/libcamera/internal/media_device.h            | 1 -\n>  include/libcamera/internal/pipeline_handler.h        | 3 ---\n>  include/libcamera/internal/shared_mem_object.h       | 1 -\n>  include/libcamera/pixel_format.h                     | 1 -\n>  include/libcamera/request.h                          | 1 -\n>  include/libcamera/stream.h                           | 1 -\n>  include/libcamera/transform.h                        | 2 --\n>  23 files changed, 33 deletions(-)\n> \n> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n> index e9a09c6e..408f8da6 100644\n> --- a/include/libcamera/base/event_dispatcher.h\n> +++ b/include/libcamera/base/event_dispatcher.h\n> @@ -7,8 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <vector>\n> -\n>  #include <libcamera/base/private.h>\n>  \n>  namespace libcamera {\n> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> index df27df03..62093012 100644\n> --- a/include/libcamera/base/log.h\n> +++ b/include/libcamera/base/log.h\n> @@ -7,7 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <chrono>\n>  #include <sstream>\n>  \n>  #include <libcamera/base/private.h>\n> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> index b0edd2de..705d9929 100644\n> --- a/include/libcamera/base/memfd.h\n> +++ b/include/libcamera/base/memfd.h\n> @@ -7,8 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <stddef.h>\n> -\n>  #include <libcamera/base/flags.h>\n>  #include <libcamera/base/unique_fd.h>\n>  \n> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> index 849fbbda..bbff1495 100644\n> --- a/include/libcamera/base/signal.h\n> +++ b/include/libcamera/base/signal.h\n> @@ -10,7 +10,6 @@\n>  #include <functional>\n>  #include <list>\n>  #include <type_traits>\n> -#include <vector>\n>  \n>  #include <libcamera/base/bound_method.h>\n>  \n> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n> index c3e63f69..92cce4f0 100644\n> --- a/include/libcamera/base/span.h\n> +++ b/include/libcamera/base/span.h\n> @@ -10,7 +10,6 @@\n>  #include <array>\n>  #include <iterator>\n>  #include <limits>\n> -#include <stddef.h>\n>  #include <type_traits>\n>  \n>  namespace libcamera {\n> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n> index 5ef45959..9646a0fe 100644\n> --- a/include/libcamera/base/timer.h\n> +++ b/include/libcamera/base/timer.h\n> @@ -8,7 +8,6 @@\n>  #pragma once\n>  \n>  #include <chrono>\n> -#include <stdint.h>\n>  \n>  #include <libcamera/base/private.h>\n>  \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 734ff81e..98c683a7 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -10,7 +10,6 @@\n>  #include <algorithm>\n>  #include <chrono>\n>  #include <iterator>\n> -#include <memory>\n>  #include <ostream>\n>  #include <sstream>\n>  #include <string>\n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index 5ae2270b..ff839243 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -7,7 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <assert.h>\n>  #include <limits>\n>  #include <memory>\n>  #include <stdint.h>\n> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> index e098cb69..0150ca61 100644\n> --- a/include/libcamera/internal/camera_manager.h\n> +++ b/include/libcamera/internal/camera_manager.h\n> @@ -9,7 +9,6 @@\n>  \n>  #include <libcamera/camera_manager.h>\n>  \n> -#include <map>\n>  #include <memory>\n>  #include <sys/types.h>\n>  #include <vector>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index fc44ab98..a42c15fa 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -23,7 +23,6 @@\n>  #include <libcamera/ipa/core_ipa_interface.h>\n>  \n>  #include \"libcamera/internal/bayer_format.h\"\n> -#include \"libcamera/internal/formats.h\"\n>  #include \"libcamera/internal/v4l2_subdevice.h\"\n>  \n>  namespace libcamera {\n> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h b/include/libcamera/internal/device_enumerator_sysfs.h\n> index a5bfc711..4ccc9845 100644\n> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n> @@ -7,7 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <memory>\n>  #include <string>\n>  \n>  #include \"libcamera/internal/device_enumerator.h\"\n> diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\n> index 36ec1696..d2a0a0d1 100644\n> --- a/include/libcamera/internal/dma_buf_allocator.h\n> +++ b/include/libcamera/internal/dma_buf_allocator.h\n> @@ -7,8 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <stddef.h>\n> -\n>  #include <libcamera/base/flags.h>\n>  #include <libcamera/base/unique_fd.h>\n>  \n> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> index 71895cd8..6a3e9c16 100644\n> --- a/include/libcamera/internal/formats.h\n> +++ b/include/libcamera/internal/formats.h\n> @@ -8,7 +8,6 @@\n>  #pragma once\n>  \n>  #include <array>\n> -#include <map>\n>  #include <vector>\n>  \n>  #include <libcamera/geometry.h>\n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 337c948c..13470a89 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -7,8 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <deque>\n> -#include <iostream>\n>  #include <string.h>\n>  #include <tuple>\n>  #include <type_traits>\n> @@ -22,8 +20,6 @@\n>  #include <libcamera/geometry.h>\n>  #include <libcamera/ipa/ipa_interface.h>\n>  \n> -#include \"libcamera/internal/byte_stream_buffer.h\"\n> -#include \"libcamera/internal/camera_sensor.h\"\n>  #include \"libcamera/internal/control_serializer.h\"\n>  \n>  namespace libcamera {\n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index 0f564d99..983bcc5f 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -7,9 +7,7 @@\n>  \n>  #pragma once\n>  \n> -#include <memory>\n>  #include <string>\n> -#include <vector>\n>  \n>  #include <libcamera/ipa/ipa_interface.h>\n>  \n> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> index 4a0f6d57..8c972613 100644\n> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> @@ -9,7 +9,6 @@\n>  \n>  #include <map>\n>  #include <memory>\n> -#include <vector>\n>  \n>  #include \"libcamera/internal/ipc_pipe.h\"\n>  #include \"libcamera/internal/ipc_unixsocket.h\"\n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index bf2e475d..e412d3a0 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -8,7 +8,6 @@\n>  #pragma once\n>  \n>  #include <map>\n> -#include <sstream>\n>  #include <string>\n>  #include <vector>\n>  \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index c33cf715..0d380803 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -9,7 +9,6 @@\n>  \n>  #include <memory>\n>  #include <queue>\n> -#include <set>\n>  #include <string>\n>  #include <sys/types.h>\n>  #include <vector>\n> @@ -19,8 +18,6 @@\n>  #include <libcamera/controls.h>\n>  #include <libcamera/stream.h>\n>  \n> -#include \"libcamera/internal/ipa_proxy.h\"\n> -\n>  namespace libcamera {\n>  \n>  class Camera;\n> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> index 2ab0189f..e9f1dacd 100644\n> --- a/include/libcamera/internal/shared_mem_object.h\n> +++ b/include/libcamera/internal/shared_mem_object.h\n> @@ -8,7 +8,6 @@\n>   */\n>  #pragma once\n>  \n> -#include <stddef.h>\n>  #include <stdint.h>\n>  #include <string>\n>  #include <sys/mman.h>\n> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> index ea60fe72..1b4d8c7c 100644\n> --- a/include/libcamera/pixel_format.h\n> +++ b/include/libcamera/pixel_format.h\n> @@ -8,7 +8,6 @@\n>  #pragma once\n>  \n>  #include <ostream>\n> -#include <set>\n>  #include <stdint.h>\n>  #include <string>\n>  \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 2c78d9bb..e214a9d1 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -12,7 +12,6 @@\n>  #include <ostream>\n>  #include <stdint.h>\n>  #include <string>\n> -#include <unordered_set>\n>  \n>  #include <libcamera/base/class.h>\n>  #include <libcamera/base/signal.h>\n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index d510238a..071b7169 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -8,7 +8,6 @@\n>  #pragma once\n>  \n>  #include <map>\n> -#include <memory>\n>  #include <ostream>\n>  #include <string>\n>  #include <vector>\n> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n> index a88f809e..4517412a 100644\n> --- a/include/libcamera/transform.h\n> +++ b/include/libcamera/transform.h\n> @@ -7,8 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <string>\n> -\n>  namespace libcamera {\n>  \n>  enum class Orientation;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 795F2C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Sep 2024 19:46:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E8A2618FF;\n\tMon,  2 Sep 2024 21:46:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC076618FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Sep 2024 21:46:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 130564CE;\n\tMon,  2 Sep 2024 21:45:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mQ3K7eJA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725306314;\n\tbh=ewAgkHdILpVhKxoJN3XUnU6swbkGiVQ1sHpOnQ1Ilo0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mQ3K7eJAUVvsCHc8vXUMIg7OtioGbX6WmcSGXrey8h1YH6lm6ERyrAc9/Qw5a0FFm\n\tQHLIE/pJrZ+rOhRIMaLlhUvuDwsuTd6FyesuDo6JAUs53Hi8VwSpSj3Zv4OTlxyOyb\n\tO6i6/pco+UilkE86vnBl5j7fF+nZBDSGQTWx+kdM=","Date":"Mon, 2 Sep 2024 22:45:52 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 17/18] libcamera: includes: Remove unused includes","Message-ID":"<20240902194552.GN1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-18-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-18-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]