[{"id":31069,"web_url":"https://patchwork.libcamera.org/comment/31069/","msgid":"<20240902193215.GL1995@pendragon.ideasonboard.com>","date":"2024-09-02T19:32:15","subject":"Re: [PATCH v3 14/18] libcamera: libcamera: Add missing includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:07PM +0200, Milan Zamazal wrote:\n> Let's add direct includes for classes currently included indirectly,\n> through other header files.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/base/event_dispatcher_poll.cpp | 1 +\n> src/libcamera/camera.cpp | 5 +++++\n> src/libcamera/formats.cpp | 2 ++\n> src/libcamera/ipa_data_serializer.cpp | 2 ++\n> src/libcamera/stream.cpp | 3 +++\n> 5 files changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\n> index 194d7bd2..52bfb34e 100644\n> --- a/src/libcamera/base/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/base/event_dispatcher_poll.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 9d1ae696..a86f552a 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -9,6 +9,11 @@\n> \n> #include \n> #include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 3ee89590..dbefb094 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"libcamera/internal/formats.h\"\n> \n> +#include \n> +\n> #include \n> #include \n> \n> diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp\n> index 3e9bef08..f6dd7e6f 100644\n> --- a/src/libcamera/ipa_data_serializer.cpp\n> +++ b/src/libcamera/ipa_data_serializer.cpp\n> @@ -11,6 +11,8 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/byte_stream_buffer.h\"\n> +\n> /**\n> * \\file ipa_data_serializer.h\n> * \\brief IPA Data Serializer\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index e70688f6..33018ec1 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -10,6 +10,9 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> +#include \n> \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D872FC324C\n\tfor ;\n\tMon, 2 Sep 2024 19:32:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F5EE63471;\n\tMon, 2 Sep 2024 21:32:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33278618FF\n\tfor ;\n\tMon, 2 Sep 2024 21:32:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7E0A4CE;\n\tMon, 2 Sep 2024 21:31:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QRqv4rmC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725305496;\n\tbh=3ieD0ejgIcrT4fekVYjzqcvbh0wh62sJ94SWW9QRCMs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QRqv4rmCxq51lUn/MSOj6iFxObzCn0LJXiuVy4ExLpUeiXQQk27LIyseJXFKF09uD\n\tupJNbz4f4usCnZ8f6ZJ3T3w02ebIZtBO2NrCUindm282coxur2CyLQY2lBueqUxWXb\n\tuumr6/Dq6vN7mT8uURTJi9qypx8imF99+3+fDBok=","Date":"Mon, 2 Sep 2024 22:32:15 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 14/18] libcamera: libcamera: Add missing includes","Message-ID":"<20240902193215.GL1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-15-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-15-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]